Message ID | 1551479185-96604-1-git-send-email-hzhou8@ebay.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [ovs-dev] ovsdb: Add NEWS for fast-resync feature. | expand |
On Fri, Mar 01, 2019 at 02:26:25PM -0800, Han Zhou wrote: > From: Han Zhou <hzhou8@ebay.com> > > Signed-off-by: Han Zhou <hzhou8@ebay.com> > --- > NEWS | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/NEWS b/NEWS > index 0d73654..104b7be 100644 > --- a/NEWS > +++ b/NEWS > @@ -17,6 +17,11 @@ Post-v2.11.0 > conntrack fragmentation support. > * New "ovs-appctl dpctl/ipf-get-status" command for userspace datapath > conntrack fragmentation support. > + - OVSDB: > + * Support new monitoring method "monitor_cond_since" for fast data > + resync upon server restart or fail-over. The feature is available > + for C-IDL clients with clustered mode servers. See section 4.1.15 > + of ovsdb-server(7) for more details. Thanks. This is very developer-focused. A user will not necessarily understand the benefit, although it's kind of there in the middle. I think that a better description might be something like "OVSDB clients now resynchronize with their servers much more quickly after a brief disconnection, saving bandwidth and CPU time."
On Fri, Mar 1, 2019 at 2:53 PM Ben Pfaff <blp@ovn.org> wrote: > > On Fri, Mar 01, 2019 at 02:26:25PM -0800, Han Zhou wrote: > > From: Han Zhou <hzhou8@ebay.com> > > > > Signed-off-by: Han Zhou <hzhou8@ebay.com> > > --- > > NEWS | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/NEWS b/NEWS > > index 0d73654..104b7be 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -17,6 +17,11 @@ Post-v2.11.0 > > conntrack fragmentation support. > > * New "ovs-appctl dpctl/ipf-get-status" command for userspace datapath > > conntrack fragmentation support. > > + - OVSDB: > > + * Support new monitoring method "monitor_cond_since" for fast data > > + resync upon server restart or fail-over. The feature is available > > + for C-IDL clients with clustered mode servers. See section 4.1.15 > > + of ovsdb-server(7) for more details. > > Thanks. > > This is very developer-focused. A user will not necessarily understand > the benefit, although it's kind of there in the middle. I think that a > better description might be something like "OVSDB clients now > resynchronize with their servers much more quickly after a brief > disconnection, saving bandwidth and CPU time." Thanks Ben for the suggestion. I thought news is also for developers. Shall we mention the ovsdb protocol change in NEWS? I think it may help other ovsdb integrators to improve their client to utilize the new feature. If this is good to have, how about: "OVSDB clients can now resynchronize with clustered servers much more quickly after a brief disconnection, saving bandwidth and CPU time. See section 4.1.15 of ovsdb-server(7) for details of related OVSDB protocol extension."
On Fri, Mar 01, 2019 at 05:00:52PM -0800, Han Zhou wrote: > On Fri, Mar 1, 2019 at 2:53 PM Ben Pfaff <blp@ovn.org> wrote: > > > > On Fri, Mar 01, 2019 at 02:26:25PM -0800, Han Zhou wrote: > > > From: Han Zhou <hzhou8@ebay.com> > > > > > > Signed-off-by: Han Zhou <hzhou8@ebay.com> > > > --- > > > NEWS | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/NEWS b/NEWS > > > index 0d73654..104b7be 100644 > > > --- a/NEWS > > > +++ b/NEWS > > > @@ -17,6 +17,11 @@ Post-v2.11.0 > > > conntrack fragmentation support. > > > * New "ovs-appctl dpctl/ipf-get-status" command for userspace datapath > > > conntrack fragmentation support. > > > + - OVSDB: > > > + * Support new monitoring method "monitor_cond_since" for fast data > > > + resync upon server restart or fail-over. The feature is available > > > + for C-IDL clients with clustered mode servers. See section 4.1.15 > > > + of ovsdb-server(7) for more details. > > > > Thanks. > > > > This is very developer-focused. A user will not necessarily understand > > the benefit, although it's kind of there in the middle. I think that a > > better description might be something like "OVSDB clients now > > resynchronize with their servers much more quickly after a brief > > disconnection, saving bandwidth and CPU time." > > Thanks Ben for the suggestion. I thought news is also for developers. > Shall we mention the ovsdb protocol change in NEWS? I think it may > help other ovsdb integrators to improve their client to utilize the > new feature. If this is good to have, how about: > "OVSDB clients can now resynchronize with clustered servers much more > quickly after a brief disconnection, saving bandwidth and CPU time. > See section 4.1.15 of ovsdb-server(7) for details of related OVSDB > protocol extension." Well, of course NEWS can serve both communities, but it's the users who need more help. I like your new proposal. Will you send a revised patch?
diff --git a/NEWS b/NEWS index 0d73654..104b7be 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,11 @@ Post-v2.11.0 conntrack fragmentation support. * New "ovs-appctl dpctl/ipf-get-status" command for userspace datapath conntrack fragmentation support. + - OVSDB: + * Support new monitoring method "monitor_cond_since" for fast data + resync upon server restart or fail-over. The feature is available + for C-IDL clients with clustered mode servers. See section 4.1.15 + of ovsdb-server(7) for more details. v2.11.0 - 19 Feb 2019 ---------------------