diff mbox series

ARM: tegra: enforce PM requirement

Message ID 1549365418-26283-1-git-send-email-spujar@nvidia.com
State Accepted
Headers show
Series ARM: tegra: enforce PM requirement | expand

Commit Message

Sameer Pujar Feb. 5, 2019, 11:16 a.m. UTC
Drivers need to handle !PM case with work arounds for managing clocks
and power explicitly, which is not really necessary when PM support on
tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM
support and there is no reason why this cannot be done for 32-bit.

This patch selects PM unconditionally and drivers can rely on runtime
PM framework for clock and power management.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com>
---
 arch/arm/mach-tegra/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sameer Pujar Feb. 11, 2019, 1:59 p.m. UTC | #1
On 2/5/2019 4:46 PM, Sameer Pujar wrote:
> Drivers need to handle !PM case with work arounds for managing clocks
> and power explicitly, which is not really necessary when PM support on
> tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM
> support and there is no reason why this cannot be done for 32-bit.
>
> This patch selects PM unconditionally and drivers can rely on runtime
> PM framework for clock and power management.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com>
> ---
>   arch/arm/mach-tegra/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 7f3b83e..51a8fa3 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -10,6 +10,7 @@ menuconfig ARCH_TEGRA
>   	select HAVE_ARM_SCU if SMP
>   	select HAVE_ARM_TWD if SMP
>   	select PINCTRL
> +	select PM
>   	select PM_OPP
>   	select ARCH_HAS_RESET_CONTROLLER
>   	select RESET_CONTROLLER

Request for review comments or approval.

Thanks,
Sameer.
Dmitry Osipenko Feb. 25, 2019, 3:13 p.m. UTC | #2
05.02.2019 14:16, Sameer Pujar пишет:
> Drivers need to handle !PM case with work arounds for managing clocks
> and power explicitly, which is not really necessary when PM support on
> tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM

Tegra

> support and there is no reason why this cannot be done for 32-bit.
> 
> This patch selects PM unconditionally and drivers can rely on runtime
> PM framework for clock and power management.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com>
> ---

You probably should explain in the commit message what driver need this right now and why.
diff mbox series

Patch

diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 7f3b83e..51a8fa3 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -10,6 +10,7 @@  menuconfig ARCH_TEGRA
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select PINCTRL
+	select PM
 	select PM_OPP
 	select ARCH_HAS_RESET_CONTROLLER
 	select RESET_CONTROLLER