| Message ID | 1550003823-2089-1-git-send-email-gvrose8192@gmail.com |
|---|---|
| State | Accepted |
| Commit | fec800ed00e59d27f65c364e87e7295d6d1dcf87 |
| Headers | show |
| Series | [ovs-dev] debian: Add libelf-dev dependency for dkms | expand |
Looks good to me, thanks. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> On Tue, Feb 12, 2019 at 12:37 PM Greg Rose <gvrose8192@gmail.com> wrote: > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > and to build this the kernel compilation requires the libelf-dev > package. Add the dependency to the dkms build requirements. > > VMware-BZ: #2287968 > Signed-off-by: Greg Rose <gvrose8192@gmail.com> > --- > debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/control b/debian/control > index cde93f2..c70d2a6 100644 > --- a/debian/control > +++ b/debian/control > @@ -41,7 +41,7 @@ Description: Open vSwitch datapath module source - > module-assistant version > > Package: openvswitch-datapath-dkms > Architecture: all > -Depends: dkms (>= 1.95), libc6-dev, make, ${misc:Depends}, > ${python:Depends} > +Depends: dkms (>= 1.95), libc6-dev, libelf-dev, make, ${misc:Depends}, > ${python:Depends} > Description: Open vSwitch datapath module source - DKMS version > Open vSwitch is a production quality, multilayer, software-based, > Ethernet virtual switch. It is designed to enable massive network > -- > 1.8.3.1 > >
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#26 FILE: debian/control:44:
Depends: dkms (>= 1.95), libc6-dev, libelf-dev, make, ${misc:Depends}, ${python:Depends}
Lines checked: 33, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@bytheb.org
Thanks,
0-day Robot
On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > and to build this the kernel compilation requires the libelf-dev > package. Add the dependency to the dkms build requirements. > > VMware-BZ: #2287968 > Signed-off-by: Greg Rose <gvrose8192@gmail.com> Thanks, Greg (and Yifeng). I applied this to master.
On 2/12/2019 2:22 PM, Ben Pfaff wrote: > On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: >> Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations >> and to build this the kernel compilation requires the libelf-dev >> package. Add the dependency to the dkms build requirements. >> >> VMware-BZ: #2287968 >> Signed-off-by: Greg Rose <gvrose8192@gmail.com> > Thanks, Greg (and Yifeng). I applied this to master. Thank you Ben! Could we also get it backported to 2.11? Thanks, - Greg
On Tue, Feb 12, 2019 at 02:49:40PM -0800, Gregory Rose wrote: > On 2/12/2019 2:22 PM, Ben Pfaff wrote: > > On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: > > > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > > > and to build this the kernel compilation requires the libelf-dev > > > package. Add the dependency to the dkms build requirements. > > > > > > VMware-BZ: #2287968 > > > Signed-off-by: Greg Rose <gvrose8192@gmail.com> > > Thanks, Greg (and Yifeng). I applied this to master. > > Thank you Ben! Could we also get it backported to 2.11? Done!
diff --git a/debian/control b/debian/control index cde93f2..c70d2a6 100644 --- a/debian/control +++ b/debian/control @@ -41,7 +41,7 @@ Description: Open vSwitch datapath module source - module-assistant version Package: openvswitch-datapath-dkms Architecture: all -Depends: dkms (>= 1.95), libc6-dev, make, ${misc:Depends}, ${python:Depends} +Depends: dkms (>= 1.95), libc6-dev, libelf-dev, make, ${misc:Depends}, ${python:Depends} Description: Open vSwitch datapath module source - DKMS version Open vSwitch is a production quality, multilayer, software-based, Ethernet virtual switch. It is designed to enable massive network
Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations and to build this the kernel compilation requires the libelf-dev package. Add the dependency to the dkms build requirements. VMware-BZ: #2287968 Signed-off-by: Greg Rose <gvrose8192@gmail.com> --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)