Message ID | 1549652382-5476-1-git-send-email-skomatineni@nvidia.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [V18,1/6] i2c: tegra: sort all the include headers alphabetically | expand |
On Fri, Feb 08, 2019 at 10:59:37AM -0800, Sowjanya Komatineni wrote: > This patch sorts all the include headers alphabetically for the > I2C Tegra driver. > > Acked-by: Thierry Reding <treding@nvidia.com> > Reviewed-by: Dmitry Osipenko <digetx@gmail.com> > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > [V9/V10/V11/V12/V13/V14/V15/V16/V17/V18] : Rebased to 5.0-rc4 > [V3/V4/V5/V7/V8] : Removed unsued headers in tegra I2C ^ Header removal should be mentioned in the commit message, I think.
Sowjanya, first of all, thank you for keeping at this series. Also, for Dmitry and Thierry for their reviews. Hard work everyone, much appreciated. I just posted a few comments I had. No real show-stopper in there but maybe one or two discussion points. Thanks and happy hacking, Wolfram
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index c77adbbea0c7..79c6aa87499b 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -6,24 +6,21 @@ * Author: Colin Cross <ccross@android.com> */ -#include <linux/kernel.h> -#include <linux/init.h> -#include <linux/platform_device.h> #include <linux/clk.h> +#include <linux/delay.h> #include <linux/err.h> #include <linux/i2c.h> -#include <linux/io.h> +#include <linux/init.h> #include <linux/interrupt.h> -#include <linux/delay.h> -#include <linux/slab.h> -#include <linux/of_device.h> +#include <linux/io.h> +#include <linux/iopoll.h> +#include <linux/kernel.h> #include <linux/module.h> -#include <linux/reset.h> +#include <linux/of_device.h> #include <linux/pinctrl/consumer.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> -#include <linux/iopoll.h> - -#include <asm/unaligned.h> +#include <linux/reset.h> #define TEGRA_I2C_TIMEOUT (msecs_to_jiffies(1000)) #define BYTES_PER_FIFO_WORD 4