mbox series

[0/3,rs6000] x86-compat vector intrinsics fixes for BE, 32bit

Message ID 24aa2417-0f4e-2f3b-6a20-27a4cb124c71@us.ibm.com
Headers show
Series x86-compat vector intrinsics fixes for BE, 32bit | expand

Message

Paul A. Clarke Dec. 4, 2018, 2:58 p.m. UTC 
Many of the tests for the x86-compatible vector intrinsics implementations
were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled
with recent enough glibc that in most environments, the test were silently
passing without actually testing anything.

Patches which follow:
01: Fix the implementations.
02: Fix the test cases.
03: Enable the tests to actually run the test code.

Bootstrap and regression tested on POWER8 ppc64le, ppc64(be), ppc(32bit be),
and POWER7 ppc64(be).

OK for trunk?

PC

Comments

Segher Boessenkool Dec. 4, 2018, 6:07 p.m. UTC | #1 
On Tue, Dec 04, 2018 at 08:58:15AM -0600, Paul Clarke wrote:
> Many of the tests for the x86-compatible vector intrinsics implementations
> were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled
> with recent enough glibc that in most environments, the test were silently
> passing without actually testing anything.

And that will still be true for years to come.  Right.  Thanks for working
on this.

> Patches which follow:
> 01: Fix the implementations.
> 02: Fix the test cases.
> 03: Enable the tests to actually run the test code.

In the future, please thread the patches, so that all of them have
In-Reply-To: the 0/N patch.


Segher