mbox series

[SRU,cosmic] linux-buildinfo support

Message ID 20181203125454.GF5298@brain
State New
Headers show
Series [SRU,cosmic] linux-buildinfo support | expand

Pull-request

git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo

Message

Andy Whitcroft Dec. 3, 2018, 12:54 p.m. UTC 
Add linux-buildinfo package support.  This package contains all of the
ABI information accumulated during the build.  This means we no longer
have to install that data onto the end-user system, and means we only
have to download the ABI data when doing getabis.

Pull request below.

Proposing for SRU to cosmic.

-apw

The following changes since commit 4961d6dd48e577eac572dad52e0179edc22a2736:

  UBUNTU: Ubuntu-4.18.0-11.12 (2018-10-23 18:59:44 +0200)

are available in the Git repository at:

  git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo

for you to fetch changes up to fe7e277c1c27312f14481a85aea00cbeb6dfdb01:

  UBUNTU: [Packaging] buildinfo -- switch getabis configuration to new package (2018-12-03 12:20:32 +0000)

----------------------------------------------------------------
  * linux-buildinfo: pull out ABI information into its own package
    (LP: #1806380)
    - [Packaging] limit preparation to linux-libc-dev in headers
    - [Packaging] commonise debhelper invocation
    - [Packaging] ABI -- accumulate abi information at the end of the build
    - [Packaging] buildinfo -- add basic build information
    - [Packaging] buildinfo -- add firmware information to the flavour ABI
    - [Packaging] buildinfo -- add compiler information to the flavour ABI
    - [Packaging] buildinfo -- add buildinfo support to getabis
    - [Packaging] buildinfo -- switch getabis configuration to new package

  * linux packages should own /usr/lib/linux/triggers (LP: #1770256)
    - [Packaging] own /usr/lib/linux/triggers

Comments

Seth Forshee Dec. 3, 2018, 8:49 p.m. UTC | #1 
On Mon, Dec 03, 2018 at 12:54:54PM +0000, Andy Whitcroft wrote:
> Add linux-buildinfo package support.  This package contains all of the
> ABI information accumulated during the build.  This means we no longer
> have to install that data onto the end-user system, and means we only
> have to download the ABI data when doing getabis.
> 
> Pull request below.
> 
> Proposing for SRU to cosmic.

For all patches but "[Packaging] buildinfo -- switch getabis
configuration to new package":

Acked-by: Seth Forshee <seth.forshee@canonical.com>

As discussed offline, switching getabis should wait for a version of
getabis that still works if the prvious build did not produce a
buildinfo package.
Stefan Bader Dec. 4, 2018, 11:44 a.m. UTC | #2 
On 03.12.18 13:54, Andy Whitcroft wrote:
> git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo

I had a look (btw, somehow none of the git:// url's seem to work nowadays, all
need to be https://) and beside of one question about still having config* and
System.map in /boot from a non-buildinfo pkg (as external things might rely on
those), I do wonder whether the last patch needs adaption to fall back to not
buildinfo if it does not exist. Otherwise getabis will fail after applying the
patch set.

-Stefan
Andy Whitcroft Dec. 4, 2018, noon UTC | #3 
On Tue, Dec 04, 2018 at 12:44:35PM +0100, Stefan Bader wrote:
> On 03.12.18 13:54, Andy Whitcroft wrote:
> > git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo
> 
> I had a look (btw, somehow none of the git:// url's seem to work nowadays, all
> need to be https://) and beside of one question about still having config* and
> System.map in /boot from a non-buildinfo pkg (as external things might rely on
> those), I do wonder whether the last patch needs adaption to fall back to not
> buildinfo if it does not exist. Otherwise getabis will fail after applying the
> patch set.

I confirm that the linux-modules-* package still contain the config-*
and System.map-* files.

As Seth noted we are going to hold getabis update until we are producing
buildinfo.  I have a replacement patch in development which dynamically
handles both forms.

-apw
Stefan Bader Dec. 4, 2018, 1:34 p.m. UTC | #4 
On 03.12.18 13:54, Andy Whitcroft wrote:
> Add linux-buildinfo package support.  This package contains all of the
> ABI information accumulated during the build.  This means we no longer
> have to install that data onto the end-user system, and means we only
> have to download the ABI data when doing getabis.
> 
> Pull request below.
> 
> Proposing for SRU to cosmic.
> 
> -apw
> 
> The following changes since commit 4961d6dd48e577eac572dad52e0179edc22a2736:
> 
>   UBUNTU: Ubuntu-4.18.0-11.12 (2018-10-23 18:59:44 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo
> 
> for you to fetch changes up to fe7e277c1c27312f14481a85aea00cbeb6dfdb01:
> 
>   UBUNTU: [Packaging] buildinfo -- switch getabis configuration to new package (2018-12-03 12:20:32 +0000)
> 
> ----------------------------------------------------------------
>   * linux-buildinfo: pull out ABI information into its own package
>     (LP: #1806380)
>     - [Packaging] limit preparation to linux-libc-dev in headers
>     - [Packaging] commonise debhelper invocation
>     - [Packaging] ABI -- accumulate abi information at the end of the build
>     - [Packaging] buildinfo -- add basic build information
>     - [Packaging] buildinfo -- add firmware information to the flavour ABI
>     - [Packaging] buildinfo -- add compiler information to the flavour ABI
>     - [Packaging] buildinfo -- add buildinfo support to getabis
>     - [Packaging] buildinfo -- switch getabis configuration to new package
> 
>   * linux packages should own /usr/lib/linux/triggers (LP: #1770256)
>     - [Packaging] own /usr/lib/linux/triggers
> 
> 

So with either the last patch held back or replaced by the devel version

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kamal Mostafa Dec. 4, 2018, 4:10 p.m. UTC | #5 
As discussed offline, ACK to all except for this commit:

    - [Packaging] buildinfo -- switch getabis configuration to new package

Acked-by: Kamal Mostafa <kamal@canonical.com>

 -Kamal

On Mon, Dec 03, 2018 at 12:54:54PM +0000, Andy Whitcroft wrote:
> Add linux-buildinfo package support.  This package contains all of the
> ABI information accumulated during the build.  This means we no longer
> have to install that data onto the end-user system, and means we only
> have to download the ABI data when doing getabis.
> 
> Pull request below.
> 
> Proposing for SRU to cosmic.
> 
> -apw
> 
> The following changes since commit 4961d6dd48e577eac572dad52e0179edc22a2736:
> 
>   UBUNTU: Ubuntu-4.18.0-11.12 (2018-10-23 18:59:44 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo
> 
> for you to fetch changes up to fe7e277c1c27312f14481a85aea00cbeb6dfdb01:
> 
>   UBUNTU: [Packaging] buildinfo -- switch getabis configuration to new package (2018-12-03 12:20:32 +0000)
> 
> ----------------------------------------------------------------
>   * linux-buildinfo: pull out ABI information into its own package
>     (LP: #1806380)
>     - [Packaging] limit preparation to linux-libc-dev in headers
>     - [Packaging] commonise debhelper invocation
>     - [Packaging] ABI -- accumulate abi information at the end of the build
>     - [Packaging] buildinfo -- add basic build information
>     - [Packaging] buildinfo -- add firmware information to the flavour ABI
>     - [Packaging] buildinfo -- add compiler information to the flavour ABI
>     - [Packaging] buildinfo -- add buildinfo support to getabis
>     - [Packaging] buildinfo -- switch getabis configuration to new package
> 
>   * linux packages should own /usr/lib/linux/triggers (LP: #1770256)
>     - [Packaging] own /usr/lib/linux/triggers
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Dec. 4, 2018, 6:03 p.m. UTC | #6 
On 12/3/18 1:54 PM, Andy Whitcroft wrote:
> Add linux-buildinfo package support.  This package contains all of the
> ABI information accumulated during the build.  This means we no longer
> have to install that data onto the end-user system, and means we only
> have to download the ABI data when doing getabis.
>
> Pull request below.
>
> Proposing for SRU to cosmic.
>
> -apw
>
> The following changes since commit 4961d6dd48e577eac572dad52e0179edc22a2736:
>
>   UBUNTU: Ubuntu-4.18.0-11.12 (2018-10-23 18:59:44 +0200)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/cosmic linux-buildinfo
>
> for you to fetch changes up to fe7e277c1c27312f14481a85aea00cbeb6dfdb01:
>
>   UBUNTU: [Packaging] buildinfo -- switch getabis configuration to new package (2018-12-03 12:20:32 +0000)
>
> ----------------------------------------------------------------
>   * linux-buildinfo: pull out ABI information into its own package
>     (LP: #1806380)
>     - [Packaging] limit preparation to linux-libc-dev in headers
>     - [Packaging] commonise debhelper invocation
>     - [Packaging] ABI -- accumulate abi information at the end of the build
>     - [Packaging] buildinfo -- add basic build information
>     - [Packaging] buildinfo -- add firmware information to the flavour ABI
>     - [Packaging] buildinfo -- add compiler information to the flavour ABI
>     - [Packaging] buildinfo -- add buildinfo support to getabis
>     - [Packaging] buildinfo -- switch getabis configuration to new package
>
>   * linux packages should own /usr/lib/linux/triggers (LP: #1770256)
>     - [Packaging] own /usr/lib/linux/triggers
>
>
Applied to cosmic/master-next branch all except the last commit:

UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis
UBUNTU: [Packaging] buildinfo -- add compiler information to the flavour ABI
UBUNTU: [Packaging] buildinfo -- add firmware information to the flavour ABI
UBUNTU: [Packaging] buildinfo -- add basic build information
UBUNTU: [Packaging] ABI -- accumulate abi information at the end of the
build
UBUNTU: [Packaging] commonise debhelper invocation
UBUNTU: [Packaging] limit preparation to linux-libc-dev in headers
UBUNTU: [Packaging] own /usr/lib/linux/triggers


Thanks,
Kleber