| Message ID | 20181129132538.20179-3-fe@dev.tdt.de |
|---|---|
| State | Superseded |
| Delegated to: | Mathias Kresin |
| Headers | show |
| Series | lantiq: udpate kernel config | expand |
29/11/2018 14:25, Florian Eckert: > Enable mtd led trigger for lantiq devices by default to show MTD > activity > > Signed-off-by: Florian Eckert <fe@dev.tdt.de> > --- > target/linux/lantiq/config-4.14 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/lantiq/config-4.14 b/target/linux/lantiq/config-4.14 > index 055a428792..938aafc1f5 100644 > --- a/target/linux/lantiq/config-4.14 > +++ b/target/linux/lantiq/config-4.14 > @@ -127,6 +127,7 @@ CONFIG_LANTIQ_ETOP=y > CONFIG_LANTIQ_WDT=y > # CONFIG_LANTIQ_XRX200 is not set > CONFIG_LEDS_GPIO=y > +CONFIG_LEDS_TRIGGER_MTD=y > CONFIG_LIBFDT=y > CONFIG_MDIO_BUS=y > CONFIG_MDIO_DEVICE=y > Please move it to a subtarget config. This change will be applied to xway_legacy as well, which is our subtarget for boards with only 4 MByte of flash. Wasting flash space with a trigger not even used by any of the lantiq boards in the tree is a no go. Mathias
On 30/11/2018 00:48, Mathias Kresin wrote: > 29/11/2018 14:25, Florian Eckert: >> Enable mtd led trigger for lantiq devices by default to show MTD >> activity Hi, this is a very specific feature and I dont see any devices in tree using the driver. it'll increase the image size and we have several small flashed units in the target. cant you simplly make it AutoProbe during preinit ? there is next to no flash activity until preinit anyway. John >> >> Signed-off-by: Florian Eckert <fe@dev.tdt.de> >> --- >> target/linux/lantiq/config-4.14 | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/target/linux/lantiq/config-4.14 >> b/target/linux/lantiq/config-4.14 >> index 055a428792..938aafc1f5 100644 >> --- a/target/linux/lantiq/config-4.14 >> +++ b/target/linux/lantiq/config-4.14 >> @@ -127,6 +127,7 @@ CONFIG_LANTIQ_ETOP=y >> CONFIG_LANTIQ_WDT=y >> # CONFIG_LANTIQ_XRX200 is not set >> CONFIG_LEDS_GPIO=y >> +CONFIG_LEDS_TRIGGER_MTD=y >> CONFIG_LIBFDT=y >> CONFIG_MDIO_BUS=y >> CONFIG_MDIO_DEVICE=y >> > > Please move it to a subtarget config. > > This change will be applied to xway_legacy as well, which is our > subtarget for boards with only 4 MByte of flash. Wasting flash space > with a trigger not even used by any of the lantiq boards in the tree > is a no go. > > Mathias > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hello John > > this is a very specific feature and I dont see any devices in tree > using the driver. it'll increase the image size and we have several > small flashed units in the target. cant you simplly make it AutoProbe > during preinit ? there is next to no flash activity until preinit > anyway. > I've found another way. I would suggest that we add the trigger as kernel modules under /package/kernel/linux/modules/leds.mk. Anyone who needs this trigger can install it with opkg or install during image generation. What is your opinion? Regards Flo
Hello John >> this is a very specific feature and I dont see any devices in tree >> using the driver. It is also correct that no image use this trigger per default. But it is still possible for someone to put this trigger on a user defined LED if he wants. >> it'll increase the image size and we have several >> small flashed units in the target. I don't think the size will change significantly. >> cant you simplly make it AutoProbe >> during preinit ? there is next to no flash activity until preinit >> anyway. >> > > > I've found another way. I would suggest that we add the trigger as > kernel > modules under /package/kernel/linux/modules/leds.mk. Anyone who needs > this trigger can install it with opkg or install during image > generation. > I have to withdraw my statement. This is a bool option and must be switched on or off during compilation. This could not be compiled as a module. Regards Flo
On 03/12/2018 09:37, Florian Eckert wrote: > Hello John > >> >> this is a very specific feature and I dont see any devices in tree >> using the driver. it'll increase the image size and we have several >> small flashed units in the target. cant you simplly make it AutoProbe >> during preinit ? there is next to no flash activity until preinit >> anyway. >> > > > I've found another way. I would suggest that we add the trigger as kernel > modules under /package/kernel/linux/modules/leds.mk. Anyone who needs > this trigger can install it with opkg or install during image generation. > > What is your opinion? > sounds good. John > Regards > Flo > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/target/linux/lantiq/config-4.14 b/target/linux/lantiq/config-4.14 index 055a428792..938aafc1f5 100644 --- a/target/linux/lantiq/config-4.14 +++ b/target/linux/lantiq/config-4.14 @@ -127,6 +127,7 @@ CONFIG_LANTIQ_ETOP=y CONFIG_LANTIQ_WDT=y # CONFIG_LANTIQ_XRX200 is not set CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGER_MTD=y CONFIG_LIBFDT=y CONFIG_MDIO_BUS=y CONFIG_MDIO_DEVICE=y
Enable mtd led trigger for lantiq devices by default to show MTD activity Signed-off-by: Florian Eckert <fe@dev.tdt.de> --- target/linux/lantiq/config-4.14 | 1 + 1 file changed, 1 insertion(+)