| Message ID | 20181125095025.7542-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] msgpack: disables tests | expand |
Fabrice, All, On 2018-11-25 10:50 +0100, Fabrice Fontaine spake thusly: > tests are enabled if gperf and zlib are found and they fail on: > /home/buildroot/autobuild/run/instance-0/output/build/msgpack-2.1.5/include/msgpack/v1/object.hpp:652:34: > error: 'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess] > std::memcpy(&o, &v, sizeof(v)); > > So disable them. > > Fixes: > - http://autobuild.buildroot.org/results/7d7aa9723f02f9bc78dbf6248674be4d402199bf > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/msgpack/msgpack.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk > index 38df8f53af..abb6e2e214 100644 > --- a/package/msgpack/msgpack.mk > +++ b/package/msgpack/msgpack.mk > @@ -9,7 +9,7 @@ MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION)) > MSGPACK_LICENSE = BSL-1.0 > MSGPACK_LICENSE_FILES = COPYING LICENSE_1_0.txt > MSGPACK_INSTALL_STAGING = YES > -MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF > +MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF -DMSGPACK_BUILD_TESTS=OFF > > ifeq ($(BR2_STATIC_LIBS),y) > MSGPACK_CONF_OPTS += -DMSGPACK_ENABLE_SHARED=OFF > -- > 2.14.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On 25/11/2018 10:50, Fabrice Fontaine wrote: > tests are enabled if gperf and zlib are found and they fail on: > /home/buildroot/autobuild/run/instance-0/output/build/msgpack-2.1.5/include/msgpack/v1/object.hpp:652:34: > error: 'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess] > std::memcpy(&o, &v, sizeof(v)); > > So disable them. > > Fixes: > - http://autobuild.buildroot.org/results/7d7aa9723f02f9bc78dbf6248674be4d402199bf > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. I didn't bother copying the much more verbose commit log from Thomas, since this one was pretty good already. Regards, Arnout > --- > package/msgpack/msgpack.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk > index 38df8f53af..abb6e2e214 100644 > --- a/package/msgpack/msgpack.mk > +++ b/package/msgpack/msgpack.mk > @@ -9,7 +9,7 @@ MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION)) > MSGPACK_LICENSE = BSL-1.0 > MSGPACK_LICENSE_FILES = COPYING LICENSE_1_0.txt > MSGPACK_INSTALL_STAGING = YES > -MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF > +MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF -DMSGPACK_BUILD_TESTS=OFF > > ifeq ($(BR2_STATIC_LIBS),y) > MSGPACK_CONF_OPTS += -DMSGPACK_ENABLE_SHARED=OFF >
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > tests are enabled if gperf and zlib are found and they fail on: > /home/buildroot/autobuild/run/instance-0/output/build/msgpack-2.1.5/include/msgpack/v1/object.hpp:652:34: > error: 'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess] > std::memcpy(&o, &v, sizeof(v)); > So disable them. > Fixes: > - http://autobuild.buildroot.org/results/7d7aa9723f02f9bc78dbf6248674be4d402199bf > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2018.02.x and 2018.08.x, thanks.
diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk index 38df8f53af..abb6e2e214 100644 --- a/package/msgpack/msgpack.mk +++ b/package/msgpack/msgpack.mk @@ -9,7 +9,7 @@ MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION)) MSGPACK_LICENSE = BSL-1.0 MSGPACK_LICENSE_FILES = COPYING LICENSE_1_0.txt MSGPACK_INSTALL_STAGING = YES -MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF +MSGPACK_CONF_OPTS = -DMSGPACK_BUILD_EXAMPLES=OFF -DMSGPACK_BUILD_TESTS=OFF ifeq ($(BR2_STATIC_LIBS),y) MSGPACK_CONF_OPTS += -DMSGPACK_ENABLE_SHARED=OFF
tests are enabled if gperf and zlib are found and they fail on: /home/buildroot/autobuild/run/instance-0/output/build/msgpack-2.1.5/include/msgpack/v1/object.hpp:652:34: error: 'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess] std::memcpy(&o, &v, sizeof(v)); So disable them. Fixes: - http://autobuild.buildroot.org/results/7d7aa9723f02f9bc78dbf6248674be4d402199bf Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/msgpack/msgpack.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)