| Message ID | 20181015093013.31651-1-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: bcm4708-pinmux: improve example binding | expand |
On Mon, Oct 15, 2018 at 11:30 AM Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Broadcom SoC pins are controlled using CRU ("Clock and Reset Unit" or > "Central Resource Unit") registers. There are more CRU registers and > functions so CRU should be represented as a separated block in DT. > > Moreover CRU is a sub-block of DMU ("Device Management Unit") so that > one should also get its own node. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Patch applied. (I guess it answers my question with "let's fix this in-tree"). Yours, Linus Walleij
On Mon, Oct 15, 2018 at 4:30 AM Rafał Miłecki <zajec5@gmail.com> wrote: > > From: Rafał Miłecki <rafal@milecki.pl> > > Broadcom SoC pins are controlled using CRU ("Clock and Reset Unit" or > "Central Resource Unit") registers. There are more CRU registers and > functions so CRU should be represented as a separated block in DT. > > Moreover CRU is a sub-block of DMU ("Device Management Unit") so that > one should also get its own node. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/pinctrl/brcm,bcm4708-pinmux.txt | 31 ++++++++++++++++------ > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt > index af906f196e8c..0ce132c7e04c 100644 > --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt > @@ -30,13 +30,28 @@ For documentation of subnodes see: > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > Example: > - pinctrl@1800c1c0 { > - compatible = "brcm,bcm4708-pinmux"; > - reg = <0x1800c1c0 0x24>; > - reg-names = "cru_gpio_control"; > - > - spi { > - function = "spi"; > - groups = "spi_grp"; > + dmu@1800c000 { > + compatible = "simple-bus"; Everything in the DMU is going to warrant having sub-nodes? Wanting a node per provider (clocks, reset, phy, etc.) is common, but I tend to push back on that if it's only to instantiate drivers and there aren't any DT resources within the nodes. A pinctrl is one case that's justified, but what is a bit unusual here is the 'simple-bus' nodes for things that are more than a collection of independent devices. > + ranges = <0 0x1800c000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + cru@100 { > + compatible = "simple-bus"; Same question here. > + reg = <0x100 0x1a4>; > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + > + pin-controller@1c0 { 'pinctrl' was the standard name. > + compatible = "brcm,bcm4708-pinmux"; > + reg = <0x1c0 0x24>; > + reg-names = "cru_gpio_control"; > + > + spi-pins { > + function = "spi"; > + groups = "spi_grp"; > + }; > + }; > }; > }; > -- > 2.13.7 >
diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt index af906f196e8c..0ce132c7e04c 100644 --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4708-pinmux.txt @@ -30,13 +30,28 @@ For documentation of subnodes see: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Example: - pinctrl@1800c1c0 { - compatible = "brcm,bcm4708-pinmux"; - reg = <0x1800c1c0 0x24>; - reg-names = "cru_gpio_control"; - - spi { - function = "spi"; - groups = "spi_grp"; + dmu@1800c000 { + compatible = "simple-bus"; + ranges = <0 0x1800c000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + + cru@100 { + compatible = "simple-bus"; + reg = <0x100 0x1a4>; + ranges; + #address-cells = <1>; + #size-cells = <1>; + + pin-controller@1c0 { + compatible = "brcm,bcm4708-pinmux"; + reg = <0x1c0 0x24>; + reg-names = "cru_gpio_control"; + + spi-pins { + function = "spi"; + groups = "spi_grp"; + }; + }; }; };