| Message ID | 20180915192005.29373-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Commit | 4e6ea0d0436b452ce0cc0aae9183f6e3836e4c7a |
| Delegated to: | Peter Korsgaard |
| Headers | show |
| Series | [1/1] linuxptp: needs NPTL | expand |
Hi Fabrice, On Sat, Sep 15, 2018 at 09:20:05PM +0200, Fabrice Fontaine wrote: > /home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl > phc2sys.o: In function `do_loop': > phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep' > > Fixes: > - http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc This should only affect 2018.02.x. The latest uClibc-ng version provides clock_nanosleep() even for non NPTL configurations. baruch > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/linuxptp/Config.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/linuxptp/Config.in b/package/linuxptp/Config.in > index 3e18a0cb13..a32dbde2e1 100644 > --- a/package/linuxptp/Config.in > +++ b/package/linuxptp/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_LINUXPTP > bool "linuxptp" > + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() > help > The Linux PTP Project is the Precision Time Protocol > implementation according to IEEE standard 1588 for Linux. > @@ -11,3 +12,6 @@ config BR2_PACKAGE_LINUXPTP > not a goal. > > http://linuxptp.sourceforge.net/ > + > +comment "linuxptp needs a toolchain w/ NPTL" > + depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Hello, On Sun, 16 Sep 2018 08:05:22 +0300, Baruch Siach wrote: > On Sat, Sep 15, 2018 at 09:20:05PM +0200, Fabrice Fontaine wrote: > > /home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl > > phc2sys.o: In function `do_loop': > > phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep' > > > > Fixes: > > - http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc > > This should only affect 2018.02.x. The latest uClibc-ng version provides > clock_nanosleep() even for non NPTL configurations. Indeed. Due to this, perhaps there's a bunch of NPTL dependencies we could remove: package/blktrace/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() package/can-utils/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() package/dvblast/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() package/nilfs-utils/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() Anyway, for this linuxptp change, I have marked the patch as "Delegated to Peter" on patchwork, so that Peter takes care of it. Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > Hello, > On Sun, 16 Sep 2018 08:05:22 +0300, Baruch Siach wrote: >> On Sat, Sep 15, 2018 at 09:20:05PM +0200, Fabrice Fontaine wrote: >> > /home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc >> > phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o >> > -lm -lrt -o phc_ctl >> > phc2sys.o: In function `do_loop': >> > phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep' >> > >> > Fixes: >> > - http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc >> >> This should only affect 2018.02.x. The latest uClibc-ng version provides >> clock_nanosleep() even for non NPTL configurations. > Indeed. Due to this, perhaps there's a bunch of NPTL dependencies we > could remove: > package/blktrace/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() > package/can-utils/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() > package/dvblast/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() > package/nilfs-utils/Config.in: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() > Anyway, for this linuxptp change, I have marked the patch as "Delegated > to Peter" on patchwork, so that Peter takes care of it. Committed to 2018.02.x, thanks.
diff --git a/package/linuxptp/Config.in b/package/linuxptp/Config.in index 3e18a0cb13..a32dbde2e1 100644 --- a/package/linuxptp/Config.in +++ b/package/linuxptp/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_LINUXPTP bool "linuxptp" + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() help The Linux PTP Project is the Precision Time Protocol implementation according to IEEE standard 1588 for Linux. @@ -11,3 +12,6 @@ config BR2_PACKAGE_LINUXPTP not a goal. http://linuxptp.sourceforge.net/ + +comment "linuxptp needs a toolchain w/ NPTL" + depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
/home/buildroot/autobuild/run/instance-1/output/host/bin/or1k-linux-gcc phc_ctl.o phc.o sk.o util.o clockadj.o sysoff.o print.o version.o -lm -lrt -o phc_ctl phc2sys.o: In function `do_loop': phc2sys.c:(.text+0x18bc): undefined reference to `clock_nanosleep' Fixes: - http://autobuild.buildroot.org/results/a31e0a5ae15e1164115e4e5981ef5fb3c3284bcc Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/linuxptp/Config.in | 4 ++++ 1 file changed, 4 insertions(+)