Message ID | 1535527943-32566-1-git-send-email-krzk@kernel.org (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
snowpatch_ozlabs/checkpatch | warning | Test checkpatch on branch next |
snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > After commit faa16bc404d7 ("lib: Use existing define with > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux > directory thus any other user of this code should define proper include > path. > > This fixes the build error on powerpc with CONFIG_KERNEL_XZ: > > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0, > from ../arch/powerpc/boot/decompress.c:42: > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory > > Reported-by: Michal Kubecek <mkubecek@suse.cz> Reported earlier by Kbuild: https://lkml.org/lkml/2018/8/23/47 for the credits: Reported-by: kbuild test robot <lkp@intel.com> Best regards, Krzysztof
On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > After commit faa16bc404d7 ("lib: Use existing define with > > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux > > directory thus any other user of this code should define proper include > > path. > > > > This fixes the build error on powerpc with CONFIG_KERNEL_XZ: > > > > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0, > > from ../arch/powerpc/boot/decompress.c:42: > > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory > > > > Reported-by: Michal Kubecek <mkubecek@suse.cz> > > Reported earlier by Kbuild: > https://lkml.org/lkml/2018/8/23/47 > > for the credits: > Reported-by: kbuild test robot <lkp@intel.com> Technically Meelis reported it earlier: https://lkml.org/lkml/2018/8/22/365 ;)
On Wed, 29 Aug 2018 at 10:06, Mathieu Malaterre <malat@debian.org> wrote: > > On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > After commit faa16bc404d7 ("lib: Use existing define with > > > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux > > > directory thus any other user of this code should define proper include > > > path. > > > > > > This fixes the build error on powerpc with CONFIG_KERNEL_XZ: > > > > > > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0, > > > from ../arch/powerpc/boot/decompress.c:42: > > > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory > > > > > > Reported-by: Michal Kubecek <mkubecek@suse.cz> > > > > Reported earlier by Kbuild: > > https://lkml.org/lkml/2018/8/23/47 > > > > for the credits: > > Reported-by: kbuild test robot <lkp@intel.com> > > Technically Meelis reported it earlier: > > https://lkml.org/lkml/2018/8/22/365 > > ;) Oh, right... so for the full credits: Reported-by: Meelis Roos <mroos@linux.ee> Best regards, Krzysztof
On Wed, Aug 29, 2018 at 09:32:23AM +0200, Krzysztof Kozlowski wrote: > After commit faa16bc404d7 ("lib: Use existing define with > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux > directory thus any other user of this code should define proper include > path. > > This fixes the build error on powerpc with CONFIG_KERNEL_XZ: > > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0, > from ../arch/powerpc/boot/decompress.c:42: > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory > > Reported-by: Michal Kubecek <mkubecek@suse.cz> > Fixes: faa16bc404d7 ("lib: Use existing define with polynomial") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Only compile tested. > --- > arch/powerpc/boot/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > index 0fb96c26136f..ba4182fb185d 100644 > --- a/arch/powerpc/boot/Makefile > +++ b/arch/powerpc/boot/Makefile > @@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y) > BOOTCFLAGS += -fno-stack-protector > endif > > -BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) > +BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include > > DTC_FLAGS ?= -p 1024 > > -- > 2.7.4 > With this patch 4.19-rc1 builds and boots on ppc64le. Thank you. Tested-by: Michal Kubecek <mkubecek@suse.cz>
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 0fb96c26136f..ba4182fb185d 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y) BOOTCFLAGS += -fno-stack-protector endif -BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) +BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include DTC_FLAGS ?= -p 1024
After commit faa16bc404d7 ("lib: Use existing define with polynomial") the lib/xz/xz_crc32.c includes a header from include/linux directory thus any other user of this code should define proper include path. This fixes the build error on powerpc with CONFIG_KERNEL_XZ: In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0, from ../arch/powerpc/boot/decompress.c:42: ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory Reported-by: Michal Kubecek <mkubecek@suse.cz> Fixes: faa16bc404d7 ("lib: Use existing define with polynomial") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Only compile tested. --- arch/powerpc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)