Message ID | 1297846475-1772-1-git-send-email-ratbert.chuang@gmail.com |
---|---|
State | Accepted |
Commit | 3a8a83e08d832dc14e715f046aaf0d010d36c523 |
Delegated to: | Albert ARIBAUD |
Headers | show |
Hi, Le 16/02/2011 09:54, Po-Yu Chuang a écrit : > From: Po-Yu Chuang<ratbert@faraday-tech.com> > > get_sp() was incorrectly excluded if none of > CONFIG_SETUP_MEMORY_TAGS > CONFIG_CMDLINE_TAG > CONFIG_INITRD_TAG > CONFIG_SERIAL_TAG > CONFIG_REVISION_TAG > were defined. Which board exactly requires this patch? Amicalement,
Hi, 2011/2/17 Albert ARIBAUD <albert.aribaud@free.fr>: > Hi, > > Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >> From: Po-Yu Chuang<ratbert@faraday-tech.com> >> >> get_sp() was incorrectly excluded if none of >> CONFIG_SETUP_MEMORY_TAGS >> CONFIG_CMDLINE_TAG >> CONFIG_INITRD_TAG >> CONFIG_SERIAL_TAG >> CONFIG_REVISION_TAG >> were defined. > > > Which board exactly requires this patch? > I think it is a320evb.
Le 17/02/2011 13:54, Macpaul Lin a écrit : > Hi, > > 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >> Hi, >> >> Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>> >>> get_sp() was incorrectly excluded if none of >>> CONFIG_SETUP_MEMORY_TAGS >>> CONFIG_CMDLINE_TAG >>> CONFIG_INITRD_TAG >>> CONFIG_SERIAL_TAG >>> CONFIG_REVISION_TAG >>> were defined. >> >> >> Which board exactly requires this patch? >> > > I think it is a320evb. Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway. Amicalement,
Hi Po-Yu Chang, Le 16/02/2011 09:54, Po-Yu Chuang a écrit : > From: Po-Yu Chuang<ratbert@faraday-tech.com> > > get_sp() was incorrectly excluded if none of > CONFIG_SETUP_MEMORY_TAGS > CONFIG_CMDLINE_TAG > CONFIG_INITRD_TAG > CONFIG_SERIAL_TAG > CONFIG_REVISION_TAG > were defined. > > Signed-off-by: Po-Yu Chuang<ratbert@faraday-tech.com> > --- > v2: > rebase Applied, to u-boot-arm/master as it is actually an old patch submission and a bugfix. Amicalement,
Hi Albert, On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD <albert.aribaud@free.fr> wrote: > Le 17/02/2011 13:54, Macpaul Lin a écrit : >> 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >>> Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >>>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>>> >>>> get_sp() was incorrectly excluded if none of >>>> CONFIG_SETUP_MEMORY_TAGS >>>> CONFIG_CMDLINE_TAG >>>> CONFIG_INITRD_TAG >>>> CONFIG_SERIAL_TAG >>>> CONFIG_REVISION_TAG >>>> were defined. >>> >>> Which board exactly requires this patch? >> >> I think it is a320evb. > > Ok. This patch indeed removes the 'get_sp' error on this board's build, but > as an FYI, it does not build anyway. The following patches fix all the build errors of a320evb: (Although it still won't work, its timer still need some fix.) [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday [PATCH v2 2/2] arm: a320: use new ftpmu010 API best regards, Po-Yu Chuang
Le 18/02/2011 06:42, Po-Yu Chuang a écrit : > Hi Albert, > > On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD<albert.aribaud@free.fr> wrote: >> Le 17/02/2011 13:54, Macpaul Lin a écrit : >>> 2011/2/17 Albert ARIBAUD<albert.aribaud@free.fr>: >>>> Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >>>>> From: Po-Yu Chuang<ratbert@faraday-tech.com> >>>>> >>>>> get_sp() was incorrectly excluded if none of >>>>> CONFIG_SETUP_MEMORY_TAGS >>>>> CONFIG_CMDLINE_TAG >>>>> CONFIG_INITRD_TAG >>>>> CONFIG_SERIAL_TAG >>>>> CONFIG_REVISION_TAG >>>>> were defined. >>>> >>>> Which board exactly requires this patch? >>> >>> I think it is a320evb. >> >> Ok. This patch indeed removes the 'get_sp' error on this board's build, but >> as an FYI, it does not build anyway. > > The following patches fix all the build errors of a320evb: > (Although it still won't work, its timer still need some fix.) > > [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday > [PATCH v2 2/2] arm: a320: use new ftpmu010 API Thanks. If these receive review soon, I'll include them in my next pull along with the ARM machine type update. > best regards, > Po-Yu Chuang Amicalement,
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index a1649ee..7734953 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -327,12 +327,12 @@ void setup_revision_tag(struct tag **in_params) } #endif /* CONFIG_REVISION_TAG */ - static void setup_end_tag (bd_t *bd) { params->hdr.tag = ATAG_NONE; params->hdr.size = 0; } +#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ static ulong get_sp(void) { @@ -341,5 +341,3 @@ static ulong get_sp(void) asm("mov %0, sp" : "=r"(ret) : ); return ret; } - -#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */