| Message ID | 20180606024826.12536-1-aatteka@ovn.org |
|---|---|
| State | Accepted |
| Commit | 88125d68d56bed1ecc7f5ede7695ab4137d535f4 |
| Headers | show |
| Series | [ovs-dev] rhel: remove ovs-sim man page from temporary directory (also for RHEL) | expand |
On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: > Fix following compilation error when building rpm packages > with rhel/openvswitch.spec file. > > error: Installed (but unpackaged) file(s) found: > /usr/share/man/man1/ovs-sim.1.gz > > Signed-off-by: Ansis Atteka <aatteka@ovn.org> Seems reasonable. Acked-by: Ben Pfaff <blp@ovn.org>
On Tue, 5 Jun 2018 at 20:32, Ben Pfaff <blp@ovn.org> wrote: > > On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: > > Fix following compilation error when building rpm packages > > with rhel/openvswitch.spec file. > > > > error: Installed (but unpackaged) file(s) found: > > /usr/share/man/man1/ovs-sim.1.gz > > > > Signed-off-by: Ansis Atteka <aatteka@ovn.org> > > Seems reasonable. > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks for review, pushed it to master branch.
On 06/06/2018 08:49, Ansis Atteka wrote: > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff <blp@ovn.org> wrote: >> >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: >>> Fix following compilation error when building rpm packages >>> with rhel/openvswitch.spec file. >>> >>> error: Installed (but unpackaged) file(s) found: >>> /usr/share/man/man1/ovs-sim.1.gz >>> >>> Signed-off-by: Ansis Atteka <aatteka@ovn.org> >> >> Seems reasonable. >> >> Acked-by: Ben Pfaff <blp@ovn.org> > > Thanks for review, pushed it to master branch. > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Croid%40mellanox.com%7Cf2313ee2a27b4c3b6f4808d5cb7162e4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C1%7C636638610219834128&sdata=MtC6vpD2r%2FrXlgiwzmczB%2BdJ0vjkBcGxOQgq0g46Fn4%3D&reserved=0 > what about "make install" ? Should ovs-sim.1 be ignored from being installed with "make install" ? currently it is installed and being removed later when building rpm.
On Thu, Jun 07, 2018 at 10:17:53AM +0300, Roi Dayan wrote: > > > On 06/06/2018 08:49, Ansis Atteka wrote: > > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff <blp@ovn.org> wrote: > >> > >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote: > >>> Fix following compilation error when building rpm packages > >>> with rhel/openvswitch.spec file. > >>> > >>> error: Installed (but unpackaged) file(s) found: > >>> /usr/share/man/man1/ovs-sim.1.gz > >>> > >>> Signed-off-by: Ansis Atteka <aatteka@ovn.org> > >> > >> Seems reasonable. > >> > >> Acked-by: Ben Pfaff <blp@ovn.org> > > > > Thanks for review, pushed it to master branch. > > what about "make install" ? > Should ovs-sim.1 be ignored from being installed with "make install" ? > currently it is installed and being removed later when building rpm. Good point. I failed to consider the big picture. Here's an improvement: https://patchwork.ozlabs.org/patch/929707/
diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index 2c5f0409a..e8be048aa 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -100,6 +100,7 @@ rm \ $RPM_BUILD_ROOT/usr/share/man/man8/ovs-test.8 \ $RPM_BUILD_ROOT/usr/share/man/man8/ovs-l3ping.8 \ $RPM_BUILD_ROOT/usr/sbin/ovs-vlan-bug-workaround \ + $RPM_BUILD_ROOT/usr/share/man/man1/ovs-sim.1 \ $RPM_BUILD_ROOT/usr/share/man/man8/ovs-vlan-bug-workaround.8 \ $RPM_BUILD_ROOT/usr/bin/ovn-* \ $RPM_BUILD_ROOT/usr/share/man/man?/ovn-* \
Fix following compilation error when building rpm packages with rhel/openvswitch.spec file. error: Installed (but unpackaged) file(s) found: /usr/share/man/man1/ovs-sim.1.gz Signed-off-by: Ansis Atteka <aatteka@ovn.org> --- rhel/openvswitch.spec.in | 1 + 1 file changed, 1 insertion(+)