mbox series

[net-next,v3,0/8] sctp: refactor sctp_outq_flush

Message ID cover.1526318522.git.marcelo.leitner@gmail.com
Headers show
Series sctp: refactor sctp_outq_flush | expand

Message

Marcelo Ricardo Leitner May 14, 2018, 5:34 p.m. UTC 
Currently sctp_outq_flush does many different things and arguably
unrelated, such as doing transport selection and outq dequeueing.

This patchset refactors it into smaller and more dedicated functions.
The end behavior should be the same.

The next patchset will rework the function parameters.

Changes since v1:
- fix build issues on patches 3 and 4, and updated 5 and 8 because of
  it.

Changes since v2:
- fixed panic if building with just up to patch 3 applied

Marcelo Ricardo Leitner (8):
  sctp: add sctp_packet_singleton
  sctp: factor out sctp_outq_select_transport
  sctp: move the flush of ctrl chunks into its own function
  sctp: move outq data rtx code out of sctp_outq_flush
  sctp: move flushing of data chunks out of sctp_outq_flush
  sctp: move transport flush code out of sctp_outq_flush
  sctp: make use of gfp on retransmissions
  sctp: rework switch cases in sctp_outq_flush_data

 net/sctp/outqueue.c | 593 +++++++++++++++++++++++++++-------------------------
 1 file changed, 311 insertions(+), 282 deletions(-)

--
2.14.3

Comments

David Miller May 15, 2018, 2:57 a.m. UTC | #1 
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Mon, 14 May 2018 14:34:35 -0300

> Currently sctp_outq_flush does many different things and arguably
> unrelated, such as doing transport selection and outq dequeueing.
> 
> This patchset refactors it into smaller and more dedicated functions.
> The end behavior should be the same.
> 
> The next patchset will rework the function parameters.
> 
> Changes since v1:
> - fix build issues on patches 3 and 4, and updated 5 and 8 because of
>   it.
> 
> Changes since v2:
> - fixed panic if building with just up to patch 3 applied

Series applied, thanks.