| Message ID | 20180504125349.22734-1-rpalethorpe@suse.com |
|---|---|
| State | Accepted |
| Delegated to: | Cyril Hrubis |
| Headers | show |
| Series | lib: Remove retry message from TST_RETRY_FUNC | expand |
On Fri, May 4, 2018 at 8:53 PM, Richard Palethorpe <rpalethorpe@suse.com> wrote: > This message creates a lot of noise and uses extra resources on slower > machines. It also does not seem very useful. > Yes! That's the reason why I cancel the print message in shell achievement. :) http://lists.linux.it/pipermail/ltp/2018-May/007968.html​
Hi! Applied with ack from Li, thanks.
diff --git a/include/tst_common.h b/include/tst_common.h index d3d50eb19..27924766e 100644 --- a/include/tst_common.h +++ b/include/tst_common.h @@ -56,13 +56,10 @@ if (tst_ret_ == ERET) \ break; \ if (tst_delay_ < MAX_DELAY * 1000000) { \ - tst_res(TINFO, \ - #FUNC" returned %i, retrying" \ - " in %ius", tst_ret_, tst_delay_); \ usleep(tst_delay_); \ tst_delay_ *= 2; \ } else { \ - tst_brk(TBROK, #FUNC" failed"); \ + tst_brk(TBROK, #FUNC" timed out"); \ } \ } \ ERET; \
This message creates a lot of noise and uses extra resources on slower machines. It also does not seem very useful. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- This may help debug test failures on ARM machines by reducing the amount of noise. include/tst_common.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)