| Message ID | 1522142971-20739-16-git-send-email-kever.yang@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | rockchip: clean up board file for rockchip SoCs | expand |
> We need a dedicate sdram_init() function for those SoCS not > using SPL_FRAMEWORK. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > arch/arm/include/asm/arch-rockchip/sys_proto.h | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
On Tue, 27 Mar 2018, Kever Yang wrote: > We need a dedicate sdram_init() function for those SoCS not > using SPL_FRAMEWORK. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > arch/arm/include/asm/arch-rockchip/sys_proto.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/include/asm/arch-rockchip/sys_proto.h b/arch/arm/include/asm/arch-rockchip/sys_proto.h > index 3617ac2..7b7e336 100644 > --- a/arch/arm/include/asm/arch-rockchip/sys_proto.h > +++ b/arch/arm/include/asm/arch-rockchip/sys_proto.h > @@ -7,5 +7,8 @@ > #ifndef _ASM_ARCH_SYS_PROTO_H > #define _ASM_ARCH_SYS_PROTO_H > > +#ifndef CONFIG_SPL_FRAMEWORK > +void sdram_init(void); Please provide documentation for this function, as it is exposed in a header-file. > +#endif > > #endif /* _ASM_ARCH_SYS_PROTO_H */ >
diff --git a/arch/arm/include/asm/arch-rockchip/sys_proto.h b/arch/arm/include/asm/arch-rockchip/sys_proto.h index 3617ac2..7b7e336 100644 --- a/arch/arm/include/asm/arch-rockchip/sys_proto.h +++ b/arch/arm/include/asm/arch-rockchip/sys_proto.h @@ -7,5 +7,8 @@ #ifndef _ASM_ARCH_SYS_PROTO_H #define _ASM_ARCH_SYS_PROTO_H +#ifndef CONFIG_SPL_FRAMEWORK +void sdram_init(void); +#endif #endif /* _ASM_ARCH_SYS_PROTO_H */
We need a dedicate sdram_init() function for those SoCS not using SPL_FRAMEWORK. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- arch/arm/include/asm/arch-rockchip/sys_proto.h | 3 +++ 1 file changed, 3 insertions(+)