diff mbox series

[U-Boot,33/36] rockchip: dts: rk3399-firefly: enable uart2 in spl

Message ID 1522142971-20739-34-git-send-email-kever.yang@rock-chips.com
State Changes Requested
Delegated to: Philipp Tomsich
Headers show
Series rockchip: clean up board file for rockchip SoCs | expand

Commit Message

Kever Yang March 27, 2018, 9:29 a.m. UTC 
pre-loader console in SPL needs UART.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 arch/arm/dts/rk3399-firefly.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Robinson March 27, 2018, 11:49 a.m. UTC | #1 
On Tue, Mar 27, 2018 at 10:29 AM, Kever Yang <kever.yang@rock-chips.com> wrote:
> pre-loader console in SPL needs UART.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
>  arch/arm/dts/rk3399-firefly.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
> index f134c00..a007fa1 100644
> --- a/arch/arm/dts/rk3399-firefly.dts
> +++ b/arch/arm/dts/rk3399-firefly.dts
> @@ -648,6 +648,7 @@
>  };
>
>  &uart2 {
> +       u-boot,dm-pre-reloc;

if this is u-boot specific shouldn't it be in a rk3399-firefly-u-boot.dtsi ?

>         status = "okay";
>  };
>
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Kever Yang March 28, 2018, 2:28 a.m. UTC | #2 
Hi Peter,


On 03/27/2018 07:49 PM, Peter Robinson wrote:
> On Tue, Mar 27, 2018 at 10:29 AM, Kever Yang <kever.yang@rock-chips.com> wrote:
>> pre-loader console in SPL needs UART.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>  arch/arm/dts/rk3399-firefly.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
>> index f134c00..a007fa1 100644
>> --- a/arch/arm/dts/rk3399-firefly.dts
>> +++ b/arch/arm/dts/rk3399-firefly.dts
>> @@ -648,6 +648,7 @@
>>  };
>>
>>  &uart2 {
>> +       u-boot,dm-pre-reloc;
> if this is u-boot specific shouldn't it be in a rk3399-firefly-u-boot.dtsi ?

Yes, this should go to rk3399-firefly-u-boot.dtsi.

Thanks,
- Kever
>
>>         status = "okay";
>>  };
>>
>> --
>> 1.9.1
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
Philipp Tomsich April 1, 2018, 8:21 p.m. UTC | #3 
> pre-loader console in SPL needs UART.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/dts/rk3399-firefly.dts | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich April 1, 2018, 9:38 p.m. UTC | #4 
On Tue, 27 Mar 2018, Kever Yang wrote:

> pre-loader console in SPL needs UART.

Please describe what the change is (with this I still need to look at the 
diff).

>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

Just make this a separate patch, as I can apply this without the remainder 
of the series.

> ---
>
> arch/arm/dts/rk3399-firefly.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
> index f134c00..a007fa1 100644
> --- a/arch/arm/dts/rk3399-firefly.dts
> +++ b/arch/arm/dts/rk3399-firefly.dts
> @@ -648,6 +648,7 @@
> };
>
> &uart2 {
> +	u-boot,dm-pre-reloc;
> 	status = "okay";
> };

This should go to *-u-boot.dtsi.

>
>
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
index f134c00..a007fa1 100644
--- a/arch/arm/dts/rk3399-firefly.dts
+++ b/arch/arm/dts/rk3399-firefly.dts
@@ -648,6 +648,7 @@ 
 };
 
 &uart2 {
+	u-boot,dm-pre-reloc;
 	status = "okay";
 };