| Message ID | 20180112050745.5823.94244.stgit@john-Precision-Tower-5810 |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | sockmap sample update | expand |
On Thu, Jan 11, 2018 at 09:07:45PM -0800, John Fastabend wrote: > Put client sockets in blocking mode otherwise with sendmsg tests > its easy to overrun the socket buffers which results in the test > being aborted. > > The original non-blocking was added to handle listen/accept with > a single thread the client/accepted sockets do not need to be > non-blocking. > > Signed-off-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Martin KaFai Lau <kafai@fb.com>
diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c index c3295a7..818766b 100644 --- a/samples/sockmap/sockmap_user.c +++ b/samples/sockmap/sockmap_user.c @@ -109,7 +109,7 @@ static int sockmap_init_sockets(void) } /* Non-blocking sockets */ - for (i = 0; i < 4; i++) { + for (i = 0; i < 2; i++) { err = ioctl(*fds[i], FIONBIO, (char *)&one); if (err < 0) { perror("ioctl s1 failed()");
Put client sockets in blocking mode otherwise with sendmsg tests its easy to overrun the socket buffers which results in the test being aborted. The original non-blocking was added to handle listen/accept with a single thread the client/accepted sockets do not need to be non-blocking. Signed-off-by: John Fastabend <john.fastabend@gmail.com> --- samples/sockmap/sockmap_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)