Message ID | 20171019224626.31608-3-jakub.kicinski@netronome.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | tools: bpftool: add a "version" command, and fix several items | expand |
On 10/20/2017 12:46 AM, Jakub Kicinski wrote: > From: Quentin Monnet <quentin.monnet@netronome.com> > > Change the program to have a more consistent return code. Specifically, > do not make bpftool return an error code simply because it reaches the > end of the list of the eBPF programs to show. > > Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com> > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index aa6d72ea3807..ede7957adcd9 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -275,8 +275,10 @@ static int do_show(int argc, char **argv) while (true) { err = bpf_prog_get_next_id(id, &id); if (err) { - if (errno == ENOENT) + if (errno == ENOENT) { + err = 0; break; + } err("can't get next program: %s\n", strerror(errno)); if (errno == EINVAL) err("kernel too old?\n");