| Message ID | b5c9e26c4b8e652827b9d04dad2f821a329c3249.1502649259.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Headers | show |
Hi Thomas, On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote: > Fixes serious usability issues (Debian changelog): > > * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, > broken by an ICANN-mandated output change: > https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en > > Use snapshot.debian.org for the .dsc reference, since files tend to > disappear from the official Debian ftp site over time. > > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Why has this patch been marked 'Changes Requested'? It is independent of other patches in this series. baruch > This should go to master IMO. > --- > package/whois/whois.hash | 4 ++-- > package/whois/whois.mk | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/whois/whois.hash b/package/whois/whois.hash > index 6f65074c2c48..29623b529f20 100644 > --- a/package/whois/whois.hash > +++ b/package/whois/whois.hash > @@ -1,2 +1,2 @@ > -# From http://ftp.debian.org/debian/pool/main/w/whois/whois_5.2.14.dsc > -sha256 a41daf41abed0fbfa8c9c4b0e4a3f5f22d9876dd6feb9091aac12f8f4c38b0d2 whois_5.2.14.tar.xz > +# From http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois/whois_5.2.17.dsc > +sha256 257585678f571e18964667b41dc6543fe9da6123ac95743660c9c3ae1eba9664 whois_5.2.17.tar.xz > diff --git a/package/whois/whois.mk b/package/whois/whois.mk > index 87cc65fac4c7..22117cf3aa88 100644 > --- a/package/whois/whois.mk > +++ b/package/whois/whois.mk > @@ -4,8 +4,8 @@ > # > ################################################################################ > > -WHOIS_VERSION = 5.2.14 > -WHOIS_SITE = http://snapshot.debian.org/archive/debian/20161230T032015Z/pool/main/w/whois > +WHOIS_VERSION = 5.2.17 > +WHOIS_SITE = http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois > WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz > # take precedence over busybox implementation > WHOIS_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) $(TARGET_NLS_DEPENDENCIES)
Hello, On Tue, 15 Aug 2017 07:18:32 +0300, Baruch Siach wrote: > On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote: > > Fixes serious usability issues (Debian changelog): > > > > * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, > > broken by an ICANN-mandated output change: > > https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en > > > > Use snapshot.debian.org for the .dsc reference, since files tend to > > disappear from the official Debian ftp site over time. > > > > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > Why has this patch been marked 'Changes Requested'? It is independent of other > patches in this series. Because I always mark all patches in a series as Changes Requested if at least one of them had comments. Indeed, if it's a patch series, we expect the submitter to resend a complete new iteration of the series, even if some patches remain unchanged. Best regards, Thomas
On 15-08-17 10:40, Thomas Petazzoni wrote: > Hello, > > On Tue, 15 Aug 2017 07:18:32 +0300, Baruch Siach wrote: > >> On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote: >>> Fixes serious usability issues (Debian changelog): >>> >>> * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, >>> broken by an ICANN-mandated output change: >>> https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en >>> >>> Use snapshot.debian.org for the .dsc reference, since files tend to >>> disappear from the official Debian ftp site over time. >>> >>> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> >>> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> >> Why has this patch been marked 'Changes Requested'? It is independent of other >> patches in this series. > > Because I always mark all patches in a series as Changes Requested if > at least one of them had comments. Moreover, it was exactly this patch which had changes requested (switching upstream would change this patch completely). > Indeed, if it's a patch series, we > expect the submitter to resend a complete new iteration of the series, > even if some patches remain unchanged. But in this case, there are in fact no changes requested in the series (or rather, the request has been refuted). So I've changed the status back to New. Regards, Arnout
Hello, On Tue, 15 Aug 2017 12:12:01 +0200, Arnout Vandecappelle wrote: > > Indeed, if it's a patch series, we > > expect the submitter to resend a complete new iteration of the series, > > even if some patches remain unchanged. > > But in this case, there are in fact no changes requested in the series (or > rather, the request has been refuted). So I've changed the status back to New. Doh? Why? My comments still stand. It's not because Baruch said Debian is a better upstream than the real upstream that I agree with his comments. Best regards, Thomas
On 13-08-17 20:34, Baruch Siach wrote: > Fixes serious usability issues (Debian changelog): > > * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, > broken by an ICANN-mandated output change: > https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en > > Use snapshot.debian.org for the .dsc reference, since files tend to > disappear from the official Debian ftp site over time. > > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> As mentioned before, applied to master, thanks. I first checked the differences between 5.2.14 and 5.2.17, and it really is only in the whois databases (and in documentation) that there are changes. Source code hasn't changed. Peter, this should probably go to the LTS branches as well. Regards, Arnout > --- > > This should go to master IMO.
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes: > Fixes serious usability issues (Debian changelog): > * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, > broken by an ICANN-mandated output change: > https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en > Use snapshot.debian.org for the .dsc reference, since files tend to > disappear from the official Debian ftp site over time. > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > This should go to master IMO. Committed to 2017.02.x, thanks.
diff --git a/package/whois/whois.hash b/package/whois/whois.hash index 6f65074c2c48..29623b529f20 100644 --- a/package/whois/whois.hash +++ b/package/whois/whois.hash @@ -1,2 +1,2 @@ -# From http://ftp.debian.org/debian/pool/main/w/whois/whois_5.2.14.dsc -sha256 a41daf41abed0fbfa8c9c4b0e4a3f5f22d9876dd6feb9091aac12f8f4c38b0d2 whois_5.2.14.tar.xz +# From http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois/whois_5.2.17.dsc +sha256 257585678f571e18964667b41dc6543fe9da6123ac95743660c9c3ae1eba9664 whois_5.2.17.tar.xz diff --git a/package/whois/whois.mk b/package/whois/whois.mk index 87cc65fac4c7..22117cf3aa88 100644 --- a/package/whois/whois.mk +++ b/package/whois/whois.mk @@ -4,8 +4,8 @@ # ################################################################################ -WHOIS_VERSION = 5.2.14 -WHOIS_SITE = http://snapshot.debian.org/archive/debian/20161230T032015Z/pool/main/w/whois +WHOIS_VERSION = 5.2.17 +WHOIS_SITE = http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz # take precedence over busybox implementation WHOIS_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) $(TARGET_NLS_DEPENDENCIES)
Fixes serious usability issues (Debian changelog): * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv, broken by an ICANN-mandated output change: https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en Use snapshot.debian.org for the .dsc reference, since files tend to disappear from the official Debian ftp site over time. Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- This should go to master IMO. --- package/whois/whois.hash | 4 ++-- package/whois/whois.mk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)