Message ID | 4aa9d196-1e31-de86-4ba7-752a0a04122c@gmx.de |
---|---|
State | Superseded |
Headers | show |
Hi Jan, Greg 11.07.2017, 02:00, "Jan Kandziora" <jjj@gmx.de>: > Changes in v4 against v3 in this subpatch: > - adapted to linux-4.12.0 > > No changes in v3 against v2,v1 in this subpatch. > > The w1_ds28e17 driver from the next part of this patch needs to emit > single-bit read timeslots to the DS28E17. The w1 subsystem already > has this function but it is not exported outside drivers/w1/w1_io.c > > This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL, > same as the other exported symbols in drivers/w1/w1_io.c > > May be also useful later for writing drivers for other Onewire chips > which do single-bit communication. > > Signed-off-by: Jan Kandziora <jjj@gmx.de> Greg, please pull this patchset into the tree, I missed it last time and it stuck in the queues for a too long. Thank you. Acked-by: Evgeniy Polyakov <zbr@ioremap.net> > --- > From 6aedd1b890bd77bfe788f6af7a38724c16934ab0 Mon Sep 17 00:00:00 2001 > From: Jan Kandziora <jjj@gmx.de> > Date: Sat, 8 Jul 2017 21:14:27 +0200 > Subject: [PATCH 1/2] wire: export w1_touch_bit > > --- > drivers/w1/w1.h | 1 + > drivers/w1/w1_io.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.h b/drivers/w1/w1.h > index 758a7a6..e7af855 100644 > --- a/drivers/w1/w1.h > +++ b/drivers/w1/w1.h > @@ -295,6 +295,7 @@ int w1_attach_slave_device(struct w1_master *dev, > struct w1_reg_num *rn); > int w1_slave_detach(struct w1_slave *sl); > u8 w1_triplet(struct w1_master *dev, int bdir); > +u8 w1_touch_bit(struct w1_master *dev, int bit); > void w1_write_8(struct w1_master *, u8); > u8 w1_read_8(struct w1_master *); > int w1_reset_bus(struct w1_master *); > diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c > index 1134e6b..4bb77a1 100644 > --- a/drivers/w1/w1_io.c > +++ b/drivers/w1/w1_io.c > @@ -58,7 +58,7 @@ static u8 w1_read_bit(struct w1_master *dev); > * @dev: the master device > * @bit: 0 - write a 0, 1 - write a 0 read the level > */ > -static u8 w1_touch_bit(struct w1_master *dev, int bit) > +u8 w1_touch_bit(struct w1_master *dev, int bit) > { > if (dev->bus_master->touch_bit) > return dev->bus_master->touch_bit(dev->bus_master->data, bit); > @@ -69,6 +69,7 @@ static u8 w1_touch_bit(struct w1_master *dev, int bit) > return 0; > } > } > +EXPORT_SYMBOL_GPL(w1_touch_bit); > /** > * w1_write_bit() - Generates a write-0 or write-1 cycle. > -- > 2.13.1
On Thu, Jul 13, 2017 at 06:13:19PM +0300, Evgeniy Polyakov wrote: > Hi Jan, Greg > > 11.07.2017, 02:00, "Jan Kandziora" <jjj@gmx.de>: > > Changes in v4 against v3 in this subpatch: > > - adapted to linux-4.12.0 > > > > No changes in v3 against v2,v1 in this subpatch. > > > > The w1_ds28e17 driver from the next part of this patch needs to emit > > single-bit read timeslots to the DS28E17. The w1 subsystem already > > has this function but it is not exported outside drivers/w1/w1_io.c > > > > This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL, > > same as the other exported symbols in drivers/w1/w1_io.c > > > > May be also useful later for writing drivers for other Onewire chips > > which do single-bit communication. > > > > Signed-off-by: Jan Kandziora <jjj@gmx.de> > > Greg, please pull this patchset into the tree, I missed it last time and it stuck in the queues for a too long. > Thank you. > > Acked-by: Evgeniy Polyakov <zbr@ioremap.net> This is in no format that I can apply, sorry. Jan, can you resend it in a correct format? thanks, greg k-h
Am 17.07.2017 um 16:47 schrieb Greg Kroah-Hartman: > > This is in no format that I can apply, sorry. > > Jan, can you resend it in a correct format? > I sent part 1/2 again with the line breaks fixed (I hope.) Part 2/2 was okay? Kind regards Jan
On Tue, Jul 18, 2017 at 12:56:46AM +0200, Jan Kandziora wrote: > Am 17.07.2017 um 16:47 schrieb Greg Kroah-Hartman: > > > > This is in no format that I can apply, sorry. > > > > Jan, can you resend it in a correct format? > > > I sent part 1/2 again with the line breaks fixed (I hope.) > > Part 2/2 was okay? I have no idea, always resend the whole series. thanks, greg k-h
diff --git a/drivers/w1/w1.h b/drivers/w1/w1.h index 758a7a6..e7af855 100644 --- a/drivers/w1/w1.h +++ b/drivers/w1/w1.h @@ -295,6 +295,7 @@ int w1_attach_slave_device(struct w1_master *dev, struct w1_reg_num *rn); int w1_slave_detach(struct w1_slave *sl); u8 w1_triplet(struct w1_master *dev, int bdir); +u8 w1_touch_bit(struct w1_master *dev, int bit); void w1_write_8(struct w1_master *, u8); u8 w1_read_8(struct w1_master *); int w1_reset_bus(struct w1_master *); diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 1134e6b..4bb77a1 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1/w1_io.c @@ -58,7 +58,7 @@ static u8 w1_read_bit(struct w1_master *dev); * @dev: the master device * @bit: 0 - write a 0, 1 - write a 0 read the level */ -static u8 w1_touch_bit(struct w1_master *dev, int bit) +u8 w1_touch_bit(struct w1_master *dev, int bit) { if (dev->bus_master->touch_bit) return dev->bus_master->touch_bit(dev->bus_master->data, bit); @@ -69,6 +69,7 @@ static u8 w1_touch_bit(struct w1_master *dev, int bit) return 0; } } +EXPORT_SYMBOL_GPL(w1_touch_bit); /** * w1_write_bit() - Generates a write-0 or write-1 cycle. -- 2.13.1