| Message ID | 20101117050732.GB31724@bicker |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Wed, Nov 17, 2010 at 08:07:32AM +0300, Dan Carpenter wrote: > If the the li_request_list was empty then it returned with the lock > held. Instead of adding a "goto unlock" I just removed that special > case and let it go past the empty list_for_each_safe(). > > Signed-off-by: Dan Carpenter <error27@gmail.com> Nice catch. Thanks, I've grabbed this and put it into the ext4 patch queue and will be pushing it to Linus ASAP. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 61182fe..ef09d14 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void) struct ext4_li_request *elr; mutex_lock(&ext4_li_info->li_list_mtx); - if (list_empty(&ext4_li_info->li_request_list)) - return; - list_for_each_safe(pos, n, &ext4_li_info->li_request_list) { elr = list_entry(pos, struct ext4_li_request, lr_request);
If the the li_request_list was empty then it returned with the lock held. Instead of adding a "goto unlock" I just removed that special case and let it go past the empty list_for_each_safe(). Signed-off-by: Dan Carpenter <error27@gmail.com> --- This is a static checker patch. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html