Message ID | 1494944710-7901-1-git-send-email-anoob.soman@citrix.com |
---|---|
State | Not Applicable |
Headers | show |
On Tue, 2017-05-16 at 15:25 +0100, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman <anoob.soman@citrix.com> > --- > net/openvswitch/vport.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index 31cbc8c..a4887e7 100644 > --- a/net/openvswitch/vport.c > +++ b/net/openvswitch/vport.c > @@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb) > } > > skb->dev = vport->dev; > + skb_sender_cpu_clear(skb); > vport->ops->send(skb); > return; > LGTM Acked-by: Greg Rose <gvrose8192@gmail.com>
On 16 May 2017 at 07:25, Anoob Soman <anoob.soman@citrix.com> wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman <anoob.soman@citrix.com> Is this needed for 4.1 too?
On Tue, May 16, 2017 at 03:25:10PM +0100, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman <anoob.soman@citrix.com> > --- > net/openvswitch/vport.c | 1 + > 1 file changed, 1 insertion(+) Why is this a non-upstream patch? What commit in Linus's tree fixed this? Why not just backport that? thanks, greg k-h
On 17/05/17 09:19, Greg KH wrote: > Why is this a non-upstream patch? What commit in Linus's tree fixed > this? Why not just backport that? > > thanks, > > greg k-h Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than having a different patch. I think backport might be required for 4.1 as well, but I haven't checked. -Anoob.
On Wed, May 17, 2017 at 10:21:09AM +0100, Anoob Soman wrote: > On 17/05/17 09:19, Greg KH wrote: > > Why is this a non-upstream patch? What commit in Linus's tree fixed > > this? Why not just backport that? > > > > thanks, > > > > greg k-h > > Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better > skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than having a > different patch. So backporting that one patch solves the issue here? Can you please verify it, and let me know before I apply it? thanks, greg k-h
On 18/05/17 09:11, Greg KH wrote: > So backporting that one patch solves the issue here? Can you please > verify it, and let me know before I apply it? > > thanks, > > greg k-h yes, I can do that.
Hi Anoob, [auto build test ERROR on v4.9-rc8] [also build test ERROR on next-20170519] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Anoob-Soman/openvswitch-clear-sender-cpu-before-forwarding-packets/20170519-111009 config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/openvswitch/vport.c: In function 'ovs_vport_send': >> net/openvswitch/vport.c:513:2: error: implicit declaration of function 'skb_sender_cpu_clear' [-Werror=implicit-function-declaration] skb_sender_cpu_clear(skb); ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/skb_sender_cpu_clear +513 net/openvswitch/vport.c 507 packet_length(skb), mtu); 508 vport->dev->stats.tx_errors++; 509 goto drop; 510 } 511 512 skb->dev = vport->dev; > 513 skb_sender_cpu_clear(skb); 514 vport->ops->send(skb); 515 return; 516 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 31cbc8c..a4887e7 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb) } skb->dev = vport->dev; + skb_sender_cpu_clear(skb); vport->ops->send(skb); return;
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding") the skb->sender_cpu needs to be cleared before forwarding packets. Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") Signed-off-by: Anoob Soman <anoob.soman@citrix.com> --- net/openvswitch/vport.c | 1 + 1 file changed, 1 insertion(+)