| Message ID | 20170430232231.15151-2-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff <blp@ovn.org> wrote: > DHCP columns shouldn't be part of "Common Columns" because that's just for > external_ids and other_config. > > Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff <blp@ovn.org> wrote: > DHCP columns shouldn't be part of "Common Columns" because that's just for > external_ids and other_config. > > Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
On Tue, May 02, 2017 at 05:41:02PM -0700, Andy Zhou wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff <blp@ovn.org> wrote: > > DHCP columns shouldn't be part of "Common Columns" because that's just for > > external_ids and other_config. > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > Acked-by: Andy Zhou <azhou@ovn.org> Thanks Andy and Russell, I applied this to master.
diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index 7a1c20e73a7b..644785dbe83e 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -783,7 +783,7 @@ </column> </group> - <group title="Common Columns"> + <group title="DHCP"> <column name="dhcpv4_options"> This column defines the DHCPv4 Options to be included by the <code>ovn-controller</code> when it replies to the DHCPv4 requests. @@ -795,7 +795,9 @@ <code>ovn-controller</code> when it replies to the DHCPv6 requests. Please see the <ref table="DHCP_Options"/> table. </column> + </group> + <group title="Common Columns"> <column name="external_ids"> See <em>External IDs</em> at the beginning of this document. </column>
DHCP columns shouldn't be part of "Common Columns" because that's just for external_ids and other_config. Signed-off-by: Ben Pfaff <blp@ovn.org> --- ovn/ovn-nb.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)