Message ID | 20170225143811.GA28272@gondor.apana.org.au |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Sat, 25 Feb 2017 22:38:11 +0800 > Subject: rhashtable: Fix use before NULL check in bucket_table_free > > Dan Carpenter reported a use before NULL check bug in the function > bucket_table_free. In fact we don't need the NULL check at all as > no caller can provide a NULL argument. So this patch fixes this by > simply removing it. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Also applied, thanks Herbert.
diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 172454e..fac1a78 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -146,9 +146,7 @@ static void bucket_table_free(const struct bucket_table *tbl) if (tbl->nest) nested_bucket_table_free(tbl); - if (tbl) - kvfree(tbl->locks); - + kvfree(tbl->locks); kvfree(tbl); }