diff mbox

[U-Boot] mpc5200: Correct return value of memcpy function

Message ID 1485261837-28466-1-git-send-email-thomas.graziadei@omicronenergy.com
State Accepted
Commit de8c9317a891c1b30c465df1eb793c2861001919
Delegated to: York Sun
Headers show

Commit Message

thomas.graziadei@omicronenergy.com Jan. 24, 2017, 12:43 p.m. UTC
From: Mark Marshall <Mark.Marshall@omicron.at>

The memcpy() function returns a pointer to trg.

Signed-off-by: Mark Marshall <Mark.Marshall@omicron.at>
Reviewed-by: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
---
 arch/powerpc/lib/memcpy_mpc5200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

York Sun Feb. 7, 2017, 4:59 p.m. UTC | #1
On 01/24/2017 05:41 AM, thomas.graziadei@omicronenergy.com wrote:
> From: Mark Marshall <Mark.Marshall@omicron.at>
>
> The memcpy() function returns a pointer to trg.
>
> Signed-off-by: Mark Marshall <Mark.Marshall@omicron.at>
> Reviewed-by: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
> ---
>  arch/powerpc/lib/memcpy_mpc5200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/lib/memcpy_mpc5200.c b/arch/powerpc/lib/memcpy_mpc5200.c
> index 75a3ef9..7e5a005 100644
> --- a/arch/powerpc/lib/memcpy_mpc5200.c
> +++ b/arch/powerpc/lib/memcpy_mpc5200.c
> @@ -31,7 +31,7 @@ void *memcpy(void *trg, const void *src, size_t len)
>  	extern void* __memcpy(void *, const void *, size_t);
>  	char *s = (char *)src;
>  	char *t = (char *)trg;
> -	void *dest = (void *)src;
> +	void *dest = (void *)trg;
>
>  	/*
>  	 * Check is source address is in flash:
>

Looks like this is a duplicated patch.

York
thomas.graziadei@omicronenergy.com Feb. 8, 2017, 7:40 a.m. UTC | #2
On 02/07/2017 05:59 PM, york sun wrote:
> On 01/24/2017 05:41 AM, thomas.graziadei@omicronenergy.com wrote:
>> From: Mark Marshall <Mark.Marshall@omicron.at>
>>
>> The memcpy() function returns a pointer to trg.
>>
>> Signed-off-by: Mark Marshall <Mark.Marshall@omicron.at>
>> Reviewed-by: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
>> ---
>>   arch/powerpc/lib/memcpy_mpc5200.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/lib/memcpy_mpc5200.c b/arch/powerpc/lib/memcpy_mpc5200.c
>> index 75a3ef9..7e5a005 100644
>> --- a/arch/powerpc/lib/memcpy_mpc5200.c
>> +++ b/arch/powerpc/lib/memcpy_mpc5200.c
>> @@ -31,7 +31,7 @@ void *memcpy(void *trg, const void *src, size_t len)
>>   	extern void* __memcpy(void *, const void *, size_t);
>>   	char *s = (char *)src;
>>   	char *t = (char *)trg;
>> -	void *dest = (void *)src;
>> +	void *dest = (void *)trg;
>>
>>   	/*
>>   	 * Check is source address is in flash:
>>
> Looks like this is a duplicated patch.
Yes this is a duplicate.
>
> York
thanks,
Thomas
diff mbox

Patch

diff --git a/arch/powerpc/lib/memcpy_mpc5200.c b/arch/powerpc/lib/memcpy_mpc5200.c
index 75a3ef9..7e5a005 100644
--- a/arch/powerpc/lib/memcpy_mpc5200.c
+++ b/arch/powerpc/lib/memcpy_mpc5200.c
@@ -31,7 +31,7 @@  void *memcpy(void *trg, const void *src, size_t len)
 	extern void* __memcpy(void *, const void *, size_t);
 	char *s = (char *)src;
 	char *t = (char *)trg;
-	void *dest = (void *)src;
+	void *dest = (void *)trg;
 
 	/*
 	 * Check is source address is in flash: