| Message ID | 20161214135209.16369-4-hdegoede@redhat.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Dec 14, 2016 at 9:52 PM, Hans de Goede <hdegoede@redhat.com> wrote: > The adc-enable register for the axp288 is 0x82, not 0x84. > 0x82 is already defined as AXP20X_ADC_EN1 and that is what the > axp288_adc driver is actually using, so simply drop the wrong > AXP288_PMIC_ADC_EN define. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Chen-Yu Tsai <wens@csie.org> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 14 Dec 2016, Hans de Goede wrote: > The adc-enable register for the axp288 is 0x82, not 0x84. > 0x82 is already defined as AXP20X_ADC_EN1 and that is what the > axp288_adc driver is actually using, so simply drop the wrong > AXP288_PMIC_ADC_EN define. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > include/linux/mfd/axp20x.h | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index 199cce3..fe93e00 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -232,7 +232,6 @@ enum { > #define AXP288_PMIC_ADC_H 0x56 > #define AXP288_PMIC_ADC_L 0x57 > #define AXP288_ADC_TS_PIN_CTRL 0x84 > -#define AXP288_PMIC_ADC_EN 0x84 > > /* Fuel Gauge */ > #define AXP288_FG_RDC1_REG 0xba
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h index 199cce3..fe93e00 100644 --- a/include/linux/mfd/axp20x.h +++ b/include/linux/mfd/axp20x.h @@ -232,7 +232,6 @@ enum { #define AXP288_PMIC_ADC_H 0x56 #define AXP288_PMIC_ADC_L 0x57 #define AXP288_ADC_TS_PIN_CTRL 0x84 -#define AXP288_PMIC_ADC_EN 0x84 /* Fuel Gauge */ #define AXP288_FG_RDC1_REG 0xba
The adc-enable register for the axp288 is 0x82, not 0x84. 0x82 is already defined as AXP20X_ADC_EN1 and that is what the axp288_adc driver is actually using, so simply drop the wrong AXP288_PMIC_ADC_EN define. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- include/linux/mfd/axp20x.h | 1 - 1 file changed, 1 deletion(-)