| Message ID | 20161214135209.16369-3-hdegoede@redhat.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Dec 14, 2016 at 9:52 PM, Hans de Goede <hdegoede@redhat.com> wrote: > The R in PEK_DBR stands for rising, so it should be mapped to > AXP288_IRQ_POKP where the last P stands for positive edge. > > Likewise PEK_DBF should be mapped to the falling edge, aka the > _N_egative edge, so it should be mapped to AXP288_IRQ_POKN. > > This fixes the inverted powerbutton status reporting by the > axp20x-pek driver. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Chen-Yu Tsai <wens@csie.org> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 14 Dec 2016, Hans de Goede wrote: > The R in PEK_DBR stands for rising, so it should be mapped to > AXP288_IRQ_POKP where the last P stands for positive edge. > > Likewise PEK_DBF should be mapped to the falling edge, aka the > _N_egative edge, so it should be mapped to AXP288_IRQ_POKN. > > This fixes the inverted powerbutton status reporting by the > axp20x-pek driver. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/mfd/axp20x.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 9a81659..a294121 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -205,14 +205,14 @@ static struct resource axp22x_pek_resources[] = { > static struct resource axp288_power_button_resources[] = { > { > .name = "PEK_DBR", > - .start = AXP288_IRQ_POKN, > - .end = AXP288_IRQ_POKN, > + .start = AXP288_IRQ_POKP, > + .end = AXP288_IRQ_POKP, > .flags = IORESOURCE_IRQ, > }, > { > .name = "PEK_DBF", > - .start = AXP288_IRQ_POKP, > - .end = AXP288_IRQ_POKP, > + .start = AXP288_IRQ_POKN, > + .end = AXP288_IRQ_POKN, > .flags = IORESOURCE_IRQ, > }, > };
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 9a81659..a294121 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -205,14 +205,14 @@ static struct resource axp22x_pek_resources[] = { static struct resource axp288_power_button_resources[] = { { .name = "PEK_DBR", - .start = AXP288_IRQ_POKN, - .end = AXP288_IRQ_POKN, + .start = AXP288_IRQ_POKP, + .end = AXP288_IRQ_POKP, .flags = IORESOURCE_IRQ, }, { .name = "PEK_DBF", - .start = AXP288_IRQ_POKP, - .end = AXP288_IRQ_POKP, + .start = AXP288_IRQ_POKN, + .end = AXP288_IRQ_POKN, .flags = IORESOURCE_IRQ, }, };
The R in PEK_DBR stands for rising, so it should be mapped to AXP288_IRQ_POKP where the last P stands for positive edge. Likewise PEK_DBF should be mapped to the falling edge, aka the _N_egative edge, so it should be mapped to AXP288_IRQ_POKN. This fixes the inverted powerbutton status reporting by the axp20x-pek driver. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/mfd/axp20x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)