| Message ID | 1467711304-26430-1-git-send-email-yamamoto@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
"dev" <dev-bounces@openvswitch.org> wrote on 07/05/2016 04:35:04 AM: > From: YAMAMOTO Takashi <yamamoto@ovn.org> > To: dev@openvswitch.org > Cc: YAMAMOTO Takashi <yamamoto@ovn.org> > Date: 07/05/2016 04:40 AM > Subject: [ovs-dev] [PATCH] ovn.at: Use = instead of == for test > Sent by: "dev" <dev-bounces@openvswitch.org> > > == is a GNU extension which might not be available. > > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> > --- > tests/ovn.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index feb68d3..3436417 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -839,7 +839,7 @@ for is in 1 2 3; do > > if test $d != $s && test $s != 11; then acl2=$d; > else acl2=; fi > if test $d != $s && test $d != 33; then acl3=$d; > else acl3=; fi > - if test $d == $s || (test $js == 1 && test $d == 33); then > + if test $d = $s || (test $js = 1 && test $d = 33); then > # Source of 11, 21, or 31 and dest of 33 shouldbe dropped > # due to the 4th ACL that uses address_set(set1). > acl4= > @@ -1998,7 +1998,7 @@ test_arp() { > as $hv ovs-appctl netdev-dummy/receive vif$inport $request > #as $hv ovs-appctl ofproto/trace br-int in_port=$inport $request > if test $drop != 1; then > - if test X$reply_ha == X; then > + if test X$reply_ha = X; then > # Expect to receive the broadcast ARP on the other > logical switch ports > # if no reply is expected. > local i j > -- > 2.5.4 (Apple Git-61) The above is pretty darn trivial and it does work, so... Acked-By: Ryan Moats <rmoats@us.ibm.com>
On Tue, Jul 05, 2016 at 06:35:04PM +0900, YAMAMOTO Takashi wrote: > == is a GNU extension which might not be available. > > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
applied to master, thank you. On Wed, Jul 6, 2016 at 12:36 AM, Ben Pfaff <blp@ovn.org> wrote: > On Tue, Jul 05, 2016 at 06:35:04PM +0900, YAMAMOTO Takashi wrote: > > == is a GNU extension which might not be available. > > > > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> >
diff --git a/tests/ovn.at b/tests/ovn.at index feb68d3..3436417 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -839,7 +839,7 @@ for is in 1 2 3; do if test $d != $s && test $s != 11; then acl2=$d; else acl2=; fi if test $d != $s && test $d != 33; then acl3=$d; else acl3=; fi - if test $d == $s || (test $js == 1 && test $d == 33); then + if test $d = $s || (test $js = 1 && test $d = 33); then # Source of 11, 21, or 31 and dest of 33 should be dropped # due to the 4th ACL that uses address_set(set1). acl4= @@ -1998,7 +1998,7 @@ test_arp() { as $hv ovs-appctl netdev-dummy/receive vif$inport $request #as $hv ovs-appctl ofproto/trace br-int in_port=$inport $request if test $drop != 1; then - if test X$reply_ha == X; then + if test X$reply_ha = X; then # Expect to receive the broadcast ARP on the other logical switch ports # if no reply is expected. local i j
== is a GNU extension which might not be available. Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)