mbox

[0/3] ARM: OXNAS pull request for 4.7

Message ID 1459521689-13962-1-git-send-email-narmstrong@baylibre.com
State New
Headers show

Pull-request

https://github.com/superna9999/linux.git tags/ox810se-arm

Message

Neil Armstrong April 1, 2016, 2:41 p.m. UTC
This is the ARM pull request for the OXNAS platform.
It also includes one-line change into irq-versatile-fpga.

The following changes since commit 1e6d88ccf41c7ef2d6c99aa5e7fb9215aa0e5423:

  Merge tag 'nios2-v4.6-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/lftan/nios2 (2016-03-30 20:40:42 -0500)

are available in the git repository at:

  https://github.com/superna9999/linux.git tags/ox810se-arm

for you to fetch changes up to b4f122cdd148696e0d8c5f815ac48c5b9ed9de3f:

  MAINTAINERS: add maintainer entry for ARM/OXNAS platform (2016-04-01 15:51:54 +0200)

----------------------------------------------------------------
ARM: Add OXNAS Platform Support

Changes since original v3 patchset :
- Get rid of PLX Technology

v3 patchset : http://lkml.kernel.org/r/1458838215-23314-1-git-send-email-narmstrong@baylibre.com

----------------------------------------------------------------
Neil Armstrong (3):
      irqchip: versatile-fpga: add new compatible for OX810SE SoC
      ARM: Add new mach-oxnas
      MAINTAINERS: add maintainer entry for ARM/OXNAS platform

 MAINTAINERS                          |  9 +++++++++
 arch/arm/Kconfig                     |  2 ++
 arch/arm/mach-oxnas/Kconfig          | 24 ++++++++++++++++++++++++
 drivers/irqchip/irq-versatile-fpga.c |  1 +
 4 files changed, 36 insertions(+)
 create mode 100644 arch/arm/mach-oxnas/Kconfig

Comments

Olof Johansson April 13, 2016, 5:54 p.m. UTC | #1
On Fri, Apr 01, 2016 at 04:41:29PM +0200, Neil Armstrong wrote:
> This is the ARM pull request for the OXNAS platform.
> It also includes one-line change into irq-versatile-fpga.
> 
> The following changes since commit 1e6d88ccf41c7ef2d6c99aa5e7fb9215aa0e5423:
> 
>   Merge tag 'nios2-v4.6-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/lftan/nios2 (2016-03-30 20:40:42 -0500)
> 
> are available in the git repository at:
> 
>   https://github.com/superna9999/linux.git tags/ox810se-arm
> 
> for you to fetch changes up to b4f122cdd148696e0d8c5f815ac48c5b9ed9de3f:
> 
>   MAINTAINERS: add maintainer entry for ARM/OXNAS platform (2016-04-01 15:51:54 +0200)
> 
> ----------------------------------------------------------------
> ARM: Add OXNAS Platform Support
> 
> Changes since original v3 patchset :
> - Get rid of PLX Technology
> 
> v3 patchset : http://lkml.kernel.org/r/1458838215-23314-1-git-send-email-narmstrong@baylibre.com

Hi Neil,

This branch seems to start from an arbitrary point and not an -rc. We want
branches only starting at -rc releases, please.

For a new platform like this, while patch volume is low, it might be easier to
just submit patches that we apply directly.

Some further questions: We usually try to add mach directories per vendor so we
don't get large number of them. Would it make sense to call it something else
than OxNAS here? I saw some patches posted referring to PLX instead of Oxford
Semi as well. What's up with that?

There's an overall lack of documentation of the platform in the initial patches
as well. An overview of it, maybe with links to product information, etc, is
useful.



-Olof
Neil Armstrong April 14, 2016, 6:54 a.m. UTC | #2
On 04/13/2016 07:54 PM, Olof Johansson wrote:
> On Fri, Apr 01, 2016 at 04:41:29PM +0200, Neil Armstrong wrote:
>> This is the ARM pull request for the OXNAS platform.
>> It also includes one-line change into irq-versatile-fpga.
>>
>> The following changes since commit 1e6d88ccf41c7ef2d6c99aa5e7fb9215aa0e5423:
>>
>>   Merge tag 'nios2-v4.6-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/lftan/nios2 (2016-03-30 20:40:42 -0500)
>>
>> are available in the git repository at:
>>
>>   https://github.com/superna9999/linux.git tags/ox810se-arm
>>
>> for you to fetch changes up to b4f122cdd148696e0d8c5f815ac48c5b9ed9de3f:
>>
>>   MAINTAINERS: add maintainer entry for ARM/OXNAS platform (2016-04-01 15:51:54 +0200)
>>
>> ----------------------------------------------------------------
>> ARM: Add OXNAS Platform Support
>>
>> Changes since original v3 patchset :
>> - Get rid of PLX Technology
>>
>> v3 patchset : http://lkml.kernel.org/r/1458838215-23314-1-git-send-email-narmstrong@baylibre.com

Hi Olof,
> Hi Neil,
> 
> This branch seems to start from an arbitrary point and not an -rc. We want
> branches only starting at -rc releases, please.
OK, I wasn't aware of this point, I'll send back from an -rc release.

> 
> For a new platform like this, while patch volume is low, it might be easier to
> just submit patches that we apply directly.
Sure, Arnd asked me to submit a pull request instead.

> 
> Some further questions: We usually try to add mach directories per vendor so we
> don't get large number of them. Would it make sense to call it something else
> than OxNAS here? I saw some patches posted referring to PLX instead of Oxford
> Semi as well. What's up with that?
This is a rather complex situation, OxNas is the SoC family, and AFAIK only two SoCs
from Oxford Semiconductor, which was bought by Avago which is now Broadcom, are only
in well known NAS products and sticks (OX810 and OX820).
Here OxNas makes far more sense than Oxsemi, and matches the other drivers with the
oxnas naming.

> 
> There's an overall lack of documentation of the platform in the initial patches
> as well. An overview of it, maybe with links to product information, etc, is
> useful.

Do you mean in the oxnas platform bindings ?

> 
> 
> -Olof
> 

Thanks,
Neil