| Message ID | 4C0EA61B.9040807@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill <jason@redhat.com> wrote:
> I have found that I need this additional patch. Any objection?
Is hard-coding directory names necessary here? How does this work for
other subdirectories?
Ciao!
Steven
On 06/08/2010 05:50 PM, Steven Bosscher wrote: > On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill<jason@redhat.com> wrote: >> I have found that I need this additional patch. Any objection? > > Is hard-coding directory names necessary here? How does this work for > other subdirectories? Other subdirectories have their Make-lang.in fragments generate a TAGS.sub file, and the main TAGS rule walks SUBDIRS collecting them. Jason
On Tue, Jun 8, 2010 at 11:54 PM, Jason Merrill <jason@redhat.com> wrote: > On 06/08/2010 05:50 PM, Steven Bosscher wrote: >> >> On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill<jason@redhat.com> wrote: >>> >>> I have found that I need this additional patch. Any objection? >> >> Is hard-coding directory names necessary here? How does this work for >> other subdirectories? > > Other subdirectories have their Make-lang.in fragments generate a TAGS.sub > file, and the main TAGS rule walks SUBDIRS collecting them. OK, the plan is to pute the c-family/ Makefile bits in c-family/Make-somename.in (and make this a general scheme for subdirectories). I'll remember to remove c-family again from Makefile.in if/when that change is committed. Ciao! Steven
On Tue, 8 Jun 2010, Jason Merrill wrote:
> I have found that I need this additional patch. Any objection?
No objections from me.
commit 543e778629a857bde16cd634b44974ec5b4d8413
Author: Jason Merrill <jason@redhat.com>
Date: Tue Jun 8 16:13:11 2010 -0400
* Makefile.in (TAGS): Collect tags info from c-family.
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index a190225..806b4b1 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -4999,7 +4999,7 @@ TAGS: lang.tags
incs="$$incs --include $$dir/TAGS.sub"; \
fi; \
done; \
- etags -o TAGS.sub *.h *.c; \
+ etags -o TAGS.sub c-family/*.h c-family/*.c *.h *.c; \
etags --include TAGS.sub $$incs)
# -----------------------------------------------------