diff mbox

UBIFS Dump Stack on Android

Message ID CA+EcR23cFb_cY=CAHGcpaq9P9KU2mTDXbTh-OiuK3Oq_o3idDA@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Han Xu March 4, 2016, 2:21 a.m. UTC 
Hi Richard,

We found an issue on Kernel 4.1 when running Android on UBIFS. Android
required to enable SELINUX and exposed the issue, one ubifs_assert()
function failed and caused dump stack.

UBIFS: Kill unneeded locking in ubifs_init_security

We also noticed Google maintained Kernel 4.1 AOSP didn't cherry-pick
the patch either. Could you please help to check this issue, Thanks.

Comments

Richard Weinberger March 4, 2016, 7:20 p.m. UTC | #1 
Han,

Am 04.03.2016 um 03:21 schrieb Han Xu:
> Hi Richard,
> 
> We found an issue on Kernel 4.1 when running Android on UBIFS. Android
> required to enable SELINUX and exposed the issue, one ubifs_assert()
> function failed and caused dump stack.
> 
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -309,7 +309,6 @@ static int setxattr(struct inode *host, const char
> *name, const void *value,
>         union ubifs_key key;
>         int err, type;
> 
>         ubifs_assert(mutex_is_locked(&host->i_mutex));
> 
> It may related to your recent code change
> UBIFS: Kill unneeded locking in ubifs_init_security
> 
> We also noticed Google maintained Kernel 4.1 AOSP didn't cherry-pick
> the patch either. Could you please help to check this issue, Thanks.
> 

Well, does reverting my patch make the issue go away?
How to do you trigger it?

Thanks,
//richard
diff mbox

Patch

--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -309,7 +309,6 @@  static int setxattr(struct inode *host, const char
*name, const void *value,
        union ubifs_key key;
        int err, type;

        ubifs_assert(mutex_is_locked(&host->i_mutex));

It may related to your recent code change