diff mbox

[COMMITTED] Adjust sparc 32-bit __sqrtl_finite version tag.

Message ID 20160125.110050.1847019402132253680.davem@davemloft.net
State New
Headers show

Commit Message

David Miller Jan. 25, 2016, 7 p.m. UTC 
From: Joseph Myers <joseph@codesourcery.com>
Date: Mon, 25 Jan 2016 18:47:21 +0000

> Presumably you also need to add a Versions entry for this and maybe define 
> the function using versioned_symbol, so that it gets exported at the new 
> version and does not get exported at the old version?

Hmmm, something like this?

Comments

Richard Henderson Jan. 25, 2016, 7:08 p.m. UTC | #1 
On 01/25/2016 11:00 AM, David Miller wrote:
>  }
>  strong_alias (__ieee754_sqrtl, __sqrtl_finite)
> +
> +#include <shlib-compat.h>
> +versioned_symbol (libm, __sqrtl_finite, sqrtl_finite, GLIBC_2_23);

sqrtl_finite (no underscores) is not an exported symbol.

Drop the strong alias and version from __ieee754_sqrtl to __sqrtl_finite.


r~
diff mbox

Patch

diff --git a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
index 46ad861..30d4d34 100644
--- a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
+++ b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
@@ -26,3 +26,6 @@  __ieee754_sqrtl (long double x)
   return _Q_sqrt (x);
 }
 strong_alias (__ieee754_sqrtl, __sqrtl_finite)
+
+#include <shlib-compat.h>
+versioned_symbol (libm, __sqrtl_finite, sqrtl_finite, GLIBC_2_23);
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
index c9a5b3e..a0b9c19 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
@@ -24,3 +24,9 @@  libc {
     fallocate64;
   }
 }
+
+libm {
+  GLIBC_2.23 {
+    __sqrtl_finite;
+  }
+}