Message ID | 1451309456-27538-1-git-send-email-nrubinstein@aldebaran.com |
---|---|
State | Changes Requested |
Headers | show |
Noé, On Mon, 28 Dec 2015 14:30:56 +0100, Noé Rubinstein wrote: > Change-Id: I1797d19039938e750c92bb89d05b2f05c10668ad We don't need a Change-Id. We need a Signed-off-by line as well as a reference to the autobuilder failure that you are fixing. And also a short explanation on how you're fixing the failure (backport an upstream patch, etc.). > diff --git a/package/tpm-tools/tpm-tools.mk b/package/tpm-tools/tpm-tools.mk > index 20df489..9e4d66a 100644 > --- a/package/tpm-tools/tpm-tools.mk > +++ b/package/tpm-tools/tpm-tools.mk > @@ -11,6 +11,7 @@ TPM_TOOLS_STRIP_COMPONENTS = 2 > TPM_TOOLS_LICENSE = Common Public License Version 1.0 > TPM_TOOLS_LICENSE_FILES = LICENSE > TPM_TOOLS_DEPENDENCIES = trousers openssl > +TPM_TOOLS_AUTORECONF = yes Please add a comment: # We're patching configure.in Thanks! Thomas
Isn't better to fix the code, instead of taking off -Werror ? If it is not possible to fix the code (a huge amount of errors, for instance, caused by a new compiler version), maybe some -Wno directive would be better. Thanks ----- Mensagem original ----- > De: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com> > Para: "Noé Rubinstein" <noe.rubinstein@gmail.com> > Cc: "Noé Rubinstein" <nrubinstein@aldebaran.com>, buildroot@buildroot.org > Enviadas: Segunda-feira, 28 de dezembro de 2015 11:37:49 > Assunto: Re: [Buildroot] [PATCH] tpm-tools: fix build failures caused by -Werror > Noé, > > On Mon, 28 Dec 2015 14:30:56 +0100, Noé Rubinstein wrote: >> Change-Id: I1797d19039938e750c92bb89d05b2f05c10668ad > > We don't need a Change-Id. We need a Signed-off-by line as well as a > reference to the autobuilder failure that you are fixing. And also a > short explanation on how you're fixing the failure (backport an > upstream patch, etc.). > > >> diff --git a/package/tpm-tools/tpm-tools.mk b/package/tpm-tools/tpm-tools.mk >> index 20df489..9e4d66a 100644 >> --- a/package/tpm-tools/tpm-tools.mk >> +++ b/package/tpm-tools/tpm-tools.mk >> @@ -11,6 +11,7 @@ TPM_TOOLS_STRIP_COMPONENTS = 2 >> TPM_TOOLS_LICENSE = Common Public License Version 1.0 >> TPM_TOOLS_LICENSE_FILES = LICENSE >> TPM_TOOLS_DEPENDENCIES = trousers openssl >> +TPM_TOOLS_AUTORECONF = yes > > Please add a comment: > > # We're patching configure.in > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Henrique,
On Mon, Dec 28, 2015 at 4:28 PM, DATACOM - henrique.marks
<henrique.marks@datacom.ind.br> wrote:
> Isn't better to fix the code, instead of taking off -Werror ?
Well, -Werror tends to cause build failures on new versions of
compilers, and there are already several patches in Buildroot that
remove -Werror from various packages' build systems. Even upstream
removed -Werror, so I think it is the best thing we can do.
However this case does look like a bug so I will look into fixing this upstream.
diff --git a/package/tpm-tools/0002-configure.in-remove-Werror.patch b/package/tpm-tools/0002-configure.in-remove-Werror.patch new file mode 100644 index 0000000..4baae70 --- /dev/null +++ b/package/tpm-tools/0002-configure.in-remove-Werror.patch @@ -0,0 +1,26 @@ +From b060873f444d79f3f5aa388427cb1ede6665834a Mon Sep 17 00:00:00 2001 +From: Kent Yoder <key@linux.vnet.ibm.com> +Date: Mon, 5 Nov 2012 14:58:31 -0600 +Subject: [PATCH] configure.in: remove -Werror + +Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com> +--- + configure.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure.in b/configure.in +index da170d0..0f175be 100644 +--- a/configure.in ++++ b/configure.in +@@ -138,7 +138,7 @@ AC_TYPE_SIZE_T + AC_TYPE_SIGNAL + AC_TYPE_UID_T + +-CFLAGS="$CFLAGS -Wall -Werror -Wreturn-type -Wsign-compare" ++CFLAGS="$CFLAGS -Wall -Wreturn-type -Wsign-compare" + + AC_CONFIG_FILES(./Makefile \ + po/Makefile.in \ +-- +2.1.4 + diff --git a/package/tpm-tools/tpm-tools.mk b/package/tpm-tools/tpm-tools.mk index 20df489..9e4d66a 100644 --- a/package/tpm-tools/tpm-tools.mk +++ b/package/tpm-tools/tpm-tools.mk @@ -11,6 +11,7 @@ TPM_TOOLS_STRIP_COMPONENTS = 2 TPM_TOOLS_LICENSE = Common Public License Version 1.0 TPM_TOOLS_LICENSE_FILES = LICENSE TPM_TOOLS_DEPENDENCIES = trousers openssl +TPM_TOOLS_AUTORECONF = yes TPM_TOOLS_CONF_OPTS = --disable-pkcs11-support