diff mbox

[ovs-dev] ovn-northd.8: Correct syntax for OVN strings.

Message ID 1448300239-902-1-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Nov. 23, 2015, 5:37 p.m. UTC
Backslashes are necessary if you put OVN syntax inside a quoted string, but
it's not part of the syntax itself and might confuse readers.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 ovn/northd/ovn-northd.8.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Russell Bryant Nov. 23, 2015, 6:37 p.m. UTC | #1
On 11/23/2015 12:37 PM, Ben Pfaff wrote:
> Backslashes are necessary if you put OVN syntax inside a quoted string, but
> it's not part of the syntax itself and might confuse readers.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  ovn/northd/ovn-northd.8.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml
> index e7dec72..865c727 100644
> --- a/ovn/northd/ovn-northd.8.xml
> +++ b/ovn/northd/ovn-northd.8.xml
> @@ -340,7 +340,7 @@ ip4.dst = ip4.src;
>  ip4.src = <var>S</var>;
>  ip.ttl = 255;
>  icmp4.type = 0;
> -inport = \"\"; /* Allow sending out inport. */
> +inport = ""; /* Allow sending out inport. */
>  next;
>          </pre>
>  
> @@ -370,7 +370,7 @@ arp.sha = <var>E</var>;
>  arp.tpa = arp.spa;
>  arp.spa = <var>A</var>;
>  outport = <var>P</var>;
> -inport = \"\"; /* Allow sending out inport. */
> +inport = ""; /* Allow sending out inport. */
>  output;
>          </pre>
>        </li>
> 

Acked-by: Russell Bryant <russell@ovn.org>
Ben Pfaff Nov. 24, 2015, 4:24 a.m. UTC | #2
On Mon, Nov 23, 2015 at 01:37:17PM -0500, Russell Bryant wrote:
> On 11/23/2015 12:37 PM, Ben Pfaff wrote:
> > Backslashes are necessary if you put OVN syntax inside a quoted string, but
> > it's not part of the syntax itself and might confuse readers.
> > 
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> >  ovn/northd/ovn-northd.8.xml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml
> > index e7dec72..865c727 100644
> > --- a/ovn/northd/ovn-northd.8.xml
> > +++ b/ovn/northd/ovn-northd.8.xml
> > @@ -340,7 +340,7 @@ ip4.dst = ip4.src;
> >  ip4.src = <var>S</var>;
> >  ip.ttl = 255;
> >  icmp4.type = 0;
> > -inport = \"\"; /* Allow sending out inport. */
> > +inport = ""; /* Allow sending out inport. */
> >  next;
> >          </pre>
> >  
> > @@ -370,7 +370,7 @@ arp.sha = <var>E</var>;
> >  arp.tpa = arp.spa;
> >  arp.spa = <var>A</var>;
> >  outport = <var>P</var>;
> > -inport = \"\"; /* Allow sending out inport. */
> > +inport = ""; /* Allow sending out inport. */
> >  output;
> >          </pre>
> >        </li>
> > 
> 
> Acked-by: Russell Bryant <russell@ovn.org>

Thanks Russell, I applied this to master.
diff mbox

Patch

diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml
index e7dec72..865c727 100644
--- a/ovn/northd/ovn-northd.8.xml
+++ b/ovn/northd/ovn-northd.8.xml
@@ -340,7 +340,7 @@  ip4.dst = ip4.src;
 ip4.src = <var>S</var>;
 ip.ttl = 255;
 icmp4.type = 0;
-inport = \"\"; /* Allow sending out inport. */
+inport = ""; /* Allow sending out inport. */
 next;
         </pre>
 
@@ -370,7 +370,7 @@  arp.sha = <var>E</var>;
 arp.tpa = arp.spa;
 arp.spa = <var>A</var>;
 outport = <var>P</var>;
-inport = \"\"; /* Allow sending out inport. */
+inport = ""; /* Allow sending out inport. */
 output;
         </pre>
       </li>