diff mbox

[ovs-dev,PATCH/RFC] Remove manpages.mk from revision control system

Message ID 1443581525-19019-1-git-send-email-simon.horman@netronome.com
State Accepted
Headers show

Commit Message

Simon Horman Sept. 30, 2015, 2:52 a.m. UTC 
manpages.mk is automatically generated and thus does not seem to need
to be present in the revision control system. Also ignore the autogenerated
file by adding it to .gitignore.

I noticed this because I sometimes end up with a modified manpages.mk
when making other commits.

Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
 .gitignore  |   1 +
 manpages.mk | 319 ------------------------------------------------------------
 2 files changed, 1 insertion(+), 319 deletions(-)
 delete mode 100644 manpages.mk

Comments

Ben Pfaff Oct. 5, 2015, 7:45 p.m. UTC | #1 
On Wed, Sep 30, 2015 at 11:52:05AM +0900, Simon Horman wrote:
> manpages.mk is automatically generated and thus does not seem to need
> to be present in the revision control system. Also ignore the autogenerated
> file by adding it to .gitignore.
> 
> I noticed this because I sometimes end up with a modified manpages.mk
> when making other commits.
> 
> Signed-off-by: Simon Horman <simon.horman@netronome.com>

When I added this to version control originally, I think it was because
we didn't require GNU Make and the ability to remake a makefile is a
nonstandard feature.  These days, though, we do require GNU make, and so
we might as well remove it.

I applied this to master, thanks!
Ben Pfaff Oct. 5, 2015, 7:49 p.m. UTC | #2 
On Mon, Oct 05, 2015 at 12:45:26PM -0700, Ben Pfaff wrote:
> On Wed, Sep 30, 2015 at 11:52:05AM +0900, Simon Horman wrote:
> > manpages.mk is automatically generated and thus does not seem to need
> > to be present in the revision control system. Also ignore the autogenerated
> > file by adding it to .gitignore.
> > 
> > I noticed this because I sometimes end up with a modified manpages.mk
> > when making other commits.
> > 
> > Signed-off-by: Simon Horman <simon.horman@netronome.com>
> 
> When I added this to version control originally, I think it was because
> we didn't require GNU Make and the ability to remake a makefile is a
> nonstandard feature.  These days, though, we do require GNU make, and so
> we might as well remove it.
> 
> I applied this to master, thanks!

Unfortunately I had to un-apply it because it caused a build failure:
https://ci.appveyor.com/project/blp/ovs/build/1.0.811
Simon Horman Oct. 6, 2015, 11:58 a.m. UTC | #3 
On Mon, Oct 05, 2015 at 12:49:36PM -0700, Ben Pfaff wrote:
> On Mon, Oct 05, 2015 at 12:45:26PM -0700, Ben Pfaff wrote:
> > On Wed, Sep 30, 2015 at 11:52:05AM +0900, Simon Horman wrote:
> > > manpages.mk is automatically generated and thus does not seem to need
> > > to be present in the revision control system. Also ignore the autogenerated
> > > file by adding it to .gitignore.
> > > 
> > > I noticed this because I sometimes end up with a modified manpages.mk
> > > when making other commits.
> > > 
> > > Signed-off-by: Simon Horman <simon.horman@netronome.com>
> > 
> > When I added this to version control originally, I think it was because
> > we didn't require GNU Make and the ability to remake a makefile is a
> > nonstandard feature.  These days, though, we do require GNU make, and so
> > we might as well remove it.
> > 
> > I applied this to master, thanks!
> 
> Unfortunately I had to un-apply it because it caused a build failure:
> https://ci.appveyor.com/project/blp/ovs/build/1.0.811

Sorry about that. I should have tested it more thoroughly.
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index c96ceed0556e..ce2cb05279fb 100644
--- a/.gitignore
+++ b/.gitignore
@@ -67,3 +67,4 @@  odp-netlink.h
 OvsDpInterface.h
 /.vagrant/
 testsuite.tmp.orig
+manpages.mk
diff --git a/manpages.mk b/manpages.mk
deleted file mode 100644
index 614124294994..000000000000
--- a/manpages.mk
+++ /dev/null
@@ -1,319 +0,0 @@ 
-# Generated automatically -- do not modify!    -*- buffer-read-only: t -*-
-
-ovn/utilities/ovn-sbctl.8: \
-	ovn/utilities/ovn-sbctl.8.in \
-	lib/db-ctl-base.man \
-	lib/table.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man
-ovn/utilities/ovn-sbctl.8.in:
-lib/db-ctl-base.man:
-lib/table.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-
-ovsdb/ovsdb-client.1: \
-	ovsdb/ovsdb-client.1.in \
-	lib/common-syn.man \
-	lib/common.man \
-	lib/daemon-syn.man \
-	lib/daemon.man \
-	lib/ssl-bootstrap-syn.man \
-	lib/ssl-bootstrap.man \
-	lib/ssl-syn.man \
-	lib/ssl.man \
-	lib/table.man \
-	lib/vlog-syn.man \
-	lib/vlog.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man
-ovsdb/ovsdb-client.1.in:
-lib/common-syn.man:
-lib/common.man:
-lib/daemon-syn.man:
-lib/daemon.man:
-lib/ssl-bootstrap-syn.man:
-lib/ssl-bootstrap.man:
-lib/ssl-syn.man:
-lib/ssl.man:
-lib/table.man:
-lib/vlog-syn.man:
-lib/vlog.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-
-ovsdb/ovsdb-server.1: \
-	ovsdb/ovsdb-server.1.in \
-	lib/common-syn.man \
-	lib/common.man \
-	lib/coverage-unixctl.man \
-	lib/daemon-syn.man \
-	lib/daemon.man \
-	lib/memory-unixctl.man \
-	lib/service-syn.man \
-	lib/service.man \
-	lib/ssl-bootstrap-syn.man \
-	lib/ssl-bootstrap.man \
-	lib/ssl-peer-ca-cert-syn.man \
-	lib/ssl-peer-ca-cert.man \
-	lib/ssl-syn.man \
-	lib/ssl.man \
-	lib/unixctl-syn.man \
-	lib/unixctl.man \
-	lib/vlog-syn.man \
-	lib/vlog-unixctl.man \
-	lib/vlog.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man
-ovsdb/ovsdb-server.1.in:
-lib/common-syn.man:
-lib/common.man:
-lib/coverage-unixctl.man:
-lib/daemon-syn.man:
-lib/daemon.man:
-lib/memory-unixctl.man:
-lib/service-syn.man:
-lib/service.man:
-lib/ssl-bootstrap-syn.man:
-lib/ssl-bootstrap.man:
-lib/ssl-peer-ca-cert-syn.man:
-lib/ssl-peer-ca-cert.man:
-lib/ssl-syn.man:
-lib/ssl.man:
-lib/unixctl-syn.man:
-lib/unixctl.man:
-lib/vlog-syn.man:
-lib/vlog-unixctl.man:
-lib/vlog.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-
-ovsdb/ovsdb-tool.1: \
-	ovsdb/ovsdb-tool.1.in \
-	lib/common-syn.man \
-	lib/common.man \
-	lib/vlog-syn.man \
-	lib/vlog.man
-ovsdb/ovsdb-tool.1.in:
-lib/common-syn.man:
-lib/common.man:
-lib/vlog-syn.man:
-lib/vlog.man:
-
-utilities/bugtool/ovs-bugtool.8: \
-	utilities/bugtool/ovs-bugtool.8.in
-utilities/bugtool/ovs-bugtool.8.in:
-
-utilities/ovs-appctl.8: \
-	utilities/ovs-appctl.8.in \
-	lib/common.man
-utilities/ovs-appctl.8.in:
-lib/common.man:
-
-utilities/ovs-benchmark.1: \
-	utilities/ovs-benchmark.1.in \
-	lib/ovs.tmac
-utilities/ovs-benchmark.1.in:
-lib/ovs.tmac:
-
-utilities/ovs-dpctl-top.8: \
-	utilities/ovs-dpctl-top.8.in
-utilities/ovs-dpctl-top.8.in:
-
-utilities/ovs-dpctl.8: \
-	utilities/ovs-dpctl.8.in \
-	lib/common.man \
-	lib/dpctl.man \
-	lib/vlog.man
-utilities/ovs-dpctl.8.in:
-lib/common.man:
-lib/dpctl.man:
-lib/vlog.man:
-
-utilities/ovs-l3ping.8: \
-	utilities/ovs-l3ping.8.in \
-	lib/common-syn.man \
-	lib/common.man
-utilities/ovs-l3ping.8.in:
-lib/common-syn.man:
-lib/common.man:
-
-utilities/ovs-ofctl.8: \
-	utilities/ovs-ofctl.8.in \
-	lib/common.man \
-	lib/daemon.man \
-	lib/ofp-version.man \
-	lib/ssl.man \
-	lib/unixctl.man \
-	lib/vconn-active.man \
-	lib/vlog.man
-utilities/ovs-ofctl.8.in:
-lib/common.man:
-lib/daemon.man:
-lib/ofp-version.man:
-lib/ssl.man:
-lib/unixctl.man:
-lib/vconn-active.man:
-lib/vlog.man:
-
-utilities/ovs-pcap.1: \
-	utilities/ovs-pcap.1.in \
-	lib/common-syn.man \
-	lib/common.man
-utilities/ovs-pcap.1.in:
-lib/common-syn.man:
-lib/common.man:
-
-utilities/ovs-pki.8: \
-	utilities/ovs-pki.8.in
-utilities/ovs-pki.8.in:
-
-utilities/ovs-tcpundump.1: \
-	utilities/ovs-tcpundump.1.in \
-	lib/common-syn.man \
-	lib/common.man
-utilities/ovs-tcpundump.1.in:
-lib/common-syn.man:
-lib/common.man:
-
-utilities/ovs-test.8: \
-	utilities/ovs-test.8.in \
-	lib/common-syn.man \
-	lib/common.man \
-	utilities/ovs-vlan-bugs.man
-utilities/ovs-test.8.in:
-lib/common-syn.man:
-lib/common.man:
-utilities/ovs-vlan-bugs.man:
-
-utilities/ovs-testcontroller.8: \
-	utilities/ovs-testcontroller.8.in \
-	lib/common.man \
-	lib/daemon.man \
-	lib/ofp-version.man \
-	lib/ssl-peer-ca-cert.man \
-	lib/ssl.man \
-	lib/unixctl.man \
-	lib/vconn-active.man \
-	lib/vconn-passive.man \
-	lib/vlog.man
-utilities/ovs-testcontroller.8.in:
-lib/common.man:
-lib/daemon.man:
-lib/ofp-version.man:
-lib/ssl-peer-ca-cert.man:
-lib/ssl.man:
-lib/unixctl.man:
-lib/vconn-active.man:
-lib/vconn-passive.man:
-lib/vlog.man:
-
-utilities/ovs-vlan-bug-workaround.8: \
-	utilities/ovs-vlan-bug-workaround.8.in \
-	lib/common.man \
-	utilities/ovs-vlan-bugs.man
-utilities/ovs-vlan-bug-workaround.8.in:
-lib/common.man:
-utilities/ovs-vlan-bugs.man:
-
-utilities/ovs-vlan-test.8: \
-	utilities/ovs-vlan-test.8.in \
-	lib/common-syn.man \
-	lib/common.man \
-	utilities/ovs-vlan-bugs.man
-utilities/ovs-vlan-test.8.in:
-lib/common-syn.man:
-lib/common.man:
-utilities/ovs-vlan-bugs.man:
-
-utilities/ovs-vsctl.8: \
-	utilities/ovs-vsctl.8.in \
-	lib/common.man \
-	lib/db-ctl-base.man \
-	lib/ssl-bootstrap.man \
-	lib/ssl-peer-ca-cert.man \
-	lib/ssl.man \
-	lib/table.man \
-	lib/vconn-active.man \
-	lib/vconn-passive.man \
-	lib/vlog.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man \
-	ovsdb/remote-passive.man
-utilities/ovs-vsctl.8.in:
-lib/common.man:
-lib/db-ctl-base.man:
-lib/ssl-bootstrap.man:
-lib/ssl-peer-ca-cert.man:
-lib/ssl.man:
-lib/table.man:
-lib/vconn-active.man:
-lib/vconn-passive.man:
-lib/vlog.man:
-ovsdb/remote-active.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-ovsdb/remote-passive.man:
-
-vswitchd/ovs-vswitchd.8: \
-	vswitchd/ovs-vswitchd.8.in \
-	lib/common.man \
-	lib/coverage-unixctl.man \
-	lib/daemon.man \
-	lib/dpctl.man \
-	lib/memory-unixctl.man \
-	lib/service.man \
-	lib/ssl-bootstrap.man \
-	lib/ssl.man \
-	lib/unixctl.man \
-	lib/vlog-unixctl.man \
-	lib/vlog.man \
-	ofproto/ofproto-dpif-unixctl.man \
-	ofproto/ofproto-tnl-unixctl.man \
-	ofproto/ofproto-unixctl.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man
-vswitchd/ovs-vswitchd.8.in:
-lib/common.man:
-lib/coverage-unixctl.man:
-lib/daemon.man:
-lib/dpctl.man:
-lib/memory-unixctl.man:
-lib/service.man:
-lib/ssl-bootstrap.man:
-lib/ssl.man:
-lib/unixctl.man:
-lib/vlog-unixctl.man:
-lib/vlog.man:
-ofproto/ofproto-dpif-unixctl.man:
-ofproto/ofproto-tnl-unixctl.man:
-ofproto/ofproto-unixctl.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-
-vtep/vtep-ctl.8: \
-	vtep/vtep-ctl.8.in \
-	lib/common.man \
-	lib/db-ctl-base.man \
-	lib/ssl-bootstrap.man \
-	lib/ssl-peer-ca-cert.man \
-	lib/ssl.man \
-	lib/table.man \
-	lib/vlog.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-active.man \
-	ovsdb/remote-passive.man \
-	ovsdb/remote-passive.man
-vtep/vtep-ctl.8.in:
-lib/common.man:
-lib/db-ctl-base.man:
-lib/ssl-bootstrap.man:
-lib/ssl-peer-ca-cert.man:
-lib/ssl.man:
-lib/table.man:
-lib/vlog.man:
-ovsdb/remote-active.man:
-ovsdb/remote-active.man:
-ovsdb/remote-passive.man:
-ovsdb/remote-passive.man: