Message ID | CAHbON5r4enzfAug+jhCDx4=Ku-yD-oRSkfPb98MO+k=7kXxKsg@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On Wed, Sep 16, 2015 at 09:15:23AM -0700, Gurucharan Shetty wrote: > So installing python 2.7 got rid of those errors and you ended up with > the above. I only tested on the commit that changed python > requirements and that worked and I happily made an assumption that no > other commit breaks later. Sorry about that. The above error needs the > following patch. > > > diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in > index dad3e04..0ec65be 100644 > --- a/rhel/openvswitch.spec.in > +++ b/rhel/openvswitch.spec.in > @@ -22,7 +22,7 @@ License: ASL 2.0 > Release: 1 > Source: openvswitch-%{version}.tar.gz > Buildroot: /tmp/openvswitch-rpm > -Requires: logrotate, python > +Requires: logrotate, python >= 2.7 > BuildRequires: openssl-devel > > %bcond_without check > @@ -180,7 +180,6 @@ exit 0 > /var/lib/openvswitch > /var/log/openvswitch > %exclude /usr/bin/ovn-* > -%exclude /usr/share/man/man1/ovs-sim.1.gz > %exclude /usr/share/man/man5/ovn-* > %exclude /usr/share/man/man7/ovn-* > %exclude /usr/share/man/man8/ovn-* Is this something that should be reviewed as a bug fix for OVS? It sounds like it fixed the initial problem that Tashi/Dotslash found.
I sent a couple of separate patches, which got tested and I merged them. On Fri, Sep 18, 2015 at 2:31 PM, Ben Pfaff <blp@nicira.com> wrote: > On Wed, Sep 16, 2015 at 09:15:23AM -0700, Gurucharan Shetty wrote: >> So installing python 2.7 got rid of those errors and you ended up with >> the above. I only tested on the commit that changed python >> requirements and that worked and I happily made an assumption that no >> other commit breaks later. Sorry about that. The above error needs the >> following patch. >> >> >> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in >> index dad3e04..0ec65be 100644 >> --- a/rhel/openvswitch.spec.in >> +++ b/rhel/openvswitch.spec.in >> @@ -22,7 +22,7 @@ License: ASL 2.0 >> Release: 1 >> Source: openvswitch-%{version}.tar.gz >> Buildroot: /tmp/openvswitch-rpm >> -Requires: logrotate, python >> +Requires: logrotate, python >= 2.7 >> BuildRequires: openssl-devel >> >> %bcond_without check >> @@ -180,7 +180,6 @@ exit 0 >> /var/lib/openvswitch >> /var/log/openvswitch >> %exclude /usr/bin/ovn-* >> -%exclude /usr/share/man/man1/ovs-sim.1.gz >> %exclude /usr/share/man/man5/ovn-* >> %exclude /usr/share/man/man7/ovn-* >> %exclude /usr/share/man/man8/ovn-* > > Is this something that should be reviewed as a bug fix for OVS? It > sounds like it fixed the initial problem that Tashi/Dotslash found.
Thanks, I see that now. On Fri, Sep 18, 2015 at 2:41 PM, Gurucharan Shetty <shettyg@nicira.com> wrote: > I sent a couple of separate patches, which got tested and I merged them. > > On Fri, Sep 18, 2015 at 2:31 PM, Ben Pfaff <blp@nicira.com> wrote: >> On Wed, Sep 16, 2015 at 09:15:23AM -0700, Gurucharan Shetty wrote: >>> So installing python 2.7 got rid of those errors and you ended up with >>> the above. I only tested on the commit that changed python >>> requirements and that worked and I happily made an assumption that no >>> other commit breaks later. Sorry about that. The above error needs the >>> following patch. >>> >>> >>> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in >>> index dad3e04..0ec65be 100644 >>> --- a/rhel/openvswitch.spec.in >>> +++ b/rhel/openvswitch.spec.in >>> @@ -22,7 +22,7 @@ License: ASL 2.0 >>> Release: 1 >>> Source: openvswitch-%{version}.tar.gz >>> Buildroot: /tmp/openvswitch-rpm >>> -Requires: logrotate, python >>> +Requires: logrotate, python >= 2.7 >>> BuildRequires: openssl-devel >>> >>> %bcond_without check >>> @@ -180,7 +180,6 @@ exit 0 >>> /var/lib/openvswitch >>> /var/log/openvswitch >>> %exclude /usr/bin/ovn-* >>> -%exclude /usr/share/man/man1/ovs-sim.1.gz >>> %exclude /usr/share/man/man5/ovn-* >>> %exclude /usr/share/man/man7/ovn-* >>> %exclude /usr/share/man/man8/ovn-* >> >> Is this something that should be reviewed as a bug fix for OVS? It >> sounds like it fixed the initial problem that Tashi/Dotslash found.
diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index dad3e04..0ec65be 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -22,7 +22,7 @@ License: ASL 2.0 Release: 1 Source: openvswitch-%{version}.tar.gz Buildroot: /tmp/openvswitch-rpm -Requires: logrotate, python +Requires: logrotate, python >= 2.7 BuildRequires: openssl-devel %bcond_without check @@ -180,7 +180,6 @@ exit 0 /var/lib/openvswitch /var/log/openvswitch %exclude /usr/bin/ovn-* -%exclude /usr/share/man/man1/ovs-sim.1.gz %exclude /usr/share/man/man5/ovn-* %exclude /usr/share/man/man7/ovn-* %exclude /usr/share/man/man8/ovn-*