Message ID | 6116d63a0dc858f36415316f8bbe565c222049a8.1435791392.git.marcel.ziswiler@toradex.com |
---|---|
State | Superseded |
Headers | show |
On Thursday, July 02, 2015 at 01:04:51 AM, Marcel Ziswiler wrote: > From: Max Krummenacher <max.krummenacher@toradex.com> > > This fixes the following warning (and the runtime error reporting): > ../common/image-fdt.c:491:4: warning: 'fdt_ret' may be used > uninitialized in this function [-Wmaybe-uninitialized] > > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 1 July 2015 at 23:52, Marek Vasut <marex@denx.de> wrote: > On Thursday, July 02, 2015 at 01:04:51 AM, Marcel Ziswiler wrote: >> From: Max Krummenacher <max.krummenacher@toradex.com> >> >> This fixes the following warning (and the runtime error reporting): >> ../common/image-fdt.c:491:4: warning: 'fdt_ret' may be used >> uninitialized in this function [-Wmaybe-uninitialized] >> >> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> >> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Acked-by: Marek Vasut <marex@denx.de> Acked-by: Simon Glass <sjg@chromium.org>
diff --git a/common/image-fdt.c b/common/image-fdt.c index 80e3e63..d9fce17 100644 --- a/common/image-fdt.c +++ b/common/image-fdt.c @@ -492,7 +492,8 @@ int image_setup_libfdt(bootm_headers_t *images, void *blob, } } if (IMAGE_OF_SYSTEM_SETUP) { - if (ft_system_setup(blob, gd->bd)) { + fdt_ret = ft_system_setup(blob, gd->bd); + if (fdt_ret) { printf("ERROR: system-specific fdt fixup failed: %s\n", fdt_strerror(fdt_ret)); goto err;