diff mbox

[OpenWrt-Devel] perf: replace libelf1 select by a depend

Message ID 01e401d09811$e4b77a40$ae266ec0$@codeaurora.org
State Rejected
Headers show

Commit Message

Mathieu Olivari May 27, 2015, 12:13 a.m. UTC 
It was not merged; it stayed pending without resolution since then, so I figured I’d find an alternative.

Thanks,

Mathieu

 

From: Luiz Angelo Daros de Luca [mailto:luizluca@gmail.com] 
Sent: Tuesday, May 26, 2015 3:08 PM
To: Mathieu Olivari; nbd@openwrt.org; blogic@openwrt.org
Cc: openwrt-devel@lists.openwrt.org
Subject: Re: [OpenWrt-Devel] [PATCH] perf: replace libelf1 select by a depend

 

Hi Mathieu,

So the elfutils import from packages.git was rejected?

 

Regards,

 

Luiz Angelo,

 

Em ter, 26 de mai de 2015 às 18:18, Mathieu Olivari <mathieu@codeaurora.org <mailto:mathieu@codeaurora.org> > escreveu:

perf has libelf1 marked as a select, but this package is actually
located in packages.git. As such, the dependency is ignored unless
libelf1 package has been manually installed previously.

To avoid any missing dependency, we'll mark it as a regular depend.
This will make sure the dependency check doesn't silently fail.

Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org <mailto:mathieu@codeaurora.org> >
---
 package/devel/perf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.1.4

Comments

Felix Fietkau May 27, 2015, 3:33 p.m. UTC | #1 
On 2015-05-27 02:13, Mathieu Olivari wrote:
> It was not merged; it stayed pending without resolution since then, so I
> figured I’d find an alternative.
Replacing the select by a depend makes the whole process completely
counterintuitive, so NACK from me on that.

Any package we add to trunk needs to have a maintainer. Is moving the
relevant packages to trunk acked by the current package maintainers?

- Felix
Mathieu Olivari May 27, 2015, 4:18 p.m. UTC | #2 
Perf is in trunk today, but it has no maintainer listed. Somebody probably needs to volunteer.
As of the packages I was planning to import, I'm adding the other maintainers to the To: list:
- argp-standalone: Ted Hess <thess@kitschensync.net>
- bzip2: Steven Barth <cyrus@openwrt.org>
- Luiz Angelo Daros de Luca <luizluca@gmail.com> 

Initial proposal is here: https://patchwork.ozlabs.org/patch/473676/

Thanks,
Mathieu
-----Original Message-----
From: Felix Fietkau [mailto:nbd@openwrt.org] 
Sent: Wednesday, May 27, 2015 8:33 AM
To: Mathieu Olivari; 'Luiz Angelo Daros de Luca'; blogic@openwrt.org
Cc: openwrt-devel@lists.openwrt.org
Subject: Re: [OpenWrt-Devel] [PATCH] perf: replace libelf1 select by a depend

On 2015-05-27 02:13, Mathieu Olivari wrote:
> It was not merged; it stayed pending without resolution since then, so 
> I figured I’d find an alternative.
Replacing the select by a depend makes the whole process completely counterintuitive, so NACK from me on that.

Any package we add to trunk needs to have a maintainer. Is moving the relevant packages to trunk acked by the current package maintainers?

- Felix
diff mbox

Patch

diff --git a/package/devel/perf/Makefile b/package/devel/perf/Makefile
index b77e29a..e31a693 100644
--- a/package/devel/perf/Makefile
+++ b/package/devel/perf/Makefile
@@ -19,7 +19,7 @@  include $(INCLUDE_DIR)/package.mk <http://package.mk> 
 define Package/perf
   SECTION:=devel
   CATEGORY:=Development
-  DEPENDS:= @USE_GLIBC +libelf1 +libdw +libpthread +librt +binutils
+  DEPENDS:= libelf1 +libdw +libpthread +librt +binutils
   TITLE:=Linux performance monitoring tool
   VERSION:=$(LINUX_VERSION)-$(PKG_RELEASE)
   URL:=http://www.kernel.org