Message ID | 1428618310-10229-1-git-send-email-qipeng.zha@intel.com |
---|---|
State | New |
Headers | show |
On Fri, Apr 10, 2015 at 06:25:10AM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@intel.com> > > The signed error will be wrongly used as valid gpio offset > > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Alan Cox <alan@linux.intel.com> > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 10, 2015 at 12:25 AM, qipeng.zha <qipeng.zha@intel.com> wrote: > From: "qipeng.zha" <qipeng.zha@intel.com> > > The signed error will be wrongly used as valid gpio offset > > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Alan Cox <alan@linux.intel.com> > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> Patch applied for fixes with Mika's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index df990f2..9674066 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -550,7 +550,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address, length = min(agpio->pin_table_length, (u16)(pin_index + bits)); for (i = pin_index; i < length; ++i) { - unsigned pin = agpio->pin_table[i]; + int pin = agpio->pin_table[i]; struct acpi_gpio_connection *conn; struct gpio_desc *desc; bool found;