diff mbox

[OpenWrt-Devel,3/6] ipq806x: enable usb support

Message ID 1428031811-14892-4-git-send-email-mathieu@codeaurora.org
State Accepted
Headers show

Commit Message

Mathieu Olivari April 3, 2015, 3:30 a.m. UTC
This change doesn't make USB functional but it does make it selectable
from a configuration perspective.

Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
---
 target/linux/ipq806x/config-3.18 | 1 +
 target/linux/ipq806x/config-4.0  | 1 +
 2 files changed, 2 insertions(+)

Comments

Felix Fietkau April 3, 2015, 6:47 p.m. UTC | #1
On 2015-04-03 05:30, Mathieu Olivari wrote:
> This change doesn't make USB functional but it does make it selectable
> from a configuration perspective.
> 
> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
I think this should be added to the generic config instead.

Thanks,

- Felix
John Crispin April 3, 2015, 6:53 p.m. UTC | #2
On 03/04/2015 20:47, Felix Fietkau wrote:
> On 2015-04-03 05:30, Mathieu Olivari wrote:
>> This change doesn't make USB functional but it does make it
>> selectable from a configuration perspective.
>> 
>> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
> I think this should be added to the generic config instead.
> 
> Thanks,
> 
> - Felix _______________________________________________ 
> openwrt-devel mailing list openwrt-devel@lists.openwrt.org 
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 

that would make all targets have the usb feature [1]

the actual problem with this series is 4/6 because it adds target
specific modules to the linux package and not the target folder. i
fixed this already though in my local tree

[1] include/kernel.mk:
    ifneq ($(CONFIG_USB)$(CONFIG_USB_SUPPORT),)
      ifneq ($(CONFIG_USB_ARCH_HAS_HCD)$(CONFIG_USB_EHCI_HCD),)
        FEATURES += usb
      endif
    endif
diff mbox

Patch

diff --git a/target/linux/ipq806x/config-3.18 b/target/linux/ipq806x/config-3.18
index b2f5571..e0535d3 100644
--- a/target/linux/ipq806x/config-3.18
+++ b/target/linux/ipq806x/config-3.18
@@ -351,6 +351,7 @@  CONFIG_UEVENT_HELPER_PATH=""
 CONFIG_UID16=y
 CONFIG_UNCOMPRESS_INCLUDE="debug/uncompress.h"
 CONFIG_UNINLINE_SPIN_UNLOCK=y
+CONFIG_USB_SUPPORT=y
 CONFIG_USE_OF=y
 CONFIG_VECTORS_BASE=0xffff0000
 # CONFIG_VFIO is not set
diff --git a/target/linux/ipq806x/config-4.0 b/target/linux/ipq806x/config-4.0
index 8504c96..4d56106 100644
--- a/target/linux/ipq806x/config-4.0
+++ b/target/linux/ipq806x/config-4.0
@@ -365,6 +365,7 @@  CONFIG_UEVENT_HELPER_PATH=""
 CONFIG_UID16=y
 CONFIG_UNCOMPRESS_INCLUDE="debug/uncompress.h"
 CONFIG_UNINLINE_SPIN_UNLOCK=y
+CONFIG_USB_SUPPORT=y
 CONFIG_USE_OF=y
 CONFIG_VECTORS_BASE=0xffff0000
 CONFIG_VFP=y