{"id":901998,"url":"http://patchwork.ozlabs.org/api/patches/901998/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20180420155314.8920-4-stefan@agner.ch/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180420155314.8920-4-stefan@agner.ch>","list_archive_url":null,"date":"2018-04-20T15:53:08","name":"[U-Boot,v1,3/9] mtd: nand: mxs_nand: separate board/controller init","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"0c3da74c34b52d60e3a9ac839f7fa33ff613fe01","submitter":{"id":4137,"url":"http://patchwork.ozlabs.org/api/people/4137/?format=json","name":"Stefan Agner","email":"stefan@agner.ch"},"delegate":{"id":1693,"url":"http://patchwork.ozlabs.org/api/users/1693/?format=json","username":"sbabic","first_name":"Stefano","last_name":"Babic","email":"sbabic@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20180420155314.8920-4-stefan@agner.ch/mbox/","series":[{"id":40110,"url":"http://patchwork.ozlabs.org/api/series/40110/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=40110","date":"2018-04-20T15:53:05","name":"mtd: nand: mxs_nand: add device tree support","version":1,"mbox":"http://patchwork.ozlabs.org/series/40110/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/901998/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/901998/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=agner.ch","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=agner.ch header.i=@agner.ch header.b=\"L2mevMMC\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 40SL76352hz9s3F\n\tfor ;\n\tSat, 21 Apr 2018 01:56:02 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid ABD10C21DD4; Fri, 20 Apr 2018 15:55:27 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8E0D4C21DDC;\n\tFri, 20 Apr 2018 15:54:29 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9D37BC21C6A; Fri, 20 Apr 2018 15:54:24 +0000 (UTC)","from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109])\n\tby lists.denx.de (Postfix) with ESMTPS id 4C534C21C27\n\tfor ; Fri, 20 Apr 2018 15:54:24 +0000 (UTC)","from trochilidae.toradex.int (unknown [IPv6:2001:1620:c6e:10::3])\n\tby mail.kmu-office.ch (Postfix) with ESMTPSA id B6B1F5C173F;\n\tFri, 20 Apr 2018 17:54:23 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED,\n\tSPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim;\n\tt=1524239664;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:content-type:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+QpHuMduMBqu+CBDr94H6bRntKy1UzcVklHpg2AdrOg=;\n\tb=L2mevMMC2NsBN0UyrD3+llBIS6we9c9j8eBaPfH5oqnY7FP9oUca0OdT2we2lnkumVeB+d\n\tvestV0fMKwWLJjRVdLm6lsK0uKvSBiGS9Cg7uE0LzsXNi9W9R3Mv9tvrv9NibOfkS8bQDe\n\tvJssY2k19S4frk8KemAKL5zAgmPlBVA=","From":"Stefan Agner ","To":"u-boot@lists.denx.de, Stefano Babic , oss@buserror.net","Date":"Fri, 20 Apr 2018 17:53:08 +0200","Message-Id":"<20180420155314.8920-4-stefan@agner.ch>","X-Mailer":"git-send-email 2.17.0","In-Reply-To":"<20180420155314.8920-1-stefan@agner.ch>","References":"<20180420155314.8920-1-stefan@agner.ch>","X-Spamd-Result":"default: False [-2.10 / 15.00]; RCVD_TLS_ALL(0.00)[];\n\tASN(0.00)[asn:13030, ipnet:2001:1620::/32, country:CH];\n\tRCVD_COUNT_ZERO(0.00)[0]; FROM_HAS_DN(0.00)[];\n\tMID_CONTAINS_FROM(1.00)[]; TO_DN_SOME(0.00)[];\n\tMIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%];\n\tARC_NA(0.00)[]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]","Cc":"marex@denx.de, Stefan Agner ,\n\tMarcel Ziswiler ,\n\tMax Krummenacher , han.xu@nxp.com","Subject":"[U-Boot] [PATCH v1 3/9] mtd: nand: mxs_nand: separate\n\tboard/controller init","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"From: Stefan Agner \n\nIn preparation for device tree support separate board init\nfrom controller init similar to other raw NAND drivers.\n\nSigned-off-by: Stefan Agner \n---\n\n drivers/mtd/nand/mxs_nand.c | 33 ++++++++++++++++++++-------------\n 1 file changed, 20 insertions(+), 13 deletions(-)","diff":"diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c\nindex 3f97da5e8f..b5fd0fdd62 100644\n--- a/drivers/mtd/nand/mxs_nand.c\n+++ b/drivers/mtd/nand/mxs_nand.c\n@@ -1193,22 +1193,12 @@ err1:\n \treturn ret;\n }\n \n-void board_nand_init(void)\n+int mxs_nand_init(struct mxs_nand_info *nand_info)\n {\n \tstruct mtd_info *mtd;\n-\tstruct mxs_nand_info *nand_info;\n \tstruct nand_chip *nand;\n \tint err;\n \n-\tnand_info = malloc(sizeof(struct mxs_nand_info));\n-\tif (!nand_info) {\n-\t\tprintf(\"MXS NAND: Failed to allocate private data\\n\");\n-\t\t\treturn;\n-\t}\n-\tmemset(nand_info, 0, sizeof(struct mxs_nand_info));\n-\n-\tnand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;\n-\tnand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;\n \tnand = &nand_info->chip;\n \tmtd = nand_to_mtd(nand);\n \terr = mxs_nand_alloc_buffers(nand_info);\n@@ -1265,12 +1255,29 @@ void board_nand_init(void)\n \tif (err)\n \t\tgoto err2;\n \n-\treturn;\n+\treturn 0;\n \n err2:\n \tfree(nand_info->data_buf);\n \tfree(nand_info->cmd_buf);\n err1:\n \tfree(nand_info);\n-\treturn;\n+\treturn err;\n+}\n+\n+void board_nand_init(void)\n+{\n+\tstruct mxs_nand_info *nand_info;\n+\n+\tnand_info = malloc(sizeof(struct mxs_nand_info));\n+\tif (!nand_info) {\n+\t\tprintf(\"MXS NAND: Failed to allocate private data\\n\");\n+\t\t\treturn;\n+\t}\n+\tmemset(nand_info, 0, sizeof(struct mxs_nand_info));\n+\n+\tnand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;\n+\tnand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;\n+\n+\tmxs_nand_init(nand_info);\n }\n","prefixes":["U-Boot","v1","3/9"]}