{"id":856686,"url":"http://patchwork.ozlabs.org/api/patches/856686/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-13-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180108024558.17983-13-f4bug@amsat.org>","list_archive_url":null,"date":"2018-01-08T02:45:41","name":"[12/29] piix4: rename some variables in realize function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7fa2885d3e3e04b927e2227dc1503891a36b0f53","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-13-f4bug@amsat.org/mbox/","series":[{"id":21847,"url":"http://patchwork.ozlabs.org/api/series/21847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=21847","date":"2018-01-08T02:45:30","name":"remove i386/pc dependency: generic SuperIO, PIIX cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/21847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/856686/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/856686/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qCvHRpdf\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFKry4ZHfz9s71\n\tfor ;\n\tMon, 8 Jan 2018 14:05:22 +1100 (AEDT)","from localhost ([::1]:59575 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eYNkW-0005jv-Ld\n\tfor incoming@patchwork.ozlabs.org; Sun, 07 Jan 2018 22:05:20 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:51421)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSd-0006yC-Al\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:52 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSc-0002XM-Jr\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:51 -0500","from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:40334)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eYNSc-0002XF-FQ\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:50 -0500","by mail-qk0-x243.google.com with SMTP id d18so2145448qke.7\n\tfor ; Sun, 07 Jan 2018 18:46:50 -0800 (PST)","from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id\n\td10sm7156245qkg.16.2018.01.07.18.46.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 07 Jan 2018 18:46:49 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uydIT8gqvnn8TqxGE/MpxbAQQJWpZ4BDA+4Odyh42bY=;\n\tb=qCvHRpdf5D7NnT/pqU6+E3J0TZFAvBb6jYGn7lj/batiMuXQtoog9wj9h04hSL130o\n\td9l/m1hMKhPN1yoOmeZxo993D39icVF+punM63KpGiWVJQIZQ1E702kZd7bAtiZ2DUzw\n\t6DqpagouMv/Q8fGN5329LkxxYpeqr13wyLwlsbQdwrpebxErHe5qSLSJxHxk/fd2XFiT\n\t3U/TrqH2CC+g0uhRCPGEAIXLJIEXZRUzhZPB/BCuwsH0HMYlzC3Pmyov5zwmEBnI5ZWR\n\t1WKUSqv0IiaU1wjH98FTgTXNzyBU92mLhrrrzPRcZ+xVrGG7SgG0bdL7IUFLQ2hlRxMt\n\tUVHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=uydIT8gqvnn8TqxGE/MpxbAQQJWpZ4BDA+4Odyh42bY=;\n\tb=QATMSkzzPy8kFZ7Zt0JqMoGK5clfMyA1wm0gp4j1PAx2buX0LNgqlVEShDjr8/cNkL\n\tUDWkVOK/x6TgyCdih0koqbtN3mLjznRyPAMZvCgHM+yhL4qoxar03us7UkaZgqloPikL\n\tAnC85yfbxdIPQ592CWo9euHd+19uFSZTq2JOvEs1MWfEzBe/C4YiJT0QMcvoVAxNafF8\n\tY4wy5BSImkTIrgbzATpJ+Av2tiHRjK3jlb0fXv4uFlw8vz0VSqlWIhZ8kyChnhAg4arO\n\t00Y7ZcNhrskbMsWJxvbdZRfPMTowcV023xrNMgrsq3yeE92G9+iJJMfVZ8JwJf1vq8DL\n\tSxyw==","X-Gm-Message-State":"AKwxytf8Pki9RC6e9V9D1a4dM20HQiXJ5hkML+v3Qkxn2WsmdWRTjBFA\n\tOblPsRYPrmZgXKGxcTNys9I=","X-Google-Smtp-Source":"ACJfBots0iNi6gQUTe0a867steJvFMi/xJAKAPFGYBgPjBUu3hejVqFu5zy9stEOpDOdioZPhDbXww==","X-Received":"by 10.55.136.135 with SMTP id k129mr14657654qkd.3.1515379609996; \n\tSun, 07 Jan 2018 18:46:49 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Paolo Bonzini ,\n\t\"Michael S. Tsirkin\" , =?utf-8?q?Herv=C3=A9_Poussinea?=\n\t=?utf-8?q?u?= ,\n\tAurelien Jarno , Eduardo Habkost\n\t, Marcel Apfelbaum ","Date":"Sun, 7 Jan 2018 23:45:41 -0300","Message-Id":"<20180108024558.17983-13-f4bug@amsat.org>","X-Mailer":"git-send-email 2.15.1","In-Reply-To":"<20180108024558.17983-1-f4bug@amsat.org>","References":"<20180108024558.17983-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::243","Subject":"[Qemu-devel] [PATCH 12/29] piix4: rename some variables in realize\n\tfunction","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Igor Mammedov , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Hervé Poussineau \n\nPIIX4 structure is now 's'\nPCI device is now 'pci_dev'\nDeviceState is now 'dev'\n\nAcked-by: Michael S. Tsirkin \nAcked-by: Paolo Bonzini \nSigned-off-by: Hervé Poussineau \n---\n hw/isa/piix4.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c\nindex 6b8bc3faf0..7b231b704b 100644\n--- a/hw/isa/piix4.c\n+++ b/hw/isa/piix4.c\n@@ -87,16 +87,17 @@ static const VMStateDescription vmstate_piix4 = {\n }\n };\n \n-static void piix4_realize(PCIDevice *dev, Error **errp)\n+static void piix4_realize(PCIDevice *pci_dev, Error **errp)\n {\n- PIIX4State *d = PIIX4_PCI_DEVICE(dev);\n+ DeviceState *dev = DEVICE(pci_dev);\n+ PIIX4State *s = DO_UPCAST(PIIX4State, dev, pci_dev);\n \n- if (!isa_bus_new(DEVICE(d), pci_address_space(dev),\n- pci_address_space_io(dev), errp)) {\n+ if (!isa_bus_new(dev, pci_address_space(pci_dev),\n+ pci_address_space_io(pci_dev), errp)) {\n return;\n }\n- piix4_dev = &d->dev;\n- qemu_register_reset(piix4_reset, d);\n+ piix4_dev = pci_dev;\n+ qemu_register_reset(piix4_reset, s);\n }\n \n int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn)\n","prefixes":["12/29"]}