{"id":856665,"url":"http://patchwork.ozlabs.org/api/patches/856665/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-19-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180108024558.17983-19-f4bug@amsat.org>","list_archive_url":null,"date":"2018-01-08T02:45:47","name":"[18/29] piix4: add a i8257 dma controller as specified in datasheet","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"963d471fd726102af52b5dff6fd25147a262072b","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-19-f4bug@amsat.org/mbox/","series":[{"id":21847,"url":"http://patchwork.ozlabs.org/api/series/21847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=21847","date":"2018-01-08T02:45:30","name":"remove i386/pc dependency: generic SuperIO, PIIX cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/21847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/856665/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/856665/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Js5iNTio\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFKWy1SnRz9s7h\n\tfor ;\n\tMon, 8 Jan 2018 13:50:38 +1100 (AEDT)","from localhost ([::1]:59345 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eYNWG-00015o-6X\n\tfor incoming@patchwork.ozlabs.org; Sun, 07 Jan 2018 21:50:36 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:51585)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSx-0007JD-Un\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:15 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSx-0002qc-4W\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:11 -0500","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:45642)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eYNSx-0002q4-0B\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:11 -0500","by mail-qk0-x244.google.com with SMTP id o126so12537278qke.12\n\tfor ; Sun, 07 Jan 2018 18:47:10 -0800 (PST)","from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id\n\td10sm7156245qkg.16.2018.01.07.18.47.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 07 Jan 2018 18:47:09 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=chbMtJzKXNsi6pGw2kwMddPyBzpG3dOnZoSmZJuwMPs=;\n\tb=Js5iNTioV5TaurcipQa3LkGXVnqWG7qAgIfJu2Xw7Tk+Qedx9mCCLirx22Y2JE293P\n\tiZPagohM8vZTo6iko/3rqB32KEbg75bJzIlV597IgR86nKrj8ghYMC3XNgAfjv05LWJe\n\towzOjIe93o1QOVcgRPtTJCY72iLt7Qsml+uyfAUhcTZqN4AlMDvznRSN0ia0UnGhNM+M\n\tK9qLwQbr59g5U9LrnXfCsZBpWwChgoWw5+8zxYUJA+gzx/ZJw8chCy6x258+NBJMlt7L\n\tDaDS8mV6/ooq6ufBHufkooiNkPYCj1CmXJTbQAJ2TJ/FzgufvcWmIPQZLhHbYpIIUhp4\n\t1WZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=chbMtJzKXNsi6pGw2kwMddPyBzpG3dOnZoSmZJuwMPs=;\n\tb=iDqCmGdItjlgjnRblZJ4u+4Rke4cTHJoPf9KtVnW5TWwodlhf0pN+RPW76i+N6BoUc\n\tDmunnLySmxv1HMhVCvqBRVqSwSbt34L9xTmX6Jl3Y0piuS/d5JShOf/rTGCjuNqmddQ5\n\tZ1hTDlh2dGHZP2Z89rGvwmGtShXlFc6M7tLQ4csiO2gzkM+hrRO8Z/3mjqMuJbjm1tLK\n\tGtUisU9Qx2Fyliq9/qJvshVxLsB/xs8bgRBA6uExu4HlsrpAtJoESI4qTsa+veAAaeSz\n\tTjBE+lwIBVqcR1m7LIVyFEjS1ZnFVZ2Gb9v6suEzTcFglfP+vXdsl9v90ab5UUf2M0N9\n\tAy+w==","X-Gm-Message-State":"AKwxytfGxm3+PI7D4AKsFEiE/s1Yd3mjr/2YMLM8qN6kM8lWp7z93YBF\n\tp76DbipW550/tz4EVlLY7AU=","X-Google-Smtp-Source":"ACJfBovjMK9DxqBDqOBYf8DvAPXezOBvw9/umGDbAJ7uYyQPhvIU+gYsqnTBwi5CnoiULiwjIDf1sg==","X-Received":"by 10.55.167.130 with SMTP id\n\tq124mr14660617qke.167.1515379630494; \n\tSun, 07 Jan 2018 18:47:10 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Paolo Bonzini ,\n\t\"Michael S. Tsirkin\" , =?utf-8?q?Herv=C3=A9_Poussinea?=\n\t=?utf-8?q?u?= ,\n\tAurelien Jarno , Eduardo Habkost\n\t, Marcel Apfelbaum ","Date":"Sun, 7 Jan 2018 23:45:47 -0300","Message-Id":"<20180108024558.17983-19-f4bug@amsat.org>","X-Mailer":"git-send-email 2.15.1","In-Reply-To":"<20180108024558.17983-1-f4bug@amsat.org>","References":"<20180108024558.17983-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"[Qemu-devel] [PATCH 18/29] piix4: add a i8257 dma controller as\n\tspecified in datasheet","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Igor Mammedov , Yongbok Kim , \n\tqemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Hervé Poussineau \n\nRemove i8257 instanciated in malta board, to not have it twice.\n\nSigned-off-by: Hervé Poussineau \n[PMD: rebased]\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/isa/piix4.c | 4 ++++\n hw/mips/mips_malta.c | 2 --\n 2 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c\nindex b0f6a0a342..56a1c7d429 100644\n--- a/hw/isa/piix4.c\n+++ b/hw/isa/piix4.c\n@@ -29,6 +29,7 @@\n #include \"hw/pci/pci.h\"\n #include \"hw/isa/isa.h\"\n #include \"hw/southbridge/i82371_piix.h\"\n+#include \"hw/dma/i8257.h\"\n #include \"hw/sysbus.h\"\n \n PCIDevice *piix4_dev;\n@@ -163,6 +164,9 @@ static void piix4_realize(PCIDevice *pci_dev, Error **errp)\n /* initialize ISA irqs */\n isa_bus_irqs(isa_bus, s->isa);\n \n+ /* DMA */\n+ i8257_dma_init(isa_bus, 0);\n+\n piix4_dev = pci_dev;\n }\n \ndiff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\nindex d31e144b70..db5a8b1811 100644\n--- a/hw/mips/mips_malta.c\n+++ b/hw/mips/mips_malta.c\n@@ -28,7 +28,6 @@\n #include \"hw/hw.h\"\n #include \"hw/i386/pc.h\"\n #include \"hw/isa/superio.h\"\n-#include \"hw/dma/i8257.h\"\n #include \"hw/char/serial.h\"\n #include \"net/net.h\"\n #include \"hw/boards.h\"\n@@ -1208,7 +1207,6 @@ void mips_malta_init(MachineState *machine)\n smbus = piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100,\n isa_get_irq(NULL, 9), NULL, 0, NULL);\n pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n- i8257_dma_init(isa_bus, 0);\n mc146818_rtc_init(isa_bus, 2000, NULL);\n \n /* generate SPD EEPROM data */\n","prefixes":["18/29"]}