{"id":856664,"url":"http://patchwork.ozlabs.org/api/patches/856664/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-12-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180108024558.17983-12-f4bug@amsat.org>","list_archive_url":null,"date":"2018-01-08T02:45:40","name":"[11/29] mc146818rtc: always register rtc to rtc list","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bdad5c5f8acbe5cd397bf0752dfcff175efa2329","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-12-f4bug@amsat.org/mbox/","series":[{"id":21847,"url":"http://patchwork.ozlabs.org/api/series/21847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=21847","date":"2018-01-08T02:45:30","name":"remove i386/pc dependency: generic SuperIO, PIIX cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/21847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/856664/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/856664/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Yi6gu94Q\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFKWj1qHGz9s7n\n\tfor ;\n\tMon, 8 Jan 2018 13:50:25 +1100 (AEDT)","from localhost ([::1]:59336 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eYNW3-0000uh-A5\n\tfor incoming@patchwork.ozlabs.org; Sun, 07 Jan 2018 21:50:23 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:51393)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSa-0006vb-JV\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:49 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1eYNSZ-0002Vh-GX\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:48 -0500","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:44107)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eYNSZ-0002VY-Cq\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:47 -0500","by mail-qk0-x244.google.com with SMTP id v188so12535823qkh.11\n\tfor ; Sun, 07 Jan 2018 18:46:47 -0800 (PST)","from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id\n\td10sm7156245qkg.16.2018.01.07.18.46.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 07 Jan 2018 18:46:46 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XDFVDszPM59jDh1dUr6/6FsEEUzm7pgA8ycgI6wOzf0=;\n\tb=Yi6gu94QfLSqlNOnG60z7TUW19RsuFwpsaLh/iUWoWN+k6PhsO/8YYuQN2F/H2A5Pq\n\tvdjmz5b6RDqXaK0Kk6cb+hImj6lgviwiPgEV+fYPZpCY6aEzN0KERRYL2VPPFJ+u0Y25\n\tiP+ujr6lOnMt25RONZOFwtWXOecrWEJKeo3t6U4GRrpTPi6+B3+vyqO9Gyt8GMBoTtKQ\n\tGI62IJG6wQUeZj+1Cdc/bcw733smOH5kl43rT0lnAxXduWrhnSkUMunTEtqa1SlvMWCE\n\tB8POtpg3RN9Fl62q3MmcQq1KD/m8KZXlA59HQc9JcmQuZ2hKhz2bWgELttumrpS+TlX2\n\tz7Lw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=XDFVDszPM59jDh1dUr6/6FsEEUzm7pgA8ycgI6wOzf0=;\n\tb=XiMjEacN8q1lCzlknexezlIJniEpaU1hRVkI+13zmKZQJ+Yq+yRN/rAbO9Gq7AQ6sS\n\tmixWa0T6XcpSQZPBBL7oLsDtwk0n1NHu/MNFHRFltBEJRfg83e3Jz75RgjZTw6ARY3ld\n\ty0lLSh5yXkbcLVWqOkf5ksoZ2d4o0tz24K1b4IDxL1uHLWnZemGn5Tk7RpzmPQZeMtlx\n\toGx0zuryc0ploxgDBNXVWQGWYt2UQ6ycqpZduvy8NS+M5g+5FWooHwNhbqOlKlFcaNbf\n\tHqhkAx/EtNrqru571Dw/Cug3OdTdC41S1cDYEwDe477ViZ99MdTTuNFlcOUUKJbJGL7M\n\tMJ/A==","X-Gm-Message-State":"AKwxytfG95Uho0ZzMNFzjkvOGgecfJebp2cla/v2GxwpY+hUMn4FcMeM\n\tebS58RRtSbCzDCppUWzHYYs=","X-Google-Smtp-Source":"ACJfBovsjyfz1v7PICymkeTF+3KpIsCOUcq7Tjt+f51IH4m4jGFpJAnMPGqZHRHslVJxqhwyY+wcjQ==","X-Received":"by 10.55.217.132 with SMTP id q4mr12383067qkl.236.1515379606879; \n\tSun, 07 Jan 2018 18:46:46 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Paolo Bonzini ,\n\t\"Michael S. Tsirkin\" , =?utf-8?q?Herv=C3=A9_Poussinea?=\n\t=?utf-8?q?u?= ,\n\tAurelien Jarno , Eduardo Habkost\n\t, Marcel Apfelbaum ","Date":"Sun, 7 Jan 2018 23:45:40 -0300","Message-Id":"<20180108024558.17983-12-f4bug@amsat.org>","X-Mailer":"git-send-email 2.15.1","In-Reply-To":"<20180108024558.17983-1-f4bug@amsat.org>","References":"<20180108024558.17983-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"[Qemu-devel] [PATCH 11/29] mc146818rtc: always register rtc to rtc\n\tlist","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Igor Mammedov , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Hervé Poussineau \n\nWe are not required anymore to use rtc_init() function.\n\nAcked-by: Michael S. Tsirkin \nAcked-by: Paolo Bonzini \nSigned-off-by: Hervé Poussineau \n---\n hw/timer/mc146818rtc.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c\nindex 35a05a64cc..b0027e8f62 100644\n--- a/hw/timer/mc146818rtc.c\n+++ b/hw/timer/mc146818rtc.c\n@@ -997,17 +997,16 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)\n OBJECT(s), \"date\", NULL);\n \n qdev_init_gpio_out(dev, &s->irq, 1);\n+ QLIST_INSERT_HEAD(&rtc_devices, s, link);\n }\n \n ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)\n {\n DeviceState *dev;\n ISADevice *isadev;\n- RTCState *s;\n \n isadev = isa_create(bus, TYPE_MC146818_RTC);\n dev = DEVICE(isadev);\n- s = MC146818_RTC(isadev);\n qdev_prop_set_int32(dev, \"base_year\", base_year);\n qdev_init_nofail(dev);\n if (intercept_irq) {\n@@ -1015,7 +1014,6 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)\n } else {\n isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ);\n }\n- QLIST_INSERT_HEAD(&rtc_devices, s, link);\n \n return isadev;\n }\n@@ -1046,8 +1044,6 @@ static void rtc_class_initfn(ObjectClass *klass, void *data)\n dc->reset = rtc_resetdev;\n dc->vmsd = &vmstate_rtc;\n dc->props = mc146818rtc_properties;\n- /* Reason: needs to be wired up by rtc_init() */\n- dc->user_creatable = false;\n }\n \n static void rtc_finalize(Object *obj)\n","prefixes":["11/29"]}