{"id":856661,"url":"http://patchwork.ozlabs.org/api/patches/856661/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-10-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180108024558.17983-10-f4bug@amsat.org>","list_archive_url":null,"date":"2018-01-08T02:45:38","name":"[09/29] hw/mips/malta: code movement","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1fd7264a2fa86fb064994c4c49b48104af6da2af","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-10-f4bug@amsat.org/mbox/","series":[{"id":21847,"url":"http://patchwork.ozlabs.org/api/series/21847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=21847","date":"2018-01-08T02:45:30","name":"remove i386/pc dependency: generic SuperIO, PIIX cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/21847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/856661/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/856661/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GxSXG9lg\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFKSc0xhtz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon,  8 Jan 2018 13:47:44 +1100 (AEDT)","from localhost ([::1]:59324 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1eYNTS-00071y-5v\n\tfor incoming@patchwork.ozlabs.org; Sun, 07 Jan 2018 21:47:42 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:51341)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNST-0006pV-Rt\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:42 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNST-0002RQ-4e\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:41 -0500","from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:47093)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNSS-0002R2-WB\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:41 -0500","by mail-qt0-x241.google.com with SMTP id r39so12053430qtr.13\n\tfor <qemu-devel@nongnu.org>; Sun, 07 Jan 2018 18:46:40 -0800 (PST)","from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id\n\td10sm7156245qkg.16.2018.01.07.18.46.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 07 Jan 2018 18:46:40 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kEw6fJIOLjx1iG1GEgavYsjnjGhVwVBiUq73JJhPHgo=;\n\tb=GxSXG9lgmziBJGRSUuQ2KVVKDN057ndsko2Parq2ZgUfpvJTpOZymPtxdvVR3c5sPh\n\ttTxN+In9O5hnrJuSYyCxDGasJEOKuRkeUUmTOcv02Ap9jsPWc4DZNmxadh8LrHcdQFx6\n\tx8MO9BazlB+7+kG2dIwTVp9hdb10Z7EjSJTSRuYbKnFeZ6ClmMdAO8ID6s2mybBDEEJV\n\tfAXczrgB8nudJLNJYhDFBIFvcPNo6Qs7TljyvInC9nFgFSTBTDspWVR9M8SbyKwzOKeh\n\tQqwHG4KeRt5vvXpNTQAHDpZ39ImqYmygWO1xQ0cvadYx/48ZH5qX9X9aBuO4WKxwHOGg\n\tbLBA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=kEw6fJIOLjx1iG1GEgavYsjnjGhVwVBiUq73JJhPHgo=;\n\tb=fVZnbxsO5Pyt3rP9UZY4dI+dvgNcNPUgtJHbCCwYP3aeOn/Fk/Ye8EViwAf0nu7Ozj\n\tZEKPeb4vWX6Vkgwic7igppK9aPt1Ir79x5Br+y1ubT6hhsOByHiAthZX8gA/8TZfA/cR\n\t4znhQ1b9LiSrQzVfhaTLP3zSlds3k0ajt/tOvTqQGq5SgSTF6mKAxEP49oex06SyZ039\n\tj1j2Y1EWYQVin8QzJ72X2BCMOiNv8me97r7i4kermUzEwsHUSldHzztCSImlgn/rFPjf\n\t/tvdXxyKquFPR1BvXLD2xEj85H4FVaxDW7sZsWZL45Rd8QduKov6desePEcGUugli9ds\n\tIJMA==","X-Gm-Message-State":"AKwxytfRXRRzXgInTUNvNUqrnFEzEGukaczeYz1JdvwFtVzJvr196PXm\n\tThl3YCcC14Wa4ZOAjRVsYx4=","X-Google-Smtp-Source":"ACJfBosb26RCvZNJvB1YRN1lpAuVm4m6Pf4Gmwbr9wv26C15B1B5V+tfd9LJBhIsUtPneVnnPfcTPw==","X-Received":"by 10.200.52.171 with SMTP id w40mr14653759qtb.205.1515379600496;\n\tSun, 07 Jan 2018 18:46:40 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","To":"Paolo Bonzini <pbonzini@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>, =?utf-8?q?Herv=C3=A9_Poussinea?=\n\t=?utf-8?q?u?= <hpoussin@reactos.org>,\n\tAurelien Jarno <aurelien@aurel32.net>, Eduardo Habkost\n\t<ehabkost@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>","Date":"Sun,  7 Jan 2018 23:45:38 -0300","Message-Id":"<20180108024558.17983-10-f4bug@amsat.org>","X-Mailer":"git-send-email 2.15.1","In-Reply-To":"<20180108024558.17983-1-f4bug@amsat.org>","References":"<20180108024558.17983-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::241","Subject":"[Qemu-devel] [PATCH 09/29] hw/mips/malta: code movement","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Igor Mammedov <imammedo@redhat.com>, Yongbok Kim <yongbok.kim@mips.com>, \n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n hw/mips/mips_malta.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\nindex 28cc37ee08..195d7dd59e 100644\n--- a/hw/mips/mips_malta.c\n+++ b/hw/mips/mips_malta.c\n@@ -1063,10 +1063,6 @@ void mips_malta_init(MachineState *machine)\n         memory_region_add_subregion(system_memory, 512 << 20, ram_low_postio);\n     }\n \n-    /* generate SPD EEPROM data */\n-    generate_eeprom_spd(&smbus_eeprom_buf[0 * 256], ram_size);\n-    generate_eeprom_serial(&smbus_eeprom_buf[6 * 256]);\n-\n #ifdef TARGET_WORDS_BIGENDIAN\n     be = 1;\n #else\n@@ -1209,15 +1205,19 @@ void mips_malta_init(MachineState *machine)\n     pci_create_simple(pci_bus, piix4_devfn + 2, \"piix4-usb-uhci\");\n     smbus = piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100,\n                           isa_get_irq(NULL, 9), NULL, 0, NULL);\n-    smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);\n-    g_free(smbus_eeprom_buf);\n     pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n     i8257_dma_init(isa_bus, 0);\n+    mc146818_rtc_init(isa_bus, 2000, NULL);\n+\n+    /* generate SPD EEPROM data */\n+    generate_eeprom_spd(&smbus_eeprom_buf[0 * 256], ram_size);\n+    generate_eeprom_serial(&smbus_eeprom_buf[6 * 256]);\n+    smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);\n+    g_free(smbus_eeprom_buf);\n \n     /* Super I/O */\n     isa_create_simple(isa_bus, TYPE_I8042);\n \n-    mc146818_rtc_init(isa_bus, 2000, NULL);\n     serial_hds_isa_init(isa_bus, 0, 2);\n     parallel_hds_isa_init(isa_bus, 1);\n \n","prefixes":["09/29"]}