{"id":823508,"url":"http://patchwork.ozlabs.org/api/patches/823508/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net>","list_archive_url":null,"date":"2017-10-09T20:49:33","name":"[1/3] net/atm: Delete an error message for a failed memory allocation in five functions","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"cbda7d03be162d3b3555b99aa682490e2d3c018e","submitter":{"id":65077,"url":"http://patchwork.ozlabs.org/api/people/65077/?format=json","name":"SF Markus Elfring","email":"elfring@users.sourceforge.net"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net/mbox/","series":[{"id":7242,"url":"http://patchwork.ozlabs.org/api/series/7242/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=7242","date":"2017-10-09T20:48:11","name":"net-ATM: Adjustments for several function implementations","version":1,"mbox":"http://patchwork.ozlabs.org/series/7242/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/823508/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/823508/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9snY0b9kz9t5l\n\tfor ;\n\tTue, 10 Oct 2017 07:50:09 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755060AbdJIUt6 (ORCPT );\n\tMon, 9 Oct 2017 16:49:58 -0400","from mout.web.de ([212.227.17.12]:57473 \"EHLO mout.web.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754188AbdJIUt4 (ORCPT );\n\tMon, 9 Oct 2017 16:49:56 -0400","from [192.168.1.2] ([77.181.206.143]) by smtp.web.de (mrweb101\n\t[213.165.67.124]) with ESMTPSA (Nemesis) id 0LsyZi-1dGgN10jc2-012U05;\n\tMon, 09 Oct 2017 22:49:37 +0200"],"Subject":"[PATCH 1/3] net/atm: Delete an error message for a failed memory\n\tallocation in five functions","From":"SF Markus Elfring ","To":"netdev@vger.kernel.org, Alexey Dobriyan ,\n\tAndrew Morton ,\n\tAugusto Mecking Caringi ,\n\tBhumika Goyal ,\n\t\"David S. Miller\" ,\n\tDavid Windsor ,\n\tElena Reshetova ,\n\tHans Liljestrand , Jarod Wilson ,\n\tJohannes Berg ,\n\tKees Cook , Mitchell Blank Jr ,\n\tRoopa Prabhu ","Cc":"LKML , kernel-janitors@vger.kernel.org","References":"<10a92558-1105-b947-86a2-6ac763cca36d@users.sourceforge.net>","Message-ID":"<5270f15b-5e97-0c3e-3e55-fbded48ae07d@users.sourceforge.net>","Date":"Mon, 9 Oct 2017 22:49:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<10a92558-1105-b947-86a2-6ac763cca36d@users.sourceforge.net>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:/UOMoywmEtE026gwLOCoD3IDzMWcGn5FCaGjiUeU74e92J5Ve+Q\n\t843rduzOiKlDDix/ikZV/Eh17r9JvzSgRQCyMEA2yLU0DhUZNNykPp4qQ5F59owDbtoXamB\n\tR4K5VRe0qlFxobVxOd6ztUCqk7JZtdk9x/a4OQw7LbKsP22Jy0hJssZx386HJSUxhYNeTrc\n\t1pHtNU9oj9p2CoHkcwKiA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:7phiGjOCweQ=:oSjgLTIc4VqflCzyn08vUC\n\t7QhGk6sDoDb6lWVAmHj+r3+CUsjJSLnz6QT6TuxBSYE5AXPstSPwBdktsEGSX1U2DKOXakv9S\n\tX8M1fBvDvDkYEqTmruNBG1c6X5rfaRF7K7aT+P1oFl1xGLlx1w/KCggTo6n4JI+LnRo10/TCc\n\taiUe+/HfVFzHVH/GJjd+jy8qVnVxWgQhR+9G3wVdbDaQJzJdSGFg87JGq9QWh4aj00sYrchPt\n\t/Tk7HqiugmTzSuegRAcUGQed+kfVXo1J1n1a8JmxKPDLjjnpCqn+n3A++yTXz+1SZTG0bFtfy\n\tJOFyxTQ/ubbgQO6tMIVtEQV8QUumHPPDgY9edEAwQlvFRKOU40fqEz9Xd0HGZzxmnfpNZ9OZK\n\tjFOiGsJX/KkKxpihQT9PJFimnT4OmoyhPF6cRnRHqHkdRizBYev/kuJpmoDLtCXhNyMKE9XxJ\n\tL3qdPaMrJsfJnBaHhBOsp+ZpWRjQwx52nWZRWxXrBy3BbqTw1y7vjGJWILc1TEfr0RaBBE4yj\n\tYpXkyKl8pJNYeFfLrrgMjEi3VIbBmO/eyZjnZhbuYWo4xTl5znDPUg4QnEpD4jOwoL0zT+9GX\n\thoqwQAQRHd9/YypO0bNxpXao4rEsygJyWWO+BKXrTbq7o+tfJDFHkvG95xG9Pg2TSqJV9dUTO\n\tytNH32Dq98fRukmtR4xes/H2pMhe0rNhM4tprt/+Ur+urHf3LVfKSyLY6KRDfE9+fqiKp43+m\n\tNb/4osMHdUjCvY0IABWEdMYQXx7dXRdpWl8yMY1EPnYCLTn4/z05ckTDQYv4ccdLrj0wZLGUF\n\tDRxGGtMiTV4vVlryd0Fni842XIYdqXu8i7pUCSLnCSBaTu5iP0=","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Markus Elfring \nDate: Mon, 9 Oct 2017 21:34:35 +0200\n\nOmit extra messages for a memory allocation failure in these functions.\n\nThis issue was detected by using the Coccinelle software.\n\nSigned-off-by: Markus Elfring \n---\n net/atm/lec.c | 5 ++---\n net/atm/mpc.c | 8 ++------\n net/atm/mpoa_caches.c | 8 ++------\n 3 files changed, 6 insertions(+), 15 deletions(-)","diff":"diff --git a/net/atm/lec.c b/net/atm/lec.c\nindex a3d93a1bb133..f5be0b931978 100644\n--- a/net/atm/lec.c\n+++ b/net/atm/lec.c\n@@ -1553,10 +1553,9 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,\n \tstruct lec_arp_table *to_return;\n \n \tto_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);\n-\tif (!to_return) {\n-\t\tpr_info(\"LEC: Arp entry kmalloc failed\\n\");\n+\tif (!to_return)\n \t\treturn NULL;\n-\t}\n+\n \tether_addr_copy(to_return->mac_addr, mac_addr);\n \tINIT_HLIST_NODE(&to_return->next);\n \tsetup_timer(&to_return->timer, lec_arp_expire_arp,\ndiff --git a/net/atm/mpc.c b/net/atm/mpc.c\nindex 5677147209e8..dd57d05b5dcc 100644\n--- a/net/atm/mpc.c\n+++ b/net/atm/mpc.c\n@@ -184,10 +184,8 @@ struct atm_mpoa_qos *atm_mpoa_add_qos(__be32 dst_ip, struct atm_qos *qos)\n \t}\n \n \tentry = kmalloc(sizeof(struct atm_mpoa_qos), GFP_KERNEL);\n-\tif (entry == NULL) {\n-\t\tpr_info(\"mpoa: out of memory\\n\");\n+\tif (!entry)\n \t\treturn entry;\n-\t}\n \n \tentry->ipaddr = dst_ip;\n \tentry->qos = *qos;\n@@ -473,10 +471,8 @@ static const uint8_t *copy_macs(struct mpoa_client *mpc,\n \t\t\tkfree(mpc->mps_macs);\n \t\tmpc->number_of_mps_macs = 0;\n \t\tmpc->mps_macs = kmalloc(num_macs * ETH_ALEN, GFP_KERNEL);\n-\t\tif (mpc->mps_macs == NULL) {\n-\t\t\tpr_info(\"(%s) out of mem\\n\", mpc->dev->name);\n+\t\tif (!mpc->mps_macs)\n \t\t\treturn NULL;\n-\t\t}\n \t}\n \tether_addr_copy(mpc->mps_macs, router_mac);\n \ttlvs += 20; if (device_type == MPS_AND_MPC) tlvs += 20;\ndiff --git a/net/atm/mpoa_caches.c b/net/atm/mpoa_caches.c\nindex 4ccaa16b1eb1..7495b42d59eb 100644\n--- a/net/atm/mpoa_caches.c\n+++ b/net/atm/mpoa_caches.c\n@@ -98,10 +98,8 @@ static in_cache_entry *in_cache_add_entry(__be32 dst_ip,\n {\n \tin_cache_entry *entry = kzalloc(sizeof(in_cache_entry), GFP_KERNEL);\n \n-\tif (entry == NULL) {\n-\t\tpr_info(\"mpoa: mpoa_caches.c: new_in_cache_entry: out of memory\\n\");\n+\tif (!entry)\n \t\treturn NULL;\n-\t}\n \n \tdprintk(\"adding an ingress entry, ip = %pI4\\n\", &dst_ip);\n \n@@ -460,10 +458,8 @@ static eg_cache_entry *eg_cache_add_entry(struct k_message *msg,\n {\n \teg_cache_entry *entry = kzalloc(sizeof(eg_cache_entry), GFP_KERNEL);\n \n-\tif (entry == NULL) {\n-\t\tpr_info(\"out of memory\\n\");\n+\tif (!entry)\n \t\treturn NULL;\n-\t}\n \n \tdprintk(\"adding an egress entry, ip = %pI4, this should be our IP\\n\",\n \t\t&msg->content.eg_info.eg_dst_ip);\n","prefixes":["1/3"]}