{"id":819513,"url":"http://patchwork.ozlabs.org/api/patches/819513/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20170928095628.21966-7-thierry.reding@gmail.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170928095628.21966-7-thierry.reding@gmail.com>","list_archive_url":null,"date":"2017-09-28T09:56:18","name":"[v2,06/16] gpio: Move irq_default_type to struct gpio_irq_chip","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d018c452bdd8633bafde9109f7c1a4cf7d8908c1","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/?format=json","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20170928095628.21966-7-thierry.reding@gmail.com/mbox/","series":[{"id":5528,"url":"http://patchwork.ozlabs.org/api/series/5528/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=5528","date":"2017-09-28T09:56:12","name":"gpio: Tight IRQ chip integration and banked infrastructure","version":2,"mbox":"http://patchwork.ozlabs.org/series/5528/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819513/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819513/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"prmZNKQl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2qtH04GDz9t5w\n\tfor ;\n\tThu, 28 Sep 2017 19:59:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752960AbdI1J7f (ORCPT );\n\tThu, 28 Sep 2017 05:59:35 -0400","from mail-qk0-f195.google.com ([209.85.220.195]:33585 \"EHLO\n\tmail-qk0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752786AbdI1J4t (ORCPT\n\t);\n\tThu, 28 Sep 2017 05:56:49 -0400","by mail-qk0-f195.google.com with SMTP id g128so654287qke.0;\n\tThu, 28 Sep 2017 02:56:48 -0700 (PDT)","from localhost\n\t(p200300E41BCC8100EA54DC343767CF80.dip0.t-ipconnect.de.\n\t[2003:e4:1bcc:8100:ea54:dc34:3767:cf80])\n\tby smtp.gmail.com with ESMTPSA id\n\tg131sm750482qkb.15.2017.09.28.02.56.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 28 Sep 2017 02:56:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RJZZB6K5n2tUwLFyNO18kxtYvB/4WYsdpZGOT0AM7Ko=;\n\tb=prmZNKQlJLaCa3APkqzuqnw8qsvj3tbCnrI1tIduIQ4poGRbqXCtK8azITcSX79H96\n\t2on0CLPoJrlNKGD0mQ9OgzQSZ8fD7pfIuJairNmPDTyOGNm3nXu3ACoqPDOpAGt8QVS0\n\tCi0SBlJJMIh8M/d7FNKfVaMwn3vEiA9NDXpVoXQK8TTSLsxY0fNHt4jHhV4niR3FUy4j\n\tm+WraVrTb91nSyfs+k4BUojv94ngJBjhSnCXy8KuVvR0SO0L0dfaYknyog5D5VJsMCMX\n\tQ6jOLBdTWbIPYoM5dyeYSGPjzartdY2XJ4RSc47Xs0BuTQtq26M8NhnwxzomlL52sW5n\n\txFqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RJZZB6K5n2tUwLFyNO18kxtYvB/4WYsdpZGOT0AM7Ko=;\n\tb=NQ0KuV+6mPHHI3s1gXVic4NTUBS7f578OhYPvmwcEEieADw8/tGolFLA6OkbJII1n0\n\t+fW6woNJVNiPeUkhyr7W8nUr5evpDbAFOVKH/ecEGeRakg/lvBF23LzMZzwPqo0gXAgZ\n\tO1o0oG04foNJ43/z4oZCAMsoMZt+d93xTihI3I0yxVHH9453tcTUsvs5vQn70E2eX6c7\n\t1MzoN7MtSAOJ81BEz7+38jon+AGg4DAvQ2438w6mGR7UdoMsjVeo/+okYY8e8X84K10w\n\tE3CbdI1CVDvoy9REuyjh+kRDTly7fL2nf45x+kRfiEP+XU8QUEyTlzCyUpYvkGluH0cy\n\tCCuA==","X-Gm-Message-State":"AHPjjUhFBCtaFANS84OCy9FntiVmvhZ+Vp6vccVtD6BlsKffSYDwWiPs\n\tb9OleUATfncIyoEXs3WSy1k=","X-Google-Smtp-Source":"AOwi7QB7EFo92zxtkAJI1y4nbwi3LVCMhZ1+oQqicivyJ+PrRp8mYANkoUB5LRRHVYALf6jDtDffnQ==","X-Received":"by 10.55.76.205 with SMTP id z196mr6223207qka.252.1506592608268; \n\tThu, 28 Sep 2017 02:56:48 -0700 (PDT)","From":"Thierry Reding ","To":"Linus Walleij ","Cc":"Jonathan Hunter , linux-gpio@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH v2 06/16] gpio: Move irq_default_type to struct gpio_irq_chip","Date":"Thu, 28 Sep 2017 11:56:18 +0200","Message-Id":"<20170928095628.21966-7-thierry.reding@gmail.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170928095628.21966-1-thierry.reding@gmail.com>","References":"<20170928095628.21966-1-thierry.reding@gmail.com>","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"},"content":"From: Thierry Reding \n\nIn order to consolidate the multiple ways to associate an IRQ chip with\na GPIO chip, move more fields into the new struct gpio_irq_chip.\n\nSigned-off-by: Thierry Reding \n---\n drivers/gpio/gpiolib.c | 10 +++++-----\n include/linux/gpio/driver.h | 11 ++++++++---\n 2 files changed, 13 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c\nindex dc44f2c97498..bbad2eae30e2 100644\n--- a/drivers/gpio/gpiolib.c\n+++ b/drivers/gpio/gpiolib.c\n@@ -1655,8 +1655,8 @@ int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,\n \t * No set-up of the hardware will happen if IRQ_TYPE_NONE\n \t * is passed as default type.\n \t */\n-\tif (chip->irq_default_type != IRQ_TYPE_NONE)\n-\t\tirq_set_irq_type(irq, chip->irq_default_type);\n+\tif (chip->irq.default_type != IRQ_TYPE_NONE)\n+\t\tirq_set_irq_type(irq, chip->irq.default_type);\n \n \treturn 0;\n }\n@@ -1733,7 +1733,7 @@ static int gpiochip_add_irqchip(struct gpio_chip *gpiochip)\n \t\treturn -EINVAL;\n \t}\n \n-\ttype = gpiochip->irq_default_type;\n+\ttype = gpiochip->irq.default_type;\n \tnp = gpiochip->parent->of_node;\n \n #ifdef CONFIG_OF_GPIO\n@@ -1762,7 +1762,7 @@ static int gpiochip_add_irqchip(struct gpio_chip *gpiochip)\n \t}\n \n \tgpiochip->to_irq = gpiochip_to_irq;\n-\tgpiochip->irq_default_type = type;\n+\tgpiochip->irq.default_type = type;\n \n \tif (gpiochip->irq.domain_ops)\n \t\tops = gpiochip->irq.domain_ops;\n@@ -1950,7 +1950,7 @@ int gpiochip_irqchip_add_key(struct gpio_chip *gpiochip,\n \n \tgpiochip->irq.chip = irqchip;\n \tgpiochip->irq.handler = handler;\n-\tgpiochip->irq_default_type = type;\n+\tgpiochip->irq.default_type = type;\n \tgpiochip->to_irq = gpiochip_to_irq;\n \tgpiochip->lock_key = lock_key;\n \tgpiochip->irq.domain = irq_domain_add_simple(of_node,\ndiff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h\nindex b1398ea0c32a..bcf93afddfa6 100644\n--- a/include/linux/gpio/driver.h\n+++ b/include/linux/gpio/driver.h\n@@ -62,6 +62,14 @@ struct gpio_irq_chip {\n \t */\n \tirq_flow_handler_t handler;\n \n+\t/**\n+\t * @default_type:\n+\t *\n+\t * Default IRQ triggering type applied during GPIO driver\n+\t * initialization, provided by GPIO driver.\n+\t */\n+\tunsigned int default_type;\n+\n \t/**\n \t * @parent_handler:\n \t *\n@@ -168,8 +176,6 @@ static inline struct gpio_irq_chip *to_gpio_irq_chip(struct irq_chip *chip)\n *\tsafely.\n * @bgpio_dir: shadowed direction register for generic GPIO to clear/set\n *\tdirection safely.\n- * @irq_default_type: default IRQ triggering type applied during GPIO driver\n- *\tinitialization, provided by GPIO driver\n * @irq_chained_parent: GPIO IRQ chip parent/bank linux irq number,\n *\tprovided by GPIO driver for chained interrupt (not for nested\n *\tinterrupts).\n@@ -245,7 +251,6 @@ struct gpio_chip {\n \t * With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib\n \t * to handle IRQs for most practical cases.\n \t */\n-\tunsigned int\t\tirq_default_type;\n \tunsigned int\t\tirq_chained_parent;\n \tbool\t\t\tirq_nested;\n \tbool\t\t\tirq_need_valid_mask;\n","prefixes":["v2","06/16"]}