{"id":819474,"url":"http://patchwork.ozlabs.org/api/patches/819474/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170928094627.31017-2-romain.izard.pro@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170928094627.31017-2-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-28T09:46:20","name":"[v4,1/8] clk: at91: pmc: Wait for clocks when resuming","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"3c0aefa7e09b25b04e247655ccad78b77581748f","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170928094627.31017-2-romain.izard.pro@gmail.com/mbox/","series":[{"id":5526,"url":"http://patchwork.ozlabs.org/api/series/5526/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=5526","date":"2017-09-28T09:46:23","name":"Various patches for SAMA5D2 backup mode","version":4,"mbox":"http://patchwork.ozlabs.org/series/5526/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819474/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819474/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"se0XVSzm\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SRLnD8K5\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2qcR2QXtz9t4c\n\tfor ;\n\tThu, 28 Sep 2017 19:47:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxVPz-0003Kk-Tb; Thu, 28 Sep 2017 09:47:43 +0000","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxVPJ-0002Q8-Ux\n\tfor linux-mtd@lists.infradead.org; Thu, 28 Sep 2017 09:47:08 +0000","by mail-wm0-x243.google.com with SMTP id r74so1045169wme.4\n\tfor ;\n\tThu, 28 Sep 2017 02:46:41 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\tz10sm3272395wre.6.2017.09.28.02.46.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Sep 2017 02:46:39 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=3dw90dNA4aPy1GDH9odCKvAVcb67guL9zNlBvjkX0Ys=;\n\tb=se0XVSzmdtIVYxFqfceY5BgvOb\n\tISHB5n33SMfQup98ch0+3yDk8hv6zxPwQRR9rD/KI28cRsg+7Hp+n1cgFh34M7h+9HTWroRElzhLM\n\tb4L/eLQfFuk8HZgxSjRJmbyYeLKz/b0EAD4IIDo7307AVO9TzdN9NHQcsU2tyJD/B1VOtxswLaCu2\n\tAxD3V1LvUSF6n8qgviU26iM4ZomqOOaxdmV9TCVtyHGp1TIveHMzgjV36nOHGmfK0ahThp9FArFwg\n\tG2eoVGu3IvN8Zmm4wU86u6MIXZQQS7gLJeCDf1nNHMs54FV8v43eV3XnesJfeEpVKIRd/415ttZ/Y\n\tAq+jawig==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SXCU17pSZBd7SdVZm1ZcLIHKqn3I6ldleFFnCs7nces=;\n\tb=SRLnD8K5pCMArMDGvBIvj8liP7zplU//N5qwgHFz6d5K1Un7AoehbHni7ga1RSWLOL\n\tYj3mel1Aqtb08aQAJSyhe16FwtvN8naV7DNdxWKHQVZISzR/q8D0L071wJlP2ucR9Fmu\n\t1zPZD8YQxEkC5zG04cHKyN73hWQ8/GAiI7yBaHne1nj1hX+mXnU8UKkzqvaqp8sIxwFu\n\t7SDJ0nzaSM0yYjvxhbHuXgkCef3tZOZVzr1W8zFII4r2XCPt+0baJ22Ngdi/aQRJV00L\n\tVZJARAWobjaDU3z9zj5HVAu0Vm8sfSUa/blaE03SDUxoQXoU5Ra2eM5arOWkP9Ng/eEn\n\tqaXw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SXCU17pSZBd7SdVZm1ZcLIHKqn3I6ldleFFnCs7nces=;\n\tb=YRUJBDyQAaV690JSe0UgC8TVT6KukSmEc0GVVy06ITcfgD0QYdxBG5gKaZhV34lims\n\taxNqlr4lNyCTnfgxGnqvTd/1Jytj1VdcmfjKrvtFGmfmul90NcCu25j7FlLy1zOsmvJ6\n\tiGQ57z5WOPbwUPlg9yIB1Nrt5xl6ZaqOpi1STBo3hI13GPNyydbHxYOOGOz1meYKknoo\n\t6LpCdm71UZODQkICR9HyWcQgLbNQAqAwL/XrA9PUM0EaB40X0yOWILFQzvY68E28ErOj\n\tW20tlB/v+LmfqrWwyml6AWNAxw99mWzXJpB2pt6E/s8MKvm7MQDWUBL/fEWinafZD0Fn\n\t16Mg==","X-Gm-Message-State":"AHPjjUhadCdSkDXPL6mjm2R/IS+Fso8CrWk0iwGQZ96SNAN185GbkrDf\n\tKpTD2Ih7QvGbOUvr0gyCx8I=","X-Google-Smtp-Source":"AOwi7QBI1mqxOdSl/HSyhp0dHdVlrR6Byx8iW7OJK1WslPP1n18aluEMNRGfaoyzsAiv9YdatDMR3A==","X-Received":"by 10.28.220.85 with SMTP id t82mr497385wmg.95.1506592000442;\n\tThu, 28 Sep 2017 02:46:40 -0700 (PDT)","From":"Romain Izard ","To":"Boris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd , Lee Jones ,\n\tWenyou Yang , Josh Wu , \n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tJiri Slaby , Alan Stern , \n\tLudovic Desroches ,\n\tNicolas Ferre ,\n\tAlexandre Belloni ","Subject":"[PATCH v4 1/8] clk: at91: pmc: Wait for clocks when resuming","Date":"Thu, 28 Sep 2017 11:46:20 +0200","Message-Id":"<20170928094627.31017-2-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170928094627.31017-1-romain.izard.pro@gmail.com>","References":"<20170928094627.31017-1-romain.izard.pro@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170928_024702_251594_9183ED1C ","X-CRM114-Status":"GOOD ( 13.44 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, Romain Izard , \n\tlinux-clk@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Wait for the syncronization of all clocks when resuming, not only the\nUPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\nwhen interrupts are masked, which is the case in here.\n\nSigned-off-by: Romain Izard \nAcked-by: Ludovic Desroches \nAcked-by: Nicolas Ferre \n---\n drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\nindex 775af473fe11..5c2b26de303e 100644\n--- a/drivers/clk/at91/pmc.c\n+++ b/drivers/clk/at91/pmc.c\n@@ -107,10 +107,20 @@ static int pmc_suspend(void)\n \treturn 0;\n }\n \n+static bool pmc_ready(unsigned int mask)\n+{\n+\tunsigned int status;\n+\n+\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n+\n+\treturn ((status & mask) == mask) ? 1 : 0;\n+}\n+\n static void pmc_resume(void)\n {\n-\tint i, ret = 0;\n+\tint i;\n \tu32 tmp;\n+\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n \n \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n \tif (pmc_cache.mckr != tmp)\n@@ -134,13 +144,11 @@ static void pmc_resume(void)\n \t\t\t AT91_PMC_PCR_CMD);\n \t}\n \n-\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n-\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n-\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n-\t\t\t\t\t 10, 5000);\n-\t\tif (ret)\n-\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n-\t}\n+\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n+\t\tmask |= AT91_PMC_LOCKU;\n+\n+\twhile (!pmc_ready(mask))\n+\t\tcpu_relax();\n }\n \n static struct syscore_ops pmc_syscore_ops = {\n","prefixes":["v4","1/8"]}