{"id":819468,"url":"http://patchwork.ozlabs.org/api/patches/819468/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170928094627.31017-2-romain.izard.pro@gmail.com/","project":{"id":38,"url":"http://patchwork.ozlabs.org/api/projects/38/?format=json","name":"Linux PWM development","link_name":"linux-pwm","list_id":"linux-pwm.vger.kernel.org","list_email":"linux-pwm@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170928094627.31017-2-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-28T09:46:20","name":"[v4,1/8] clk: at91: pmc: Wait for clocks when resuming","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3c0aefa7e09b25b04e247655ccad78b77581748f","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170928094627.31017-2-romain.izard.pro@gmail.com/mbox/","series":[{"id":5525,"url":"http://patchwork.ozlabs.org/api/series/5525/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/list/?series=5525","date":"2017-09-28T09:46:20","name":"Various patches for SAMA5D2 backup mode","version":4,"mbox":"http://patchwork.ozlabs.org/series/5525/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819468/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819468/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SRLnD8K5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2qbG13hhz9t3w\n\tfor ;\n\tThu, 28 Sep 2017 19:46:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752721AbdI1Jqp (ORCPT );\n\tThu, 28 Sep 2017 05:46:45 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:53260 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752376AbdI1Jqm (ORCPT\n\t); Thu, 28 Sep 2017 05:46:42 -0400","by mail-wm0-f67.google.com with SMTP id q132so1042619wmd.2;\n\tThu, 28 Sep 2017 02:46:41 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\tz10sm3272395wre.6.2017.09.28.02.46.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Sep 2017 02:46:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SXCU17pSZBd7SdVZm1ZcLIHKqn3I6ldleFFnCs7nces=;\n\tb=SRLnD8K5pCMArMDGvBIvj8liP7zplU//N5qwgHFz6d5K1Un7AoehbHni7ga1RSWLOL\n\tYj3mel1Aqtb08aQAJSyhe16FwtvN8naV7DNdxWKHQVZISzR/q8D0L071wJlP2ucR9Fmu\n\t1zPZD8YQxEkC5zG04cHKyN73hWQ8/GAiI7yBaHne1nj1hX+mXnU8UKkzqvaqp8sIxwFu\n\t7SDJ0nzaSM0yYjvxhbHuXgkCef3tZOZVzr1W8zFII4r2XCPt+0baJ22Ngdi/aQRJV00L\n\tVZJARAWobjaDU3z9zj5HVAu0Vm8sfSUa/blaE03SDUxoQXoU5Ra2eM5arOWkP9Ng/eEn\n\tqaXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SXCU17pSZBd7SdVZm1ZcLIHKqn3I6ldleFFnCs7nces=;\n\tb=TyawsUbuH7MtZZgrj8MAdWk3BhcNii/3h42/Vyrwl5B9nPa3Y/iHoi/qkFAweoPWKK\n\t08rifrk+xuC8qRcZEfjcW26lecLvPuhLuqQjnYj3OtxxybrDJ0lJAzZE+/VwfCW1D0XG\n\t4XdwBO/o+GqyCw19qXYZsh34ntahom5Xy/kxPB7PLoVCvPmqonkujC9KkSFbpSQO29HW\n\tKiASq2b0/OiGNqZvxAbQrV9/bIYh4Pu675y9V3PFOiW0bMItf2lfvS4lGZuQ/o8cwCRp\n\tdu/YAB4/bsTMF/lxM8zI+r/Zl20DNetBr73y2XhBO+8X6RtEVQY4sPpZ9jFnIGyYBdJY\n\tby/Q==","X-Gm-Message-State":"AHPjjUiQJaVdjv4wi9Uy7qrWZotY5q7VSwTJvDs+gqE1V/Ytr6EYLlku\n\tedHwYt/NaKczwnEtxzjFoB8=","X-Google-Smtp-Source":"AOwi7QBI1mqxOdSl/HSyhp0dHdVlrR6Byx8iW7OJK1WslPP1n18aluEMNRGfaoyzsAiv9YdatDMR3A==","X-Received":"by 10.28.220.85 with SMTP id t82mr497385wmg.95.1506592000442;\n\tThu, 28 Sep 2017 02:46:40 -0700 (PDT)","From":"Romain Izard ","To":"Boris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd , Lee Jones ,\n\tWenyou Yang , Josh Wu ,\n\tRichard Weinberger ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tJiri Slaby , Alan Stern ,\n\tLudovic Desroches ,\n\tNicolas Ferre ,\n\tAlexandre Belloni ","Cc":"linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org,\n\tlinux-serial@vger.kernel.org, linux-usb@vger.kernel.org,\n\tRomain Izard ","Subject":"[PATCH v4 1/8] clk: at91: pmc: Wait for clocks when resuming","Date":"Thu, 28 Sep 2017 11:46:20 +0200","Message-Id":"<20170928094627.31017-2-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170928094627.31017-1-romain.izard.pro@gmail.com>","References":"<20170928094627.31017-1-romain.izard.pro@gmail.com>","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"},"content":"Wait for the syncronization of all clocks when resuming, not only the\nUPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\nwhen interrupts are masked, which is the case in here.\n\nSigned-off-by: Romain Izard \nAcked-by: Ludovic Desroches \nAcked-by: Nicolas Ferre \n---\n drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\nindex 775af473fe11..5c2b26de303e 100644\n--- a/drivers/clk/at91/pmc.c\n+++ b/drivers/clk/at91/pmc.c\n@@ -107,10 +107,20 @@ static int pmc_suspend(void)\n \treturn 0;\n }\n \n+static bool pmc_ready(unsigned int mask)\n+{\n+\tunsigned int status;\n+\n+\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n+\n+\treturn ((status & mask) == mask) ? 1 : 0;\n+}\n+\n static void pmc_resume(void)\n {\n-\tint i, ret = 0;\n+\tint i;\n \tu32 tmp;\n+\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n \n \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n \tif (pmc_cache.mckr != tmp)\n@@ -134,13 +144,11 @@ static void pmc_resume(void)\n \t\t\t AT91_PMC_PCR_CMD);\n \t}\n \n-\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n-\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n-\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n-\t\t\t\t\t 10, 5000);\n-\t\tif (ret)\n-\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n-\t}\n+\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n+\t\tmask |= AT91_PMC_LOCKU;\n+\n+\twhile (!pmc_ready(mask))\n+\t\tcpu_relax();\n }\n \n static struct syscore_ops pmc_syscore_ops = {\n","prefixes":["v4","1/8"]}